Skip to content

Instantly share code, notes, and snippets.

@RyanMulready
Last active July 10, 2018 12:27
Show Gist options
  • Save RyanMulready/9a195ae876cab07cc555de43b3b00281 to your computer and use it in GitHub Desktop.
Save RyanMulready/9a195ae876cab07cc555de43b3b00281 to your computer and use it in GitHub Desktop.

Vuex/API

  • Split into module approach https://vuex.vuejs.org/guide/modules.html
  • Rename actions, mutations and getters into something more standard
  • Better approach to generic mutations key, value isn't ideal
  • Get empty schema from api instead of having it as a const
  • Analytics API reliance on store data requires multiple unnecessary api requests
  • Promised based sync is not ideal, need investigation into alternative approach

Webpack Optimization

Styling Updates

  • 404 and Server Error Pages are unstyled
  • Tooltips black on white text don't match theme at all
  • Footer does not exist

Roofdraw Improvements

  • RoofLayer should be a Leaflet layer group not a polygon
  • Algorithm for determining most possible panels is 'dumb'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment