Skip to content

Instantly share code, notes, and snippets.

@Sharparam
Created January 8, 2020 23:20
Show Gist options
  • Save Sharparam/f73727aa916389266ac9060dac629f3f to your computer and use it in GitHub Desktop.
Save Sharparam/f73727aa916389266ac9060dac629f3f to your computer and use it in GitHub Desktop.
diff --git a/src/Microsoft.DocAsCode.Metadata.ManagedReference/ExtractMetadataWorker.cs b/src/Microsoft.DocAsCode.Metadata.ManagedReference/ExtractMetadataWorker.cs
index d5bbf6dd1..8ea756eac 100644
--- a/src/Microsoft.DocAsCode.Metadata.ManagedReference/ExtractMetadataWorker.cs
+++ b/src/Microsoft.DocAsCode.Metadata.ManagedReference/ExtractMetadataWorker.cs
@@ -160,7 +160,7 @@ namespace Microsoft.DocAsCode.Metadata.ManagedReference
// If the project is supported, add to project dictionary, otherwise, ignore
if (projectFile.Type == FileType.Project)
{
- projectCache.GetOrAdd(projectFile.NormalizedPath,
+ projectCache.GetOrAdd(projectFile.NormalizedPath,
s => _loader.Load(projectFile.NormalizedPath));
}
else
@@ -285,11 +285,11 @@ namespace Microsoft.DocAsCode.Metadata.ManagedReference
// Build all the projects to get the output and save to cache
List<MetadataItem> projectMetadataList = new List<MetadataItem>();
ConcurrentDictionary<string, bool> projectRebuildInfo = new ConcurrentDictionary<string, bool>();
- ConcurrentDictionary<string, AbstractCompilation> compilationCache =
+ ConcurrentDictionary<string, AbstractCompilation> compilationCache =
await GetProjectCompilationAsync(projectCache);
var roslynProjects = compilationCache.Values.OfType<RoslynCompilation>().Select(rc => rc.Compilation);
- options.RoslynExtensionMethods =
- RoslynIntermediateMetadataExtractor.GetAllExtensionMethodsFromCompilation(roslynProjects);
+ options.RoslynExtensionMethods =
+ RoslynIntermediateMetadataExtractor.GetAllExtensionMethodsFromCompilation(roslynProjects);
foreach (var key in GetTopologicalSortedItems(projectDependencyGraph))
{
var dependencyRebuilt = projectDependencyGraph[key].Any(r => projectRebuildInfo[r]);
@@ -352,7 +352,7 @@ namespace Microsoft.DocAsCode.Metadata.ManagedReference
var controller = new RoslynSourceFileBuildController(assemblyCompilation, assembly);
var mta = GetMetadataFromProjectLevelCache(controller, input);
-
+
if (mta != null)
{
MergeCommentsHelper.MergeComments(mta.Item1, commentFiles);
@@ -527,7 +527,8 @@ namespace Microsoft.DocAsCode.Metadata.ManagedReference
var members = model.Members;
foreach (var memberModel in members)
{
- var fileName = useCompatibilityFileName ? memberModel.Name : memberModel.Name.Replace('`', '-');
+ var fileName = memberModel.Name.Replace('<', '-').Replace('>', '-');
+ fileName = useCompatibilityFileName ? fileName : fileName.Replace('`', '-');
var outputFileName = GetUniqueFileNameWithSuffix(fileName + Constants.YamlExtension, outputFileNames);
string itemFilePath = Path.Combine(folder, outputFileName);
var memberViewModel = memberModel.ToPageViewModel();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment