gistfile1.txt

      @user_groups = {}
      if params[:filter] && params[:filter][:dynamic]
        group_ids = feed_search.dynamic_usertags.collect { |e| e.gsub('group_id:','') }
        group_ids.each do |group_id|
          group = Group.find group_id
          @user_groups[group.primary_filter.name.downcase] = group if group
        end
      end

# Refactor

@user_groups = {}
if params[:filter] && params[:filter][:dynamic]
  primary_filter_groups = current_user.groups.with_primary_filter

  params[:filter][:dynamic].each do |dyn|
    group = primary_filter_groups.select{ |g| g.primary_filter.filter_type == dyn }
    @user_groups[group.primary_filter.filter_type] = group if group
  end
end

Here's my final refactor. Moved the query by filter type to a named scope.

if params[:filter] && params[:filter][:dynamic]
@user_groups = Hash[*current_user.groups.with_primary_filter.by_filter_type(
params[:filter][:dynamic]
).collect{ |group|
[group.primary_filter.filter_type, group]
}.compact.flatten]
end