OXC Commendation ideas

gistfile1.txt

// BUGS //
1) Psi attacks may be causing mission state kills and diary state kills to not add up. What about non-alien kills? (http://openxcom.org/forum/index.php/topic,4393.msg60225.html#msg60225)

// ISSUES //
1) Mercy Cross still not working correctly?
2) Heroic Order being given to soldiers despite not being the new best
3) Investigate Long Shot and Lucky Shot commendations
4) Reduce savefile bloat.
    4.1 Make use of BattleUnitKills to calculate totals
    4.2 Make use of MissionStatistics to calculate totals
        4.2.1 Save MissionStatistics as well ...?
    4.3 Clean up dead soldier medals
    4.4 Consider saving fewer things if the player is playing vanilla

// IDEAS //
1) Add a commendation for killing a unit that was not the target.
2) Track destroyed tiles, award commendations based on it.
3) Have cause of death in the memorial screen for soldiers.
4) Psi related awards (resisting attacks, re-MCing your own unit)
5) Assist awards (hitting but not killing, hitting but not damaging)
6) List more things in the LOST IN SERVICE screen
    6.1 Stats: rank, score, number of missions, kills/stuns, cause of death? Times hit? Total commendations?
    6.2 Commendations
    6.3 Cause of death
    6.4 Mission count
7) One time only awards
    lead: Create a std::vector<bool> of one time only commendations, like first to capture a Navitagor. It will be saved in SavedGame, same place as MissionStatistics.
8) Add more cumulative stats...? kill share % is bad, kills per mission is bad
9) End of game stats: alien stats. How many shots were fired at you? What was their accuracy? etc.

// BIG IDEAS //
1) Differentiate between ufo1 and ufo2 commendations: some should only be visible in the ufopaedia and awardable in a specific game. (Perhaps via an enum, 0 1 2, where 0 is both games and the default)
2) Create graphs for soldier stats (see http://openxcom.org/forum/index.php/topic,1718.msg49479.html#msg49479).
3) Standardize nomenclature in ruleset and source code, template commendations (see http://openxcom.org/forum/index.php/topic,1718.msg48236.html#msg48236 .
4) Have an option dialogue for players to select which stats are displayed.

Hey Shoes, so I've been keeping tabs on the medals during my current campaign which is almost over. Here are issues I've discovered. I can provide save files for any of them if it will help.

1. No RIP screen after a lost base defense mission. Yes, I learned this one first hand, haha.
2. Mind control and stunning are being counted as “kills” for the purposes of performance citation and race “xenocide” medals.
3. Athena Citation: Goes out to troops even when they don’t improve their stats at all. Gets handed out all the time way too easily so something is incorrect with the criteria I think.
4. Medal of Valor: This is medal for the “lone survivor” who saves the drop ship. I found out once by experience that it didn’t work and then upon further testing I got it to work once, but most tests it didn’t work. No idea why.
5. Weapon Proficiency Medals: Friendly fire kills count towards them.
6. Performance Citation: Should have multiple levels, but never gets awarded past the first one.
7. Improvisation kills not being applied towards Merit Star award even though they count towards kill count and other medals.

This is close to a year later, but hey!

1. Should be fixed now
2. I have not tested the mind control/stun counting towards the performance citation; it should strictly be dead hostiles - I recently mucked about in the code there so maybe I inadvertently fixed it. They do count towards the Xenocide medal, and it's debatable if they should. The definition says "successful in combating" the alien.
3. It does get handed out too easily.
4. I've tested both "one survivor" commendations; do note that Medal of Valor is not awarded if there is any friendly fire by the surviving soldier.
5. Fixed.
6. I'll look into it.
7. That may be because improv kills are "mysteries" to the code. It's sort of a catch all.

Hi Shoes,

I'm getting the following error with the latest Nightly (openxcom_git_master_2017_05_04_0045):

[02-05-2017_22-01-39]	[WARN]	disabling mod with invalid ruleset: Commendations
[02-05-2017_22-01-39]	[ERROR]	failed to load 'Commendations'; mod disabled for next startup
C:\Program Files\OpenXcom\user\mods\Commendations/Commendations.rul: yaml-cpp: error at line 1003, column 9: bad conversion

What could be the problem?

Okay, I found the problem: I left the Commendations_TFTD.rul in the folder for future use, because I thought it is used only by TFTD, and hence the error message. Deleted it and Commendations loads fine. Sorry for the confusion.