Skip to content

Instantly share code, notes, and snippets.

@ShyamsundarR
Created September 25, 2018 12:45
Show Gist options
  • Save ShyamsundarR/97cd8989337dc4f2e6aa62d260d654e1 to your computer and use it in GitHub Desktop.
Save ShyamsundarR/97cd8989337dc4f2e6aa62d260d654e1 to your computer and use it in GitHub Desktop.
gdeploy]$ git diff
diff --git a/modules/backend_reset.py b/modules/backend_reset.py
index e37a969..1692bc3 100644
--- a/modules/backend_reset.py
+++ b/modules/backend_reset.py
@@ -32,13 +32,10 @@ class BackendReset(object):
def __init__(self, module):
self.output = []
self.module = module
- try:
- self.pvs = literal_eval(self.validated_params('pvs'))
- except:
- self.pvs = None
+ self.pvs = self.module.params.get('pvs') or None
self.vgs = self.module.params.get('vgs') or None
self.lvs = self.module.params.get('lvs') or None
- self.unmount = self.module.params.get('unmount') or 'no'
+ self.unmount = self.module.params.get('unmount') or False
self.mountpoints = self.module.params.get('mountpoints') or None
self.remove_lvs()
self.remove_vgs()
@@ -94,7 +91,7 @@ class BackendReset(object):
self.output.append([rc, out, err])
def umount_bricks(self):
- if not self.unmount or literal_eval(self.unmount)[0].lower() != 'yes':
+ if not self.unmount:
return
if not self.mountpoints:
return
@@ -157,10 +154,10 @@ class BackendReset(object):
if __name__ == '__main__':
module = AnsibleModule(
argument_spec=dict(
- pvs=dict(),
+ pvs=dict(type='list'),
vgs=dict(),
lvs=dict(type='str'),
- unmount=dict(),
+ unmount=dict(type='bool', default='no'),
mountpoints=dict(),
),
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment