Skip to content

Instantly share code, notes, and snippets.

@Smith1123
Created May 13, 2011 10:15
Show Gist options
  • Save Smith1123/970301 to your computer and use it in GitHub Desktop.
Save Smith1123/970301 to your computer and use it in GitHub Desktop.
testRepaint()
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 54b9ec8..b0c9691 100644
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2011-05-13 Zsolt Fehér <h490267@stud.u-szeged.hu>
+
+ Reviewed by NOBODY (OOPS!).
+
+ Implement testRepaint.
+ Some tests expected image is wrong.
+
+ * fast/repaint/text-emphasis-h.html: Added.
+ * fast/repaint/text-emphasis-v.html: Added.
+
+ * platform/qt/Skipped:
+
2011-05-09 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Benjamin Poulain.
diff --git a/LayoutTests/platform/qt/Skipped b/LayoutTests/platform/qt/Skipped
index b97d19f..dac8500 100644
--- a/LayoutTests/platform/qt/Skipped
+++ b/LayoutTests/platform/qt/Skipped
@@ -729,12 +729,6 @@ http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html
# Missing layoutTestController.setValueForUser()
fast/forms/onchange-setvalueforuser.html
-# Missing layoutTestController.testRepaint()
-fast/repaint/table-writing-modes-h.html
-fast/repaint/table-writing-modes-v.html
-fast/repaint/text-emphasis-h.html
-fast/repaint/text-emphasis-v.html
-
# This requires didClearWindowObjectForFrameInIsolatedWorld foo in FrameLoaderClient
http/tests/security/isolatedWorld/didClearWindowObject.html
# This needs more investigation
@@ -2695,3 +2689,8 @@ fast/events/page-visibility-iframe-delete-test.html
fast/events/page-visibility-iframe-move-test.html
fast/events/page-visibility-iframe-propagation-test.html
fast/events/page-visibility-transition-test.html
+
+# [Qt]fast/repaint/text-emphasis tests fail
+# https://bugs.webkit.org/show_bug.cgi?id=60756
+fast/repaint/text-emphasis-h.html
+fast/repaint/text-emphasis-v.html
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index c71dc45..6317965 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,15 @@
+2011-05-13 Zsolt Fehér <h490267@stud.u-szeged.hu>
+
+ Reviewed by NOBODY (OOPS!).
+
+ Implement Test Repaint
+
+ * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
+ (LayoutTestController::reset):
+ (LayoutTestController::testRepaint):
+ (LayoutTestController::repaintSweepHorizontally):
+ * DumpRenderTree/qt/LayoutTestControllerQt.h:
+
2011-05-09 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Andreas Kling.
diff --git a/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp b/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
index 9ccb9b4..3173ebe 100644
--- a/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
+++ b/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
@@ -72,6 +72,8 @@ void LayoutTestController::reset()
m_isGeolocationPermissionSet = false;
m_isPrinting = false;
m_geolocationPermission = false;
+ m_testRepaint = false;
+ m_sweepHorizontally = false;
DumpRenderTreeSupportQt::dumpEditingCallbacks(false);
DumpRenderTreeSupportQt::dumpFrameLoader(false);
@@ -224,6 +226,18 @@ void LayoutTestController::display()
emit showPage();
}
+void LayoutTestController::testRepaint()
+{
+ m_testRepaint = true;
+ m_drt->webPage()->history();
+}
+
+void LayoutTestController::repaintSweepHorizontally()
+{
+ m_sweepHorizontally = true;
+ m_drt->webPage()->history();
+}
+
void LayoutTestController::clearBackForwardList()
{
m_drt->webPage()->history()->clear();
diff --git a/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h b/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h
index c66650b..f886fe2 100644
--- a/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h
+++ b/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h
@@ -133,6 +133,8 @@ public slots:
bool checkDesktopNotificationPermission(const QString& origin);
void simulateDesktopNotificationClick(const QString& title);
void display();
+ void testRepaint();
+ void repaintSweepHorizontally();
void clearBackForwardList();
QString pathToLocalResource(const QString& url);
void dumpTitleChanges() { m_dumpTitleChanges = true; }
@@ -295,6 +297,8 @@ private:
bool m_isGeolocationPermissionSet;
bool m_isPrinting;
bool m_geolocationPermission;
+ bool m_testRepaint;
+ bool m_sweepHorizontally;
QUrl m_userStyleSheetLocation;
QBasicTimer m_timeoutTimer;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment