Skip to content

Instantly share code, notes, and snippets.

@SpainTrain
Created October 10, 2016 14:25
Show Gist options
  • Save SpainTrain/60c8fe9d721d91ed959694dd28fb71b9 to your computer and use it in GitHub Desktop.
Save SpainTrain/60c8fe9d721d91ed959694dd28fb71b9 to your computer and use it in GitHub Desktop.
GK PR that incorrectly links GH issues

Hello lovely humans,

eslint-plugin-react just published its new version 6.4.0.

State Failing tests 🚨
Dependency eslint-plugin-react
New version 6.4.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build went from success to failure.

As eslint-plugin-react is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


GitHub Release

Added

Fixed

  • Fix jsx-no-bind crash on arrow functions (#854)
  • Fix display-name false negative on es6-style method in React.createClass (#852)
  • Fix prefer-stateless-function to allow components with childContextTypes (#853)
  • Fix no-children-prop spread support (#862 @randycoulman)
  • Fix no-unused-prop-types to ignore validation when spread is used (#840)
  • Fix jsx-closing-bracket-location for multi-line prop (#889)
  • Fix jsx-indent in multi-line function calls (#895)
  • Fix jsx-indent in multi-line logical expressions (#540)

Changed


The new version differs by 56 commits .

  • 608c14a Update CHANGELOG and bump version
  • 29de657 Update dependencies
  • 963267a Fix jsx-indent in multi-line logical expressions (fixes #540)
  • 1e1c5c6 Fix jsx-indent in multi-line function calls (fixes #895)
  • e2f72f1 Fix jsx-closing-bracket-location for multi-line prop (fixes #889)
  • a1b8d45 Add ES6 import example to "jsx in scope" docs
  • fc7b02a Merge pull request #876 from manovotny/patch-1
  • ac548a0 Adds missing rule name for jsx-no-bind.
  • b464cf1 Add skipUndeclared option to prop-types rule
  • cc39fb8 Merge pull request #830 from eelyafi/jsx_indent_fixer
  • 90af71b Added note to the docs
  • 3f393a2 Fix no-unused-prop-types to ignore validation when spread is used (fixes #840)
  • f227eb4 Fix no-children-prop spread support
  • 2adefb7 Merge pull request #863 from corydolphin/patch-1
  • 0fa8c76 Fixes incorrect grammar in react/prefer-stateless-function docs

There are 56 commits in total. See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚡ greenkeeper upgrade


This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment