Skip to content

Instantly share code, notes, and snippets.

@StefanKarpinski
Created February 20, 2017 20:08
diff --git a/base/fft/FFTW.jl b/base/fft/FFTW.jl
index d68e302c98..952700283c 100644
--- a/base/fft/FFTW.jl
+++ b/base/fft/FFTW.jl
@@ -20,7 +20,7 @@ export export_wisdom, import_wisdom, import_system_wisdom, forget_wisdom,
const libfftw = Base.libfftw_name
const libfftwf = Base.libfftwf_name
-const version = convert(VersionNumber, split(unsafe_string(cglobal((:fftw_version,Base.DFT.FFTW.libfftw), UInt8)), ['-', ' '])[2])
+const version = convert(VersionNumber, collect(split(unsafe_string(cglobal((:fftw_version,Base.DFT.FFTW.libfftw), UInt8)), ['-', ' ']))[2])
## Direction of FFT
diff --git a/base/markdown/GitHub/table.jl b/base/markdown/GitHub/table.jl
index dc31fad954..e87411df2c 100644
--- a/base/markdown/GitHub/table.jl
+++ b/base/markdown/GitHub/table.jl
@@ -8,7 +8,7 @@ end
function parserow(stream::IO)
withstream(stream) do
line = readline(stream)
- row = split(line, r"(?<!\\)\|")
+ row = collect(split(line, r"(?<!\\)\|"))
length(row) == 1 && return
row[1] == "" && shift!(row)
map!(x -> strip(replace(x, "\\|", "|")), row, row)
diff --git a/base/markdown/render/plain.jl b/base/markdown/render/plain.jl
index 01a3a8994d..f0ca89a7c2 100644
--- a/base/markdown/render/plain.jl
+++ b/base/markdown/render/plain.jl
@@ -56,7 +56,7 @@ end
function plain(io::IO, f::Footnote)
print(io, "[^", f.id, "]:")
s = sprint(plain, f.text)
- lines = split(rstrip(s), "\n")
+ lines = collect(split(rstrip(s), "\n"))
# Single line footnotes are printed on the same line as their label
# rather than taking up an additional line.
if length(lines) == 1
diff --git a/base/markdown/render/rst.jl b/base/markdown/render/rst.jl
index ca5661520b..697db58a65 100644
--- a/base/markdown/render/rst.jl
+++ b/base/markdown/render/rst.jl
@@ -60,7 +60,7 @@ end
function rst(io::IO, f::Footnote)
print(io, ".. [", f.id, "]")
s = sprint(rst, f.text)
- lines = split(rstrip(s), "\n")
+ lines = collect(split(rstrip(s), "\n"))
# Single line footnotes are printed on the same line as their label
# rather than taking up an additional line.
if length(lines) == 1
diff --git a/base/markdown/render/terminal/formatting.jl b/base/markdown/render/terminal/formatting.jl
index 1d14f1d60b..048113599a 100644
--- a/base/markdown/render/terminal/formatting.jl
+++ b/base/markdown/render/terminal/formatting.jl
@@ -54,8 +54,8 @@ function ansi_length(s)
replace(s, r"\e\[[0-9]+m", "") |> length
end
-words(s) = split(s, " ")
-lines(s) = split(s, "\n")
+words(s) = collect(split(s, " "))
+lines(s) = collect(split(s, "\n"))
# This could really be more efficient
function wrapped_lines(s::AbstractString; width = 80, i = 0)
diff --git a/base/path.jl b/base/path.jl
index 6b04246a5f..c65777814d 100644
--- a/base/path.jl
+++ b/base/path.jl
@@ -216,7 +216,7 @@ function normpath(path::String)
isabs = isabspath(path)
isdir = isdirpath(path)
drive, path = splitdrive(path)
- parts = split(path, path_separator_re)
+ parts = collect(split(path, path_separator_re))
filter!(x->!isempty(x) && x!=".", parts)
while true
clean = true
@@ -339,8 +339,8 @@ function relpath(path::String, startpath::String = ".")
curdir = "."
pardir = ".."
path == startpath && return curdir
- path_arr = split(abspath(path), path_separator_re)
- start_arr = split(abspath(startpath), path_separator_re)
+ path_arr = collect(split(abspath(path), path_separator_re))
+ start_arr = collect(split(abspath(startpath), path_separator_re))
i = 0
while i < min(length(path_arr), length(start_arr))
i += 1
diff --git a/base/socket.jl b/base/socket.jl
index 421e6fece7..022e34c96f 100644
--- a/base/socket.jl
+++ b/base/socket.jl
@@ -164,7 +164,7 @@ If the address is in octal or hexadecimal, convert it to decimal, otherwise remo
"""
function parse(::Type{IPv4}, str::AbstractString)
- fields = split(str,'.')
+ fields = collect(split(str,'.'))
i = 1
ret = 0
for f in fields
@@ -215,7 +215,7 @@ end
parseipv6fields(fields) = parseipv6fields(fields,8)
function parse(::Type{IPv6}, str::AbstractString)
- fields = split(str,':')
+ fields = collect(split(str,':'))
if length(fields) > 8
throw(ArgumentError("too many fields in IPv6 address"))
elseif length(fields) == 8
diff --git a/base/version.jl b/base/version.jl
index 956763ce27..54312f712b 100644
--- a/base/version.jl
+++ b/base/version.jl
@@ -79,7 +79,7 @@ const VERSION_REGEX = r"^
$"ix
function split_idents(s::AbstractString)
- idents = split(s, '.')
+ idents = collect(split(s, '.'))
ntuple(length(idents)) do i
ident = idents[i]
ismatch(r"^\d+$", ident) ? parse(Int, ident) : String(ident)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment