After reading Rouan Wilsenach’s article on Ship / Show / Ask, I realized that when creating a pull request, I’m thinking about:
- How can I confidently get my code out of the door?
- Will my changes pass the automated CI checks?
- Will my changes pass a self-review? I.e. would I approve my own PR?
- Will my colleagues be able to give me good feedback?
I’m so confident in my changes (e.g. documentation changes), I don’t need to see if they’ll pass CI. Ship it now!
This is probably a proof-of-concept, and I want to see what the CI thinks of my approach. It may never leave draft.
I’m confident of my changes, but I want the CI to check them. If they pass CI, they can be merged (e.g. using Github’s “Enable auto-merge”).
This is a CI review, but I want to review my own work as if I was one of the official reviewers.
I want my colleagues to be able to take a look, as there is something new and interesting in this pull requests they’ll want to know about.
I want my colleagues to be able to take a look. I’m going to merge this as soon as it passes CI, but they’ve been notified and can review it if they want to.
I want my colleagues to take a good look. I’m not confident in my changes, and I know that at least one of my colleagues will be able to give good feedback on it.