BuddyPress version 2.9.4: Auto verify new emails when users update them in their profiles.

functions.php

<?php
/**
 * Auto verify user email changes.
 *
 * @return void
 */
function custombp_auto_verify_email_change() {
	// Double check this is happening on the settings page.
	check_admin_referer('bp_settings_general');

	// Get the current users id from the display.
	$pending_email = bp_get_user_meta( bp_displayed_user_id(), 'pending_email_change', true );

	// Set the $_GET var with the proper hash.
	$_GET['verify_email_change'] = $pending_email['hash'];

	// Call the verification function
	bp_settings_verify_email_change();
}
add_action( 'bp_core_general_settings_after_save', 'custombp_auto_verify_email_change', 10, 0 );

Please use with caution. This will most likely not be comparable with BuddyPress 3.0.0