Skip to content

Instantly share code, notes, and snippets.

@VizualAbstract
Last active September 25, 2018 16:49
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save VizualAbstract/afcbfd7a5132416480a10b221d1744e4 to your computer and use it in GitHub Desktop.
Save VizualAbstract/afcbfd7a5132416480a10b221d1744e4 to your computer and use it in GitHub Desktop.
Des and Frontend notes

Des tasks

Pending PRs


One time product

On theme engine
On old portal

In QA

  • Steve to test out One-Time product
  • Make sure Steve has ability to test Theme Engine PRs on Heroku
  • Give him access to Heroku
    • Squad-based Heroku
    • Get Deploy with Heroku on CircleCI working (alex)
  • Was given an overview on the theme engine
  • Get him set up with deploying a dev app

Theme engine

Templates
  • Add One-Time layout updates to Legacy theme
Update routes
  • Showing discounted price legacy themes add to one-time product branch?
  • Check with Nikola on spreadsheet comparing objects
    • Spreadsheet: API vs Theme Engine objects
    • Needs JSON Object sample data
      • We have Theme Engine sample JSON in the GitHub wiki for Theme Engine
      • We have API sample JSON in the API docs
    • Write out strategy and TP issues

[ShopPort] Subscription Manager Mobile First

Broken up in to stories and ordered in suggested approach

  • Decide on grid system (steal from our app)

  • Render theme engine without proxy (Derek)

  • Connect with George

    Where we're at:
    • George will not provide a desktop theme
    • For certain things, like Skip, do we do seperate pagers for secondary or tertiary actions or modals
    • Kayla will figure out design
    • We have screenshots stolen from George's design

Customer portal authentication

  • Never on Des's plate

Theme engine (specific)

Updating routes

Nikola has a spreadsheet of routes that differ between API and Theme Engine

Spreadsheet: API vs Theme Engine endpoints

Tasks for Nikola
  1. Add any routes still missing from the spreadsheet
  2. Additional ways of labeling the routes:
    • Which route needs can be renamed?
      • These are "work-around" routes
      • Example: the API uses /charge/skip, but Theme Engine uses /subscription/skip
    • Which routes need to be built in the API?
      • If the feature doesn't exist.
      • Example: API doesn't allow product swapping
    • Is the route used by the existing Customer Portal?
      • Is this something old customer portal can currently do?
      • Example: We don't let customers delete orders or clone them, so no.
  3. Take the new information in the spreadsheet and present to Mike to review
  4. JSON samples of Theme Engine vs API
    • Use references from Wiki Docs (theme engine) and API docs (API)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment