Skip to content

Instantly share code, notes, and snippets.

@Xuanwo

Xuanwo/gist:f26a9a519a6c99bac83d9819d6651c6a

Created February 21, 2024 07:27
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save Xuanwo/f26a9a519a6c99bac83d9819d6651c6a to your computer and use it in GitHub Desktop.
Save Xuanwo/f26a9a519a6c99bac83d9819d6651c6a to your computer and use it in GitHub Desktop.
Download ZIP
Raw
gistfile1.txt
error: digits grouped inconsistently by underscores
--> src/solver/state.rs:74:51
|
74 | instance.movements.move_count() * 10000_0000
| ^^^^^^^^^^ help: consider: `100_000_000`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping
= note: `-D clippy::inconsistent-digit-grouping` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::inconsistent_digit_grouping)]`
error: digits grouped inconsistently by underscores
--> src/solver/state.rs:79:51
|
79 | instance.movements.push_count() * 10000_0000
| ^^^^^^^^^^ help: consider: `100_000_000`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping
error: constants have by default a `'static` lifetime
--> src/main.rs:37:26
|
37 | const CONFIG_FILE_PATH: &'static str = "config.toml";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `-D clippy::redundant-static-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_static_lifetimes)]`
error: constants have by default a `'static` lifetime
--> src/main.rs:50:30
|
50 | const KEYMAP_FILE_PATH: &'static str = "keymap.toml";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
error: unneeded `return` statement
--> src/board.rs:49:9
|
49 | return true;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
49 - return true;
49 + true
|
error: using `clone` on type `Matrix<i32, Const<2>, Const<1>, ArrayStorage<i32, 2, 1>>` which implements the `Copy` trait
--> src/board.rs:104:45
|
104 | self.move_crate(crate_position, self.level.player_position.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.level.player_position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`
error: name `HUD` contains a capitalized acronym
--> src/components.rs:18:12
|
18 | pub struct HUD;
| ^^^ help: consider making the acronym lowercase, except the initial letter: `Hud`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
= note: `-D clippy::upper-case-acronyms` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::upper_case_acronyms)]`
error: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
--> src/direction.rs:13:22
|
13 | pub fn to_vector(&self) -> Vector2<i32> {
| ^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `-D clippy::wrong-self-convention` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]`
error: unused variable: `invalid_character_level`
--> src/level.rs:831:13
|
831 | let invalid_character_level = String::from(
| ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_invalid_character_level`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/level.rs:88:22
|
88 | data[(y * dimensions.x as usize + x) as usize] = match char {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(y * dimensions.x as usize + x)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`
error: single-character string constant used as pattern
--> src/level.rs:160:37
|
160 | let buffer = buffer.replace("\r", "") + "\n";
| ^^^^ help: try using a `char` instead: `'\r'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `-D clippy::single-char-pattern` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]`
error: stripping a prefix manually
--> src/level.rs:185:31
|
185 | comments += &(trimmed_line[1..].trim().to_string() + "\n");
| ^^^^^^^^^^^^^^^^^
|
note: the prefix was tested here
--> src/level.rs:184:13
|
184 | if trimmed_line.starts_with(";") {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
= note: `-D clippy::manual-strip` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::manual_strip)]`
help: try using the `strip_prefix` method
|
184 ~ if let Some(<stripped>) = trimmed_line.strip_prefix(";") {
185 ~ comments += &(<stripped>.trim().to_string() + "\n");
|
error: single-character string constant used as pattern
--> src/level.rs:184:41
|
184 | if trimmed_line.starts_with(";") {
| ^^^ help: try using a `char` instead: `';'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: binary comparison to literal `Option::None`
--> src/level.rs:197:31
|
197 | debug_assert!(metadata.get("comments") == None);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `metadata.get("comments").is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `-D clippy::partialeq-to-none` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::partialeq_to_none)]`
error: single-character string constant used as pattern
--> src/level.rs:214:41
|
214 | if trimmed_line.starts_with("'") {
| ^^^ help: try using a `char` instead: `'\''`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: single-character string constant used as pattern
--> src/level.rs:221:38
|
221 | if trimmed_line.contains(":") {
| ^^^ help: try using a `char` instead: `':'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: single-character string constant used as pattern
--> src/level.rs:222:60
|
222 | let (key, value) = trimmed_line.split_once(":").unwrap();
| ^^^ help: try using a `char` instead: `':'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: use of `char::is_digit` with literal radix of 10
--> src/level.rs:250:37
|
250 | if line.chars().any(|c| c.is_digit(10)) {
| ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
= note: `-D clippy::is-digit-ascii-radix` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::is_digit_ascii_radix)]`
error: single-character string constant used as pattern
--> src/level.rs:324:43
|
324 | debug_assert!(!value.contains("\n"));
| ^^^^ help: try using a `char` instead: `'\n'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: redundant closure
--> src/level.rs:646:18
|
646 | .map(|x| rotate_position(x))
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rotate_position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
error: redundant closure
--> src/level.rs:672:18
|
672 | .map(|x| flip_position(x))
| ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `flip_position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
error: use of `char::is_digit` with literal radix of 10
--> src/level.rs:765:12
|
765 | if char.is_digit(10) {
| ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_digit()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
error: this loop could be written as a `for` loop
--> src/level.rs:772:13
|
772 | while let Some(char) = iter.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for char in iter.by_ref()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
= note: `-D clippy::while-let-on-iterator` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::while_let_on_iterator)]`
error: single-character string constant used as pattern
--> src/level.rs:791:24
|
791 | if result.contains("(") {
| ^^^ help: try using a `char` instead: `'('`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> src/movement.rs:41:1
|
41 | impl Into<char> for Movement {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-D clippy::from-over-into` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::from_over_into)]`
help: replace the `Into` implementation with `From<movement::Movement>`
|
41 ~ impl From<Movement> for char {
42 ~ fn from(val: Movement) -> Self {
43 ~ let c = match val.direction() {
44 | Direction::Up => 'u',
...
48 | };
49 ~ if val.is_push() {
|
error: module has the same name as its containing module
--> src/solver/mod.rs:1:1
|
1 | pub mod solver;
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `-D clippy::module-inception` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::module_inception)]`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/solver/solver.rs:89:63
|
89 | .insert(self.heap.peek().unwrap().normalized_hash(&self));
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/solver/solver.rs:94:32
|
94 | if state.is_solved(&self) {
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/solver/solver.rs:98:47
|
98 | for successor in state.successors(&self) {
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/solver/solver.rs:99:67
|
99 | if !self.visited.insert(successor.normalized_hash(&self)) {
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: unneeded `return` statement
--> src/solver/state.rs:244:9
|
244 | return true;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
244 - return true;
244 + true
|
error: parameter is only used in recursion
--> src/solver/state.rs:197:10
|
197 | &self,
| ^^^^
|
note: parameter used here
--> src/solver/state.rs:235:20
|
235 | && self.is_freeze_deadlock(&neighbors[0], crate_positions, solver, visited))
| ^^^^
236 | || (crate_positions.contains(&neighbors[1])
237 | && self.is_freeze_deadlock(&neighbors[1], crate_positions, solver, visited))
| ^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
= note: `-D clippy::only-used-in-recursion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::only_used_in_recursion)]`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/solver/state.rs:288:39
|
288 | self.can_block_player(&position, solver)
| ^^^^^^^^^ help: change this to: `position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: very complex type used. Consider factoring parts into `type` definitions
--> src/systems/auto_move.rs:14:17
|
14 | mut crates: Query<(&GridPosition, &mut Sprite), (With<Crate>, Without<Player>)>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-D clippy::type-complexity` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::type_complexity)]`
error: very complex type used. Consider factoring parts into `type` definitions
--> src/systems/auto_move.rs:101:17
|
101 | mut crates: Query<(&GridPosition, &mut Sprite), (With<Crate>, Without<Player>)>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
error: very complex type used. Consider factoring parts into `type` definitions
--> src/systems/auto_move.rs:103:12
|
103 | marks: Query<Entity, Or<(With<CratePushableMark>, With<PlayerMovableMark>)>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
--> src/systems/auto_solve.rs:24:29
|
24 | let mut solver = solver.lock().unwrap();
| ^^^^ help: change this to: `get_mut`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mutex_lock
= note: `-D clippy::mut-mutex-lock` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::mut_mutex_lock)]`
error: iterating on a map's values
--> src/systems/auto_solve.rs:48:26
|
48 | let max_lowerbound = lowerbounds
| __________________________^
49 | | .iter()
50 | | .map(|(_, lowerbound)| *lowerbound)
| |___________________________________________^ help: try: `lowerbounds.values().map(|lowerbound| *lowerbound)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
= note: `-D clippy::iter-kv-map` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::iter_kv_map)]`
error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
--> src/systems/auto_solve.rs:105:29
|
105 | let mut solver = solver.lock().unwrap();
| ^^^^ help: change this to: `get_mut`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mutex_lock
error: this function has too many arguments (11/7)
--> src/systems/input.rs:23:1
|
23 | / pub fn handle_actions(
24 | | action_state: Res<ActionState<Action>>,
25 | |
26 | | state: Res<State<AppState>>,
... |
38 | | mut update_grid_position_events: EventWriter<UpdateGridPositionEvent>,
39 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/systems/input.rs:108:28
|
108 | .get_unchecked(&position)
| ^^^^^^^^^ help: change this to: `position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/systems/input.rs:140:28
|
140 | .get_unchecked(&position)
| ^^^^^^^^^ help: change this to: `position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: self-assignment of `level_id.0` to `level_id.0`
--> src/systems/input.rs:198:9
|
198 | level_id.0 = level_id.0;
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment
= note: `#[deny(clippy::self_assignment)]` on by default
error: this function has too many arguments (8/7)
--> src/systems/input.rs:285:1
|
285 | / pub fn mouse_input(
286 | | mouse_buttons: Res<ButtonInput<MouseButton>>,
287 | | mut board: Query<&mut Board>,
288 | | windows: Query<&Window>,
... |
295 | | mut auto_move_state: ResMut<AutoMoveState>,
296 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
error: this function has too many arguments (9/7)
--> src/systems/level.rs:49:1
|
49 | / pub fn spawn_board(
50 | | mut commands: Commands,
51 | | database: Res<Database>,
52 | | mut camera: Query<(&mut Transform, &mut MainCamera)>,
... |
58 | | mut spritesheet_layouts: ResMut<Assets<TextureAtlasLayout>>,
59 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
error: unneeded late initialization
--> src/systems/render.rs:58:5
|
58 | let animation;
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
= note: `-D clippy::needless-late-init` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_late_init)]`
help: declare `animation` here
|
59 | let animation = if player_movement.directions.is_empty() {
| +++++++++++++++
help: remove the assignments from the branches
|
60 ~ match player_orientation {
61 | Direction::Up => face_up,
...
64 | Direction::Left => face_left,
65 ~ }
66 | } else {
67 ~ match player_orientation {
68 | Direction::Up => move_up,
...
71 | Direction::Left => move_left,
72 ~ }
|
help: add a semicolon after the `if` expression
|
73 | };
| +
error: this function has too many arguments (9/7)
--> src/systems/render.rs:80:1
|
80 | / pub fn handle_player_movement(
81 | | mut player: Query<&mut GridPosition, With<Player>>,
82 | | mut crates: Query<&mut GridPosition, (With<Crate>, Without<Player>)>,
83 | | mut board: Query<&mut Board>,
... |
89 | | mut level_solved_events: EventWriter<LevelSolved>,
90 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
error: `if` chain can be rewritten with `match`
--> src/systems/render.rs:115:13
|
115 | / if new_occupied_targets_count > occupied_targets_count {
116 | | crate_enter_target_events.send_default();
117 | | } else if new_occupied_targets_count < occupied_targets_count {
118 | | crate_leave_target_events.send_default();
119 | | }
| |_____________^
|
= help: consider rewriting the `if` chain to use `cmp` and `match`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain
= note: `-D clippy::comparison-chain` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::comparison_chain)]`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/systems/render.rs:127:46
|
127 | if crate_grid_positions.contains(&player_grid_position) {
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `player_grid_position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/systems/render.rs:145:46
|
145 | if crate_grid_positions.contains(&player_grid_position) {
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `player_grid_position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: useless conversion to the same type: `bevy::prelude::Handle<bevy::prelude::Image>`
--> src/systems/ui.rs:173:17
|
173 | asset_server.load("textures/instant_move_on.png").into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `asset_server.load("textures/instant_move_on.png")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
error: useless conversion to the same type: `bevy::prelude::Handle<bevy::prelude::Image>`
--> src/systems/ui.rs:175:17
|
175 | asset_server.load("textures/instant_move_off.png").into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `asset_server.load("textures/instant_move_off.png")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
error: very complex type used. Consider factoring parts into `type` definitions
--> src/systems/ui.rs:187:28
|
187 | mut interaction_query: Query<
| ____________________________^
188 | | (&Interaction, &mut BackgroundColor),
189 | | (Changed<Interaction>, With<Button>),
190 | | >,
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
error: very complex type used. Consider factoring parts into `type` definitions
--> src/systems/ui.rs:203:14
|
203 | buttons: Query<(&Interaction, &Action), (Changed<Interaction>, With<Button>)>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
error: could not compile `soukoban-rs` (bin "soukoban-rs") due to 53 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `soukoban-rs` (bin "soukoban-rs" test) due to 54 previous errors
cargo cca 500.51s user 21.01s system 931% cpu 56.011 total
sokoban-rs on  main is 📦 v0.1.11 via 🦀 v1.76.0 took 56s
:( cargo cca | wl-copy
Checking soukoban-rs v0.1.11 (/tmp/sokoban-rs)
error: digits grouped inconsistently by underscores
--> src/solver/state.rs:74:51
|
74 | instance.movements.move_count() * 10000_0000
| ^^^^^^^^^^ help: consider: `100_000_000`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping
= note: `-D clippy::inconsistent-digit-grouping` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::inconsistent_digit_grouping)]`
error: digits grouped inconsistently by underscores
--> src/solver/state.rs:79:51
|
79 | instance.movements.push_count() * 10000_0000
| ^^^^^^^^^^ help: consider: `100_000_000`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping
error: constants have by default a `'static` lifetime
--> src/main.rs:37:26
|
37 | const CONFIG_FILE_PATH: &'static str = "config.toml";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `-D clippy::redundant-static-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_static_lifetimes)]`
error: constants have by default a `'static` lifetime
--> src/main.rs:50:30
|
50 | const KEYMAP_FILE_PATH: &'static str = "keymap.toml";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
error: unused variable: `invalid_character_level`
--> src/level.rs:831:13
|
831 | let invalid_character_level = String::from(
| ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_invalid_character_level`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
error: unneeded `return` statement
--> src/board.rs:49:9
|
49 | return true;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
49 - return true;
49 + true
|
error: using `clone` on type `Matrix<i32, Const<2>, Const<1>, ArrayStorage<i32, 2, 1>>` which implements the `Copy` trait
--> src/board.rs:104:45
|
104 | self.move_crate(crate_position, self.level.player_position.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.level.player_position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`
error: name `HUD` contains a capitalized acronym
--> src/components.rs:18:12
|
18 | pub struct HUD;
| ^^^ help: consider making the acronym lowercase, except the initial letter: `Hud`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
= note: `-D clippy::upper-case-acronyms` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::upper_case_acronyms)]`
error: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value
--> src/direction.rs:13:22
|
13 | pub fn to_vector(&self) -> Vector2<i32> {
| ^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `-D clippy::wrong-self-convention` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]`
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/level.rs:88:22
|
88 | data[(y * dimensions.x as usize + x) as usize] = match char {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(y * dimensions.x as usize + x)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`
error: single-character string constant used as pattern
--> src/level.rs:160:37
|
160 | let buffer = buffer.replace("\r", "") + "\n";
| ^^^^ help: try using a `char` instead: `'\r'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `-D clippy::single-char-pattern` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]`
error: stripping a prefix manually
--> src/level.rs:185:31
|
185 | comments += &(trimmed_line[1..].trim().to_string() + "\n");
| ^^^^^^^^^^^^^^^^^
|
note: the prefix was tested here
--> src/level.rs:184:13
|
184 | if trimmed_line.starts_with(";") {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
= note: `-D clippy::manual-strip` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::manual_strip)]`
help: try using the `strip_prefix` method
|
184 ~ if let Some(<stripped>) = trimmed_line.strip_prefix(";") {
185 ~ comments += &(<stripped>.trim().to_string() + "\n");
|
error: single-character string constant used as pattern
--> src/level.rs:184:41
|
184 | if trimmed_line.starts_with(";") {
| ^^^ help: try using a `char` instead: `';'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: binary comparison to literal `Option::None`
--> src/level.rs:197:31
|
197 | debug_assert!(metadata.get("comments") == None);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `metadata.get("comments").is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `-D clippy::partialeq-to-none` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::partialeq_to_none)]`
error: single-character string constant used as pattern
--> src/level.rs:214:41
|
214 | if trimmed_line.starts_with("'") {
| ^^^ help: try using a `char` instead: `'\''`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: single-character string constant used as pattern
--> src/level.rs:221:38
|
221 | if trimmed_line.contains(":") {
| ^^^ help: try using a `char` instead: `':'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: single-character string constant used as pattern
--> src/level.rs:222:60
|
222 | let (key, value) = trimmed_line.split_once(":").unwrap();
| ^^^ help: try using a `char` instead: `':'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: use of `char::is_digit` with literal radix of 10
--> src/level.rs:250:37
|
250 | if line.chars().any(|c| c.is_digit(10)) {
| ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
= note: `-D clippy::is-digit-ascii-radix` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::is_digit_ascii_radix)]`
error: single-character string constant used as pattern
--> src/level.rs:324:43
|
324 | debug_assert!(!value.contains("\n"));
| ^^^^ help: try using a `char` instead: `'\n'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: redundant closure
--> src/level.rs:646:18
|
646 | .map(|x| rotate_position(x))
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rotate_position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
error: redundant closure
--> src/level.rs:672:18
|
672 | .map(|x| flip_position(x))
| ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `flip_position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
error: use of `char::is_digit` with literal radix of 10
--> src/level.rs:765:12
|
765 | if char.is_digit(10) {
| ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_digit()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
error: this loop could be written as a `for` loop
--> src/level.rs:772:13
|
772 | while let Some(char) = iter.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for char in iter.by_ref()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
= note: `-D clippy::while-let-on-iterator` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::while_let_on_iterator)]`
error: single-character string constant used as pattern
--> src/level.rs:791:24
|
791 | if result.contains("(") {
| ^^^ help: try using a `char` instead: `'('`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> src/movement.rs:41:1
|
41 | impl Into<char> for Movement {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-D clippy::from-over-into` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::from_over_into)]`
help: replace the `Into` implementation with `From<movement::Movement>`
|
41 ~ impl From<Movement> for char {
42 ~ fn from(val: Movement) -> Self {
43 ~ let c = match val.direction() {
44 | Direction::Up => 'u',
...
48 | };
49 ~ if val.is_push() {
|
error: module has the same name as its containing module
--> src/solver/mod.rs:1:1
|
1 | pub mod solver;
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `-D clippy::module-inception` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::module_inception)]`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/solver/solver.rs:89:63
|
89 | .insert(self.heap.peek().unwrap().normalized_hash(&self));
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/solver/solver.rs:94:32
|
94 | if state.is_solved(&self) {
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/solver/solver.rs:98:47
|
98 | for successor in state.successors(&self) {
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/solver/solver.rs:99:67
|
99 | if !self.visited.insert(successor.normalized_hash(&self)) {
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: unneeded `return` statement
--> src/solver/state.rs:244:9
|
244 | return true;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
244 - return true;
244 + true
|
error: parameter is only used in recursion
--> src/solver/state.rs:197:10
|
197 | &self,
| ^^^^
|
note: parameter used here
--> src/solver/state.rs:235:20
|
235 | && self.is_freeze_deadlock(&neighbors[0], crate_positions, solver, visited))
| ^^^^
236 | || (crate_positions.contains(&neighbors[1])
237 | && self.is_freeze_deadlock(&neighbors[1], crate_positions, solver, visited))
| ^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
= note: `-D clippy::only-used-in-recursion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::only_used_in_recursion)]`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/solver/state.rs:288:39
|
288 | self.can_block_player(&position, solver)
| ^^^^^^^^^ help: change this to: `position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: very complex type used. Consider factoring parts into `type` definitions
--> src/systems/auto_move.rs:14:17
|
14 | mut crates: Query<(&GridPosition, &mut Sprite), (With<Crate>, Without<Player>)>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-D clippy::type-complexity` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::type_complexity)]`
error: very complex type used. Consider factoring parts into `type` definitions
--> src/systems/auto_move.rs:101:17
|
101 | mut crates: Query<(&GridPosition, &mut Sprite), (With<Crate>, Without<Player>)>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
error: very complex type used. Consider factoring parts into `type` definitions
--> src/systems/auto_move.rs:103:12
|
103 | marks: Query<Entity, Or<(With<CratePushableMark>, With<PlayerMovableMark>)>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
--> src/systems/auto_solve.rs:24:29
|
24 | let mut solver = solver.lock().unwrap();
| ^^^^ help: change this to: `get_mut`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mutex_lock
= note: `-D clippy::mut-mutex-lock` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::mut_mutex_lock)]`
error: iterating on a map's values
--> src/systems/auto_solve.rs:48:26
|
48 | let max_lowerbound = lowerbounds
| __________________________^
49 | | .iter()
50 | | .map(|(_, lowerbound)| *lowerbound)
| |___________________________________________^ help: try: `lowerbounds.values().map(|lowerbound| *lowerbound)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
= note: `-D clippy::iter-kv-map` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::iter_kv_map)]`
error: calling `&mut Mutex::lock` unnecessarily locks an exclusive (mutable) reference
--> src/systems/auto_solve.rs:105:29
|
105 | let mut solver = solver.lock().unwrap();
| ^^^^ help: change this to: `get_mut`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mutex_lock
error: this function has too many arguments (11/7)
--> src/systems/input.rs:23:1
|
23 | / pub fn handle_actions(
24 | | action_state: Res<ActionState<Action>>,
25 | |
26 | | state: Res<State<AppState>>,
... |
38 | | mut update_grid_position_events: EventWriter<UpdateGridPositionEvent>,
39 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/systems/input.rs:108:28
|
108 | .get_unchecked(&position)
| ^^^^^^^^^ help: change this to: `position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/systems/input.rs:140:28
|
140 | .get_unchecked(&position)
| ^^^^^^^^^ help: change this to: `position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: self-assignment of `level_id.0` to `level_id.0`
--> src/systems/input.rs:198:9
|
198 | level_id.0 = level_id.0;
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#self_assignment
= note: `#[deny(clippy::self_assignment)]` on by default
error: this function has too many arguments (8/7)
--> src/systems/input.rs:285:1
|
285 | / pub fn mouse_input(
286 | | mouse_buttons: Res<ButtonInput<MouseButton>>,
287 | | mut board: Query<&mut Board>,
288 | | windows: Query<&Window>,
... |
295 | | mut auto_move_state: ResMut<AutoMoveState>,
296 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
error: this function has too many arguments (9/7)
--> src/systems/level.rs:49:1
|
49 | / pub fn spawn_board(
50 | | mut commands: Commands,
51 | | database: Res<Database>,
52 | | mut camera: Query<(&mut Transform, &mut MainCamera)>,
... |
58 | | mut spritesheet_layouts: ResMut<Assets<TextureAtlasLayout>>,
59 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
error: unneeded late initialization
--> src/systems/render.rs:58:5
|
58 | let animation;
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
= note: `-D clippy::needless-late-init` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_late_init)]`
help: declare `animation` here
|
59 | let animation = if player_movement.directions.is_empty() {
| +++++++++++++++
help: remove the assignments from the branches
|
60 ~ match player_orientation {
61 | Direction::Up => face_up,
...
64 | Direction::Left => face_left,
65 ~ }
66 | } else {
67 ~ match player_orientation {
68 | Direction::Up => move_up,
...
71 | Direction::Left => move_left,
72 ~ }
|
help: add a semicolon after the `if` expression
|
73 | };
| +
error: this function has too many arguments (9/7)
--> src/systems/render.rs:80:1
|
80 | / pub fn handle_player_movement(
81 | | mut player: Query<&mut GridPosition, With<Player>>,
82 | | mut crates: Query<&mut GridPosition, (With<Crate>, Without<Player>)>,
83 | | mut board: Query<&mut Board>,
... |
89 | | mut level_solved_events: EventWriter<LevelSolved>,
90 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
error: `if` chain can be rewritten with `match`
--> src/systems/render.rs:115:13
|
115 | / if new_occupied_targets_count > occupied_targets_count {
116 | | crate_enter_target_events.send_default();
117 | | } else if new_occupied_targets_count < occupied_targets_count {
118 | | crate_leave_target_events.send_default();
119 | | }
| |_____________^
|
= help: consider rewriting the `if` chain to use `cmp` and `match`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain
= note: `-D clippy::comparison-chain` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::comparison_chain)]`
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/systems/render.rs:127:46
|
127 | if crate_grid_positions.contains(&player_grid_position) {
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `player_grid_position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/systems/render.rs:145:46
|
145 | if crate_grid_positions.contains(&player_grid_position) {
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `player_grid_position`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: useless conversion to the same type: `bevy::prelude::Handle<bevy::prelude::Image>`
--> src/systems/ui.rs:173:17
|
173 | asset_server.load("textures/instant_move_on.png").into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `asset_server.load("textures/instant_move_on.png")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
error: useless conversion to the same type: `bevy::prelude::Handle<bevy::prelude::Image>`
--> src/systems/ui.rs:175:17
|
175 | asset_server.load("textures/instant_move_off.png").into()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `asset_server.load("textures/instant_move_off.png")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
error: very complex type used. Consider factoring parts into `type` definitions
--> src/systems/ui.rs:187:28
|
187 | mut interaction_query: Query<
| ____________________________^
188 | | (&Interaction, &mut BackgroundColor),
189 | | (Changed<Interaction>, With<Button>),
190 | | >,
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
error: very complex type used. Consider factoring parts into `type` definitions
--> src/systems/ui.rs:203:14
|
203 | buttons: Query<(&Interaction, &Action), (Changed<Interaction>, With<Button>)>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
error: could not compile `soukoban-rs` (bin "soukoban-rs" test) due to 54 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `soukoban-rs` (bin "soukoban-rs") due to 53 previous errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment