Created
April 21, 2020 05:27
-
-
Save ZhenLian/50c73f146493ac2fe9746d196082679b to your computer and use it in GitHub Desktop.
Findings for PR https://github.com/grpc/grpc-java/pull/6805
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Override | |
public X509Certificate[] getAcceptedIssuers() { | |
X509Certificate[] certs; | |
try { | |
List<X509Certificate> trustCerts = new ArrayList<>(); | |
KeyStore ks = tlsOptions.getTrustedCerts(); | |
Enumeration<String> aliases = ks.aliases(); | |
while (aliases.hasMoreElements()) { | |
Certificate c = ks.getCertificate(aliases.nextElement()); | |
if (c instanceof X509Certificate) { | |
trustCerts.add((X509Certificate) c); | |
} | |
} | |
certs = new X509Certificate[trustCerts.size()]; | |
for (int i = 0; i < trustCerts.size(); i++) { | |
certs[i] = trustCerts.get(i); | |
} | |
} catch (Exception e) { | |
return new X509Certificate[0]; | |
} | |
return certs; | |
// return new X509Certificate[0]; | |
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basicServerSideIntegrationTest[JDK] | |
java.lang.AssertionError: Didn't expect error but find error. | |
at org.junit.Assert.fail(Assert.java:88) | |
at io.grpc.netty.AdvancedTlsTest.makeRpcCall(AdvancedTlsTest.java:377) | |
at io.grpc.netty.AdvancedTlsTest.basicServerSideIntegrationTest(AdvancedTlsTest.java:340) | |
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) | |
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) | |
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) | |
at java.lang.reflect.Method.invoke(Method.java:498) | |
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) | |
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) | |
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) | |
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) | |
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) | |
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) | |
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) | |
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) | |
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) | |
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) | |
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) | |
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) | |
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) | |
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) | |
at org.junit.runners.ParentRunner.run(ParentRunner.java:363) | |
....... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment