Skip to content

Instantly share code, notes, and snippets.

@abadger

abadger/gist:43e8ea04bbbcddbccecfc7e2abbaab63

Created May 11, 2023 18:44
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save abadger/43e8ea04bbbcddbccecfc7e2abbaab63 to your computer and use it in GitHub Desktop.
Save abadger/43e8ea04bbbcddbccecfc7e2abbaab63 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
gistfile1.txt
Some thoughts on the design of the framework:
We need to have separate returns for final results (SUCCESS, FAILURE, and SKIP) because there must be one and only one of those after run() finishes.
final result messages should be a list so that adding multiple messages to SUCCESS can be nicely formatted.
WARNING, and other things messages that can have multiple should be stored in a new list attribute on the Action class.
When evaluating logger.warning and logger.info, decide whether to set it as a SUCCESS messages or WARNING message. success messages will not be shown in convresion, only in analyze. warning messages will be shown in both.
add_result() should be renamed since we want results to be final results only. Maybe add_message()?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment