Skip to content

Instantly share code, notes, and snippets.

@abadger
Created June 14, 2016 19:21
Show Gist options
  • Save abadger/bbab020cf9d87652c8432a69088fca31 to your computer and use it in GitHub Desktop.
Save abadger/bbab020cf9d87652c8432a69088fca31 to your computer and use it in GitHub Desktop.
[08:35:55] <quinot> Hi! I was thinking again about your remark on module_common calling back to action in #11810
[08:36:16] <quinot> I think reorganizing modify_module into two steps might allow resolving this
[08:36:52] <quinot> essentially action would call a first method of module_common to perform initial steps and obtain the language name
[08:37:12] <quinot> Then it would look up the appropriate interperter (possibly interacting with the remote host for the multiple interpreters case)
[08:37:30] <quinot> and then it would call modify_module *providing the computed interpreter to it*
[08:38:09] <quinot> So the annoying inversion of abstraction would be avoided, but at the cost of a more intrusive reorganization
[08:39:51] <quinot> I'm willing to pursue that option, but obviously I'd like to avoid spending time on it if the impact of the reorganization would make it less acceptable than the breach of abstraction that exists in the current version of the PR
[08:40:13] <abadger1999> <nod> yeah, we should discuss that with the rest of the team (probably in #ansible-devel)
[08:41:26] <quinot> OK, I'll raise that point there then!
[08:41:31] <quinot> Thanks for your feedback!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment