Skip to content

Instantly share code, notes, and snippets.

@ac12644
Created January 14, 2022 13:54
Show Gist options
  • Save ac12644/136dfcd94065b0501e26fe03f4f3de7c to your computer and use it in GitHub Desktop.
Save ac12644/136dfcd94065b0501e26fe03f4f3de7c to your computer and use it in GitHub Desktop.
Contract Fix
contract EtherStore {
// initialize the mutex
bool reEntrancyMutex = false;
uint256 public withdrawalLimit = 1 ether;
mapping(address => uint256) public lastWithdrawTime;
mapping(address => uint256) public balances;
function depositFunds() external payable {
balances[msg.sender] += msg.value;
}
function withdrawFunds (uint256 _weiToWithdraw) public {
require(!reEntrancyMutex);
require(balances[msg.sender] >= _weiToWithdraw);
// limit the withdrawal
require(_weiToWithdraw <= withdrawalLimit);
// limit the time allowed to withdraw
require(now >= lastWithdrawTime[msg.sender] + 1 weeks);
balances[msg.sender] -= _weiToWithdraw;
lastWithdrawTime[msg.sender] = now;
// set the reEntrancy mutex before the external call
reEntrancyMutex = true;
msg.sender.transfer(_weiToWithdraw);
// release the mutex after the external call
reEntrancyMutex = false;
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment