Skip to content

Instantly share code, notes, and snippets.

@adamluzsi
Created August 16, 2019 11:59
Show Gist options
  • Save adamluzsi/f78482a81d01d7b364286663875e7d8e to your computer and use it in GitHub Desktop.
Save adamluzsi/f78482a81d01d7b364286663875e7d8e to your computer and use it in GitHub Desktop.
Draft for aiming an effective PR review process
  • Verify the high level business goals are met with the implementation from product point of view
  • Look for scalability issues
  • Outline and note down high level tasks / issues
  • Verify code longterm testability
  • Check code behavior runtime observability
  • Look for high level design principle violation
    • antipatterns against 12 factor app
    • lack view/entity/bussiness-logic layer isolation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment