Last active
May 3, 2016 07:50
-
-
Save adiroiban/0adaf7824b93a14293580d94c4ac4f23 to your computer and use it in GitHub Desktop.
Twisted initial review reply
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Many thanks for your contribution. | |
| Can you please define the scope of your patch or update the ticket's description? | |
| DETAILS ABOUT WHY THE SCOPE IS NOT OK. | |
| The patch needs at least one automated test to demonstrate the change and to prevent future regressions. | |
| The patch also needs a NEWS file fragment (release notes fragment) | |
| as described here http://twistedmatrix.com/trac/wiki/ReviewProcess#Newsfiles | |
| If this is useful for "production" usage, | |
| then the news fragment should describe how it can be useful... | |
| so that in the next release people are aware of this new thing :) | |
| It would be nice if the new thing is also documented so that people will know how to use this new nice thing. | |
| Please consider my comments and submit a new patch. | |
| Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment