Skip to content

Instantly share code, notes, and snippets.

@aditya-jha
Last active June 6, 2019 12:36
Show Gist options
  • Save aditya-jha/eb6f326429312f14a1e7d474f5527be5 to your computer and use it in GitHub Desktop.
Save aditya-jha/eb6f326429312f14a1e7d474f5527be5 to your computer and use it in GitHub Desktop.
Pull Request Template

Awesome! You have completed your task. We want your code to be deployed to production ASAP. To enable us for the same please provide following information.

Description

Please include a summary of the changes and which issues are fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Jira Links

Please add relevant jira links

Deployment Configuration

Please provide the information needed to make it easy to deploy such as environment variables, migrations etc.

Mention the reviewers

Please mention the reviewers using @username.

Checklist

  • My code follows the style guidelines of this project
  • My code builds clean without any errors or warnings
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information for smooth deployment
  • I have updated the status on jira
  • I have mentioned 2 reviewers for this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment