Kill long parameters with Method Chaining

1_query_object.rb

class SalaryQuery
  def new
    @results = Salary.all
  end

  def call(companies:, source:, order_by:)
    @results = @results.where(company: companies)
      unless companies.blank?

    @results = @results.where(source: 'user_submission')
      if source == true

    case order_by
    when 'number_of_submissions'
      @results = @results.order(submission_count: :desc)
    when 'company_name'
      @results = @results.order(company_name: :desc)
    end

    @results
  end
end

1_query_object_in_controller.rb

class SalariesController < ApplicationController
  def search
    @results =
      SalaryQuery.new
                 .call(companies: params[:companies],
                       source: params[:user_submission_only],
                       order_by: params[:order_by])
  end
end

2_query_object_with_method_chaining.rb

class SalaryQuery
  def new
    @results = Salary.all
  end

  # filtering by attributes
  def filter_by_companies(companies)
    @results = @results.where(company: companies)
      unless companies.blank?
    
    self
  end

  # filtering by boolean value
  def filter_by_user_submission_only?(user_submission_only)
    @results = @results.where(source: 'user_submission')
      if user_submission_only

    self
  end

  # conditional filtering by attribute
  def order_by_attribute(attribute)
    case attribute
    when 'number_of_submissions'
      @results = @results.order(submission_count: :desc)
    when 'company_name'
      @results = @results.order(company_name: :desc)
    end

    self
  end

  def call
    @results
  end
end

2_query_object_with_method_chaining_in_controller.rb

class SalariesController < ApplicationController
  def search
    @results =
      SalaryQuery.new
                 .filter_by_companies(params[:companies])
                 .filter_by_user_submission_only?(params[:user_submission_only])
                 .order_by_attribute(params[:order_by])
                 .call
  end
end

before.rb

class SalariesController < ApplicationController
  # For simplicity sake, I have limited it to 3 filtering logics
  def search
    @results = Salary.all

    @results = @results.where(company: params[:companies])
      unless params[:companies].blank?

    @results = @results.where(source: 'user_submission')
      if params[:user_submission_only] == true

    case params[:order_by]
    when 'number_of_submissions'
      @results = @results.order(submission_count: :desc)
    when 'company_name'
      @results = @results.order(company_name: :desc)
    end
  end
end