Skip to content

Instantly share code, notes, and snippets.

@adriengibrat

adriengibrat/tenisu-app-review

Created December 7, 2022 10:54
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save adriengibrat/9a89be8199beeb230506187f82d59d43 to your computer and use it in GitHub Desktop.
Save adriengibrat/9a89be8199beeb230506187f82d59d43 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
tenisu-app-review
https://github.com/CaoKha/tenisu-app
+ playwright (getByRole)
+ vite / vitest: template ?
+ vercel <3
+ minimal css global (:root / variables / fontfaces)
? tenis-card: onClick -> Link router, className ?, css-in-js vs css variables DX (autocomplete?)
? searchbar.spec: filterPlayer = pure -> test without duplication, use import, refactor to use store
? store: context <3, API low level, why not move app logic to context?
? detailPage: DRY components, Architecture refactor: embed API call or data retrieval (refresh error message is a limitation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment