-
-
Save agentzh/3c0bdfbc25099341bb22ccb57087c73a to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/NEWS b/NEWS | |
index c927c0f69..180a680b9 100644 | |
--- a/NEWS | |
+++ b/NEWS | |
@@ -2,6 +2,8 @@ | |
* What's new in version 4.2, 2019-11-18 | |
+- The "Build-id mismatch" error now becomes a warning. | |
+ | |
- The process(EXE).begin probe handlers are now always triggered for | |
already-running target processes. | |
diff --git a/man/cs/warning::buildid.7stap b/man/cs/warning::buildid.7stap | |
index a2a1e2cc0..43604680b 100644 | |
--- a/man/cs/warning::buildid.7stap | |
+++ b/man/cs/warning::buildid.7stap | |
@@ -1,7 +1,7 @@ | |
.\" t | |
-.TH ERROR::BUILDID 7stap | |
+.TH WARNING::BUILDID 7stap | |
.SH NAME | |
-error::buildid \- chyby ověření build-id | |
+warning::buildid \- chyby ověření build-id | |
.\" macros | |
.de SAMPLE | |
diff --git a/man/warning::buildid.7stap b/man/warning::buildid.7stap | |
index 861769823..3f8a338e8 100644 | |
--- a/man/warning::buildid.7stap | |
+++ b/man/warning::buildid.7stap | |
@@ -1,7 +1,7 @@ | |
.\" t | |
-.TH ERROR::BUILDID 7stap | |
+.TH WARNING::BUILDID 7stap | |
.SH NAME | |
-error::buildid \- build-id verification failures | |
+warning::buildid \- build-id verification failures | |
.\" macros | |
.de SAMPLE | |
@@ -50,7 +50,7 @@ man page. | |
During translation, systemtap saves a copy of the relevant files' | |
build-ids within the compiled modules. At run-time, the modules | |
compare the saved ones to the actual run-time build-ids in memory. | |
-The error message indicates that they did not match, so the module | |
+The warning message indicates that they did not match, so the module | |
will decline placing a probe that was computed based upon obsolete | |
data. This is important for safety, as placing them at an | |
inappropriate address could crash the programs. However, this is not | |
@@ -73,7 +73,7 @@ files may not exactly match the main binaries. | |
.PP | |
-To disable build-id verification errors, if one is confident that they | |
+To disable build-id verification warnings, if one is confident that they | |
are an artefact of build accidents rather than a real mismatch, one | |
might try the | |
.IR -DSTP_NO_BUILDID_CHECK | |
diff --git a/runtime/sym.c b/runtime/sym.c | |
index a22802e58..237644082 100644 | |
--- a/runtime/sym.c | |
+++ b/runtime/sym.c | |
@@ -709,8 +709,9 @@ static int _stp_build_id_check (struct _stp_module *m, | |
// have two strings, will travel | |
if (strcmp (hexstring_practice, hexstring_theory)) { | |
- _stp_error ("Build-id mismatch [man error::buildid]: \"%s\" address %#lx, expected %s actual %s\n", | |
- m->path, notes_addr, hexstring_theory, hexstring_practice); | |
+ _stp_warn ("Build-id mismatch [man warning::buildid]: \"%s\" address " | |
+ "%#lx, expected %s actual %s\n", | |
+ m->path, notes_addr, hexstring_theory, hexstring_practice); | |
return 1; | |
} | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment