Skip to content

Instantly share code, notes, and snippets.

View ahmadsherif's full-sized avatar

Ahmad Sherif ahmadsherif

107 followers · 16 following
View GitHub Profile
@ahmadsherif
ahmadsherif / grpc-subchannel-proof-of-fix.diff
Created February 22, 2018 23:42
diff --git a/src/core/ext/filters/client_channel/subchannel.cc b/src/core/ext/filters/client_channel/subchannel.cc
index 83aaa09445..3ac9b971cb 100644
--- a/src/core/ext/filters/client_channel/subchannel.cc
+++ b/src/core/ext/filters/client_channel/subchannel.cc
@@ -334,8 +338,13 @@ grpc_subchannel* grpc_subchannel_create(grpc_connector* connector,
grpc_subchannel_key* key = grpc_subchannel_key_create(args);
grpc_subchannel* c = grpc_subchannel_index_find(key);
if (c) {
- grpc_subchannel_key_destroy(key);
- return c;
@ahmadsherif
ahmadsherif / subchannel-ref-increment
Created February 22, 2018 23:37
#0 0x00007f705e04a61f in gpr_atm_rel_cas (p=0x7f7020006348, o=65537, n=131073)
at include/grpc/impl/codegen/atm_gcc_atomic.h:75
#1 0x00007f705e04a9d7 in grpc_subchannel_ref_from_weak_ref (c=0x7f7020006340,
file=0x7f705e1f5ae8 "src/core/ext/filters/client_channel/subchannel_index.cc", line=151,
reason=0x7f705e1f5b20 "index_find") at src/core/ext/filters/client_channel/subchannel.cc:241
#2 0x00007f705e04cda5 in grpc_subchannel_index_find (key=0x7f7010005180)
at src/core/ext/filters/client_channel/subchannel_index.cc:149
#3 0x00007f705e04af8c in grpc_subchannel_create (connector=0x7f70100050b0, args=0x7f702d7f9aa0)
at src/core/ext/filters/client_channel/subchannel.cc:339
#4 0x00007f705e04f4c9 in client_channel_factory_create_subchannel (
@ahmadsherif
ahmadsherif / bad-subchannel-ref-unref
Created February 22, 2018 23:25
D0222 19:45:44.399495220 450 subchannel_index.cc:184] SUBCHANNEL: 0x7fd5f80030f0 WEAK_REF 0x10000 -> 0x10001 [index_register]
D0222 19:45:56.602202343 31688 subchannel.cc:522] SUBCHANNEL: 0x7fd5f80030f0 WEAK_REF 0x40001 -> 0x40002 [external_state_watcher]
D0222 19:45:56.602212215 31688 subchannel.cc:477] SUBCHANNEL: 0x7fd5f80030f0 WEAK_REF 0x40002 -> 0x40003 [connecting]
D0222 19:45:56.602356197 31688 subchannel.cc:429] SUBCHANNEL: 0x7fd5f80030f0 WEAK_UNREF 0x40003 -> 0x40002 [external_state_watcher]
D0222 19:45:56.602502582 31688 subchannel.cc:666] SUBCHANNEL: 0x7fd5f80030f0 WEAK_REF 0x40002 -> 0x40003 [connected]
D0222 19:45:56.602558949 31688 subchannel.cc:686] SUBCHANNEL: 0x7fd5f80030f0 WEAK_UNREF 0x40003 -> 0x40002 [connecting]
D0222 19:45:56.602564259 31688 subchannel.cc:689] SUBCHANNEL: 0x7fd5f80030f0 WEAK_UNREF 0x40002 -> 0x40001 [connected]
D0222 19:45:56.602613295 31688 subchannel.cc:522] SUBCHA
@ahmadsherif
ahmadsherif / good-subchannel-ref-unref
Created February 22, 2018 23:23
D0222 19:36:40.021687468 19656 subchannel_index.cc:184] SUBCHANNEL: 0x7face4007fa0 WEAK_REF 0x10000 -> 0x10001 [index_register]
D0222 19:36:41.912779931 19052 subchannel.cc:522] SUBCHANNEL: 0x7face4007fa0 WEAK_REF 0x40001 -> 0x40002 [external_state_watcher]
D0222 19:36:41.912786689 19052 subchannel.cc:477] SUBCHANNEL: 0x7face4007fa0 WEAK_REF 0x40002 -> 0x40003 [connecting]
D0222 19:36:41.912947124 19052 subchannel.cc:429] SUBCHANNEL: 0x7face4007fa0 WEAK_UNREF 0x40003 -> 0x40002 [external_state_watcher]
D0222 19:36:41.913132949 19052 subchannel.cc:666] SUBCHANNEL: 0x7face4007fa0 WEAK_REF 0x40002 -> 0x40003 [connected]
D0222 19:36:41.913153398 19052 subchannel.cc:650] SUBCHANNEL: 0x7face4007fa0 WEAK_REF 0x40003 -> 0x40004 [state_watcher]
D0222 19:36:41.913156646 19052 subchannel.cc:651] SUBCHANNEL: 0x7face4007fa0 WEAK_UNREF 0x40004 -> 0x40003 [connecting]
D0222 19:36:41.913171705 19052 subchannel.cc:689] SU
@ahmadsherif
ahmadsherif / bmlog-20160926-194941.2620.tsv
Created September 26, 2016 17:51
We can make this file beautiful and searchable if this error is corrected: No tabs found in this TSV file in line 0.
2016-09-26 19:49:41 +0200
target 0: ruby-without-fix (ruby 2.4.0dev (2016-09-25 trunk 56239) [x86_64-linux]) at "/opt/ruby-custom/bin/ruby -I./lib -I. -I.ext/common --disable-gem"
target 1: built-ruby (ruby 2.4.0dev (2016-09-25 trunk 56240) [x86_64-linux]) at "./miniruby -I./lib -I. -I.ext/common --disable-gem"
measure target: real
-----------------------------------------------------------
loop_whileloop2
i = 0
while i< 6_000_000 # benchmark loop 2
@ahmadsherif
ahmadsherif / argf_read_nonblock.patch
Created January 29, 2016 15:51
ARGF#read_nonblock
diff --git a/kernel/common/argf.rb b/kernel/common/argf.rb
index c9f80dd..c710116 100644
--- a/kernel/common/argf.rb
+++ b/kernel/common/argf.rb
@@ -402,6 +402,33 @@ module Rubinius
alias_method :to_a, :readlines
+ def read_nonblock(maxlen, output=nil, opts={})
+ if output.is_a?(Hash)
@ahmadsherif
ahmadsherif / gist:1b1266cf4afb88dfb33f
Created January 19, 2016 16:45
rbx-ffi-io-gdb
Starting program: rubinius/bin/rbx /tmp/t.rb
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[New Thread 0x7ffff7fce700 (LWP 12826)]
[New Thread 0x7ffff0ece700 (LWP 12827)]
[New Thread 0x7ffff0acd700 (LWP 12828)]
[New Thread 0x7fffe3fff700 (LWP 12829)]
[New Thread 0x7ffff02cc700 (LWP 12830)]
[New Thread 0x7fffe35c7700 (LWP 12831)]
^C
@ahmadsherif
ahmadsherif / get_enumerator_method.rb
Last active August 29, 2015 13:56
# In response to this question http://stackoverflow.com/questions/21899007/get-enumerator-method
require 'dl'
enum = [1,2,3].reject
enum_ptr = DL::CPtr.to_ptr(enum.object_id << 1)
rdata_struct = enum_ptr[0, DL::SIZEOF_LONG * 5].unpack('Q5')