Skip to content

Instantly share code, notes, and snippets.

@alansouzati
Created July 16, 2015 18:53
Show Gist options
  • Save alansouzati/d34b3f642ade8a15c203 to your computer and use it in GitHub Desktop.
Save alansouzati/d34b3f642ade8a15c203 to your computer and use it in GitHub Desktop.
Proposed changes for Grommet Logo and Accessibility support
@samogami
Copy link

Issue 1 Unique ids:
There needs to be a way to have unique ids for the title and desc elements as the same icon component might have one than one instances on page. I defer to others on the best way to do this.

Example: http://grommet.io/docs/ the Grommet logo is used on the top left and in the center of the page.

Issue 2 be able to change value of title in icon components:
The value for the title for Grommet Logo component might need to be changed depending on the context of where it is used.

As an example of needing to change the value of the title element, look at http://grommet.io/docs/

The Grommet logo in the upper left should have the title value of "Grommet" as it is a common pattern to have the logo in the upper left that is a link that brings you back to the main page of the site.

The Grommet logo in the center of the page is more of a decorative image and text with the word Grommet is right after the logo. In this context the Grommet logo does not need to be read and the value for the title should be "".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment