Skip to content

Instantly share code, notes, and snippets.

@alex-stone
Last active May 14, 2016 00:10
Show Gist options
  • Save alex-stone/4eee40f3814f37f87741d98cf7b088e2 to your computer and use it in GitHub Desktop.
Save alex-stone/4eee40f3814f37f87741d98cf7b088e2 to your computer and use it in GitHub Desktop.
Beautifying Admin Checklist

Todo:

  • User & Account Singleton services
  • Test refactor: most api requests to be separate browser commands
  • Browser tests: get rid of all unnecessary done callbacks
  • Move fetches up to route, pass down promise and not resolve until needed
  • Separate sections from pages
  • Groups service for storing off macros / views specific groups
  • Unify rule list pages
  • Clean up fixtures. Most of our fixtures for a given resource are the same except for one thing, maybe we can cut down on some of these fixtures and just overwrite the one property we're focusing on?
  • turn on eslint sort-imports.
  • Make z/dropdown compabitle with completely frozen objects. (https://github.com/zendesk/zendesk_admin/pull/580)
  • Use http://chaijs.com/plugins/chai-dom/ expect(...).to.have.class('yo dawg')
  • Use classList instead of className when testing for class inclusion.

Done

@kgarfinkel
Copy link

can we change Add custom eslint for import order. to turn on eslint sort-imports?

@alex-stone
Copy link
Author

Can you not modify this?

@kgarfinkel
Copy link

nose :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment