Skip to content

Instantly share code, notes, and snippets.

@alexanderjrobinson

alexanderjrobinson/pr-checklist.md

Last active February 8, 2016 22:11
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save alexanderjrobinson/daa4b9e828a88bf3ae30 to your computer and use it in GitHub Desktop.
Save alexanderjrobinson/daa4b9e828a88bf3ae30 to your computer and use it in GitHub Desktop.
Download ZIP
PR Checklist
Raw
pr-checklist.md

PR Submission Checklist

  • Code compiles without errors or warnings
  • All automated tests pass
  • Code formatted according to team style guide
  • No warnings from static analysis
  • Debug print/log statements have been removed
  • Unsued and commented out code has been removed
  • Performance analysis reports no leaks or general performance issues

PR Review Checklist

  • Style (coding style, conventions)
  • Design (principles, patterns)
  • Structure (layered architecture)
  • Testing
  • Technology => dependencies
  • Performance
  • Documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment