alexkroeger

async function getContractAbiFromEtherscan(contractAddress: string): Promise<string> {
    const url = `https://api.etherscan.io/api?module=contract&action=getabi&address=${contractAddress}`;
    const response = await axios.get(url);

    return response.data.result;
}

alexkroeger

diff --git a/old_comptrollerstorage.sol b/new_comptrollerstorage.sol
index fdf1eed..b74db65 100644
--- a/old_comptrollerstorage.sol
+++ b/new_comptrollerstorage.sol
@@ -151,3 +151,11 @@ contract ComptrollerV6Storage is ComptrollerV5Storage {
     /// @notice The rate at which comp is distributed to the corresponding supply market (per block)
     mapping(address => uint) public compSupplySpeeds;
 }
+
+contract ComptrollerV7Storage is ComptrollerV6Storage {

alexkroeger

diff --git a/old_comptroller.sol b/new_comptroller.sol
index 13ddf7b..4399c3f 100644
--- a/old_comptroller.sol
+++ b/new_comptroller.sol
@@ -12,7 +12,7 @@ import "./Governance/Comp.sol";
  * @title Compound's Comptroller Contract
  * @author Compound
  */
-contract Comptroller is ComptrollerV6Storage, ComptrollerInterface, ComptrollerErrorReporter, ExponentialNoError {
+contract Comptroller is ComptrollerV7Storage, ComptrollerInterface, ComptrollerErrorReporter, ExponentialNoError {

alexkroeger

diff --git a/old_comptroller.sol b/new_comptroller.sol
index 9ba55ab..13ddf7b 100644
--- a/old_comptroller.sol
+++ b/new_comptroller.sol
@@ -1077,39 +1077,6 @@ contract Comptroller is ComptrollerV6Storage, ComptrollerInterface, ComptrollerE
     function _become(Unitroller unitroller) public {
         require(msg.sender == unitroller.admin(), "only unitroller admin can change brains");
         require(unitroller._acceptImplementation() == 0, "change not authorized");
-
-        // TODO: Remove this post upgrade

alexkroeger

diff --git a/old_comptroller.sol b/new_comptroller.sol
index 9ba55ab..e079d10 100644
--- a/old_comptroller.sol
+++ b/new_comptroller.sol
@@ -1077,39 +1077,6 @@ contract Comptroller is ComptrollerV6Storage, ComptrollerInterface, ComptrollerE
     function _become(Unitroller unitroller) public {
         require(msg.sender == unitroller.admin(), "only unitroller admin can change brains");
         require(unitroller._acceptImplementation() == 0, "change not authorized");
-
-        // TODO: Remove this post upgrade

alexkroeger

diff --git a/compound_governorbravodelegate.sol b/uniswap_governorbravodelegate.sol
index 7c574ec..2ac6dfe 100644
--- a/compound_governorbravodelegate.sol
+++ b/uniswap_governorbravodelegate.sol
@@ -6,13 +6,13 @@ import "./GovernorBravoInterfaces.sol";
 contract GovernorBravoDelegate is GovernorBravoDelegateStorageV1, GovernorBravoEvents {
 
     /// @notice The name of this contract
-    string public constant name = "Compound Governor Bravo";
+    string public constant name = "Uniswap Governor Bravo";

alexkroeger

diff --git a/contracts/zero-ex/contracts/src/errors/LibNativeOrdersRichErrors.sol b/contracts/zero-ex/contracts/src/errors/LibNativeOrdersRichErrors.sol
index e339caac4..a12ab1428 100644
--- a/contracts/zero-ex/contracts/src/errors/LibNativeOrdersRichErrors.sol
+++ b/contracts/zero-ex/contracts/src/errors/LibNativeOrdersRichErrors.sol
@@ -88,6 +88,21 @@ library LibNativeOrdersRichErrors {
         );
     }
 
+    function InvalidSignerError(
+        address maker,

alexkroeger

Keybase proof

I hereby claim:

• I am alexkroeger on github.
• I am kroeger0x (https://keybase.io/kroeger0x) on keybase.
• I have a public key ASDuAtSyjbN5qMJlEwJwfdaMohvM-E5mS-Prt2OmSihpdAo

To claim this, I am signing this object:

alexkroeger

WITH
    wrapper_tx AS (
        SELECT DISTINCT
            t.transaction_hash
        FROM `bigquery-public-data.crypto_ethereum.traces` t
        LEFT JOIN `bigquery-public-data.crypto_ethereum.transactions` tx ON tx.hash = t.transaction_hash
        WHERE
            -- 0x V2 contracts
            LOWER(t.to_address) IN ('0x080bf510fcbf18b91105470639e9561022937712','0x4f833a24e1f95d70f028921e27040ca56e09ab0b')
            -- dYdX 0x exchange wrappers