Skip to content

Instantly share code, notes, and snippets.

@alexmcpherson

alexmcpherson/pr-template.md

Created October 28, 2014 21:27
Show Gist options
  • Save alexmcpherson/ce556b8a1ecc015bbff9 to your computer and use it in GitHub Desktop.
Save alexmcpherson/ce556b8a1ecc015bbff9 to your computer and use it in GitHub Desktop.
Download ZIP
sprintly-specific content
Raw
pr-template.md

Definition of Done:

  • Is there appropriate test coverage? (e.g. ChefSpec, Mocha/Chai, Python, etc.)
  • Does this PR require a Selenium test? (e.g. Browser-specific bugs or complicated UI bugs)
  • Does this PR require a regression test? All fixes require a regression test.
  • Does this PR require a blog post? If so, ensure marketing has signed off on content.
  • Does the knowledge base need to be updated?
  • Does this add new dependencies? If so, does Chef, M4, or PIP requirements need to be updated?
  • Will this feature require a new piece of infrastructure be implemented?
  • Are any new services fully automated in Chef?
  • Are there ChefSpec tests for the new Chef recipes/cookbooks?
  • Does this PR require new Mixpanel or GA events?
  • Is there appropriate logging included?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment