galaxy_ng diff summary

gistfile1.txt

Package galaxy_ng/app/migrations changed:
  New module 0004_rbac.py
Package galaxy_ng/app/api/ui/serializers changed:
  Removed module namespace.py
  Module __init__.py changed:
    Removed import of NamespaceSerializer, NamespaceSummarySerializer, NamespaceUpdateSerializer from removed namespace
  Module synclist.py changed:
    Removed import of auth_models from removed galaxy_ng.app.models
    New imported GroupPermissionField from new galaxy_ng.app.access_control.fields
    Class SyncListSerializer changed:
      Removed method _sanitize_groups
      Removed method to_internal_value
      Method create changed implementation:
        Code semantics changed
      Method update changed implementation:
        Code semantics changed
  Module user.py changed:
    Removed import of permissions from removed galaxy_ng.app.api
    New imported ValidationError from new rest_framework.exceptions
    Class CurrentUserSerializer changed:
      Method get_is_partner_engineer changed implementation:
        Code semantics changed
        No longer uses imported permissions
      New method get_model_permissions
    Class UserSerializer changed:
      Method to_internal_value changed implementation:
        Code semantics changed
        No longer uses imported serializers
        Newly uses imported ValidationError, auth_models
Package galaxy_ng/tests/unit/api changed:
  Module base.py changed:
    Removed import of auth from removed galaxy_ng.app.auth
    New imported access_policy from new galaxy_ng.app.access_control
    New imported assign_perm from new guardian.shortcuts
    Class BaseTestCase changed:
      Method _create_namespace changed implementation:
        Code semantics changed
      Method setUp changed implementation:
        Code semantics changed
        No longer uses imported auth
        Newly uses imported access_policy
      New method _create_partner_engineer_group
  Module test_api_ui_my_synclists.py changed:
    Removed import of permissions from removed galaxy_ng.app.api
    Class TestUiMySyncListViewSet changed:
      Method _create_synclist changed implementation:
         Removed arg users
        Code semantics changed
      Method setUp changed implementation:
        Code semantics changed
        No longer uses imported permissions
      Method test_my_synclist_create changed implementation:
        Code semantics changed
      Method test_my_synclist_delete changed implementation:
        Code semantics changed
      Method test_my_synclist_list changed implementation:
        Code semantics changed
      Method test_my_synclist_update changed implementation:
        Code semantics changed
  Module test_api_ui_synclists.py changed:
    Removed import of permissions from removed galaxy_ng.app.api
    Class TestUiSynclistViewSet changed:
      Method _create_synclist changed implementation:
         Removed arg users
        Code semantics changed
      Method setUp changed implementation:
        Code semantics changed
        No longer uses imported permissions
      Method test_synclist_create_as_pe_group changed implementation:
        Code semantics changed
      Method test_synclist_create_as_user changed implementation:
        Code semantics changed
      Method test_synclist_update_as_non_pe_group_user changed implementation:
        Code semantics changed
      Method test_synclist_update_as_pe_group_user changed implementation:
        Code semantics changed
  Module test_api_ui_user_viewsets.py changed:
    Removed import of permissions from removed galaxy_ng.app.api
    Class TestUiNamespaceViewSet changed:
      Method setUp changed implementation:
        Code semantics changed
        No longer uses imported permissions
      Method test_user_get changed implementation:
        Code semantics changed
  Module test_api_v3_namespace_viewsets.py changed:
    Removed import of permissions from removed galaxy_ng.app.api
    Class TestV3NamespaceViewSet changed:
      Method setUp changed implementation:
        Code semantics changed
        No longer uses imported permissions
      Method test_delete_namespace_no_error_if_no_repo_exist changed implementation:
        Code semantics changed
      Method test_namespace_api_creates_deletes_inbound_repo changed implementation:
        Code semantics changed
Package galaxy_ng/app/api changed:
  Removed module permissions.py
Package galaxy_ng/app/api/v3/viewsets changed:
  Module collection.py changed:
    Removed import of GALAXY_PERMISSION_CLASSES from galaxy_ng.app.api.base
    Removed import of permissions from removed galaxy_ng.app.api
    New imported access_policy from new galaxy_ng.app.access_control
    Class CollectionUploadViewSet changed:
      Method _dispatch_import_collection_task changed implementation:
         Removed arg temp_file_pk
         Added arg artifact_pk
        Code semantics changed
      Method create changed implementation:
        Code semantics changed
        No longer uses imported CollectionUploadSerializer
      New method _get_data
  Module namespace.py changed:
    Removed import of permissions from galaxy_ng.app.api
    New imported NamespaceAccessPolicy from new galaxy_ng.app.access_control.access_policy
    Class NamespaceViewSet changed:
      Removed method get_permissions
      New method get_serializer_class
  Module task.py changed:
    Removed import of GALAXY_PERMISSION_CLASSES from galaxy_ng.app.api.base
    New imported access_policy from new galaxy_ng.app.access_control
Package galaxy_ng/app/auth changed:
  Module auth.py changed:
    Removed import of settings from removed django.conf
    Removed import of BasePermission from removed rest_framework.permissions
Package galaxy_ng/app/api/v3/serializers changed:
  Module namespace.py changed:
    Removed import of auth_models from removed galaxy_ng.app.models
    Removed import of GroupSummarySerializer from removed galaxy_ng.app.api.v3.serializers.group
    New imported GroupPermissionField from new galaxy_ng.app.access_control.fields
    Class NamespaceSerializer changed:
      Removed method to_internal_value
      Method create changed implementation:
        Code semantics changed
        No longer uses imported auth_models
      Method update changed implementation:
        Code semantics changed
        No longer uses imported auth_models
Package galaxy_ng/app/models changed:
  Module collectionimport.py changed:
    New imported LifecycleModel from new django_lifecycle
    New imported AutoDeleteObjPermsMixin from new pulpcore.plugin.models
  Module namespace.py changed:
    New imported LifecycleModel from new django_lifecycle
    New imported AutoDeleteObjPermsMixin from new pulpcore.plugin.models
    New imported mixins from new galaxy_ng.app.access_control
  Module synclist.py changed:
    New imported AutoDeleteObjPermsMixin from new pulpcore.plugin.models
    New imported LifecycleModel from new django_lifecycle
    New imported GroupModelPermissionsMixin from new galaxy_ng.app.access_control.mixins
Package galaxy_ng/app/api/ui/views changed:
  Module auth.py changed:
    Removed import of RestrictOnCloudDeployments from removed galaxy_ng.app.api.permissions
    New imported access_policy from new galaxy_ng.app.access_control
Package galaxy_ng/tests/unit/app changed:
  Module test_tasks.py changed:
    Removed import of settings from removed django.conf
    Removed import of override_settings from django.test
    Removed import of PulpTemporaryFile from pulpcore.plugin.models
    Removed import of AnsibleDistribution from pulp_ansible.app.models
    Class TestTaskPublish changed:
      Removed attribute pulp_temp_file
      Method setUp changed implementation:
        Code semantics changed
        No longer uses imported PulpTemporaryFile
      Method test_import_and_auto_approve changed implementation:
         Removed arg mocked_enqueue
         Removed arg mocked_import
         Removed arg mocked_get_created
         Added arg mocked_import_collection
        Code semantics changed
        No longer uses imported AnsibleDistribution, AnsibleRepository
      Method test_import_and_move_to_staging changed implementation:
         Removed arg mocked_get_created
        Code semantics changed
        No longer uses imported AnsibleDistribution
Package galaxy_ng/app/api/v3/views changed:
  Module auth.py changed:
    Removed import of IsAuthenticated from removed rest_framework.permissions
    Removed import of RestrictOnCloudDeployments from removed galaxy_ng.app.api.permissions
    New imported access_policy from new galaxy_ng.app.access_control
Package galaxy_ng/app/api/ui/viewsets changed:
  Module collection.py changed:
    Removed import of permissions from galaxy_ng.app.api
    New imported access_policy from new galaxy_ng.app.access_control
    Class CollectionImportViewSet changed:
      New method get_permissions
  Module my_namespace.py changed:
    Removed import of permissions from removed galaxy_ng.app.api
    New imported get_objects_for_user from new guardian.shortcuts
    Class MyNamespaceViewSet changed:
      Method get_queryset changed implementation:
        Code semantics changed
        No longer uses imported permissions
        Newly uses imported get_objects_for_user
  Module my_synclist.py changed:
    Removed import of package logging
    Removed import of api_base, permissions from removed galaxy_ng.app.api
    Removed import of serializers from removed galaxy_ng.app.api.ui
    New imported get_objects_for_user from new guardian.shortcuts
    New imported access_policy from new galaxy_ng.app.access_control
    New imported SyncListViewSet from new synclist
    Class MySyncListViewSet changed:
      Removed method get_permissions
      Method get_queryset changed implementation:
        Code semantics changed
        No longer uses imported permissions
        Newly uses imported get_objects_for_user
  Module namespace.py changed:
    Removed import of serializers from removed galaxy_ng.app.api.ui
    Class NamespaceViewSet changed:
      Removed method get_serializer_class
  Module synclist.py changed:
    Removed import of permissions from galaxy_ng.app.api
    New imported access_policy from new galaxy_ng.app.access_control
    Class SyncListViewSet changed:
      Removed method get_permissions
  Module tags.py changed:
    New imported access_policy from new galaxy_ng.app.access_control
  Module user.py changed:
    Removed import of drf_permissions from rest_framework
    Removed import of permissions from galaxy_ng.app.api
    New imported access_policy from new galaxy_ng.app.access_control
    Class CurrentUserViewSet changed:
      Removed method get_permissions
    Class UserViewSet changed:
      Removed method get_permissions
Package galaxy_ng/app/tasks changed:
  Module publishing.py changed:
    Removed import of ContentType from removed django.contrib.contenttypes.models
    Removed import of Task from pulpcore.plugin.models
    Removed import of AnsibleDistribution, CollectionVersion from pulp_ansible.app.models
    New imported ContentArtifact from pulpcore.plugin.models
    Removed function get_created_collection_versions
    Function import_and_auto_approve changed implementation:
       Removed arg temp_file_pk
       Added arg artifact_pk
      Code semantics changed
      No longer uses imported AnsibleDistribution, AnsibleRepository, add_content_to_repository, enqueue_with_reservation, remove_content_from_repository
      Newly uses imported ContentArtifact
    Function import_and_move_to_staging changed implementation:
       Removed arg temp_file_pk
       Added arg artifact_pk
      Code semantics changed
      No longer uses imported AnsibleDistribution
      Newly uses imported ContentArtifact
New packages galaxy_ng/app/access_control/statements, galaxy_ng/app/access_control
Removed modules galaxy_ng/app/api/permissions.py, galaxy_ng/app/api/ui/serializers/namespace.py
Module galaxy_ng/app/api/ui/serializers/__init__.py changed:
  Removed import of NamespaceSerializer, NamespaceSummarySerializer, NamespaceUpdateSerializer from removed namespace
Module galaxy_ng/app/api/ui/serializers/synclist.py changed:
  Removed import of auth_models from removed galaxy_ng.app.models
  New imported GroupPermissionField from new galaxy_ng.app.access_control.fields
  Class SyncListSerializer changed:
    Removed method _sanitize_groups
    Removed method to_internal_value
    Method create changed implementation:
      Code semantics changed
    Method update changed implementation:
      Code semantics changed
Module galaxy_ng/app/api/ui/serializers/user.py changed:
  Removed import of permissions from removed galaxy_ng.app.api
  New imported ValidationError from new rest_framework.exceptions
  Class CurrentUserSerializer changed:
    Method get_is_partner_engineer changed implementation:
      Code semantics changed
      No longer uses imported permissions
    New method get_model_permissions
  Class UserSerializer changed:
    Method to_internal_value changed implementation:
      Code semantics changed
      No longer uses imported serializers
      Newly uses imported ValidationError, auth_models
Module galaxy_ng/app/api/ui/views/auth.py changed:
  Removed import of RestrictOnCloudDeployments from removed galaxy_ng.app.api.permissions
  New imported access_policy from new galaxy_ng.app.access_control
Module galaxy_ng/app/api/ui/viewsets/collection.py changed:
  Removed import of permissions from galaxy_ng.app.api
  New imported access_policy from new galaxy_ng.app.access_control
  Class CollectionImportViewSet changed:
    New method get_permissions
Module galaxy_ng/app/api/ui/viewsets/my_namespace.py changed:
  Removed import of permissions from removed galaxy_ng.app.api
  New imported get_objects_for_user from new guardian.shortcuts
  Class MyNamespaceViewSet changed:
    Method get_queryset changed implementation:
      Code semantics changed
      No longer uses imported permissions
      Newly uses imported get_objects_for_user
Module galaxy_ng/app/api/ui/viewsets/my_synclist.py changed:
  Removed import of package logging
  Removed import of api_base, permissions from removed galaxy_ng.app.api
  Removed import of serializers from removed galaxy_ng.app.api.ui
  New imported get_objects_for_user from new guardian.shortcuts
  New imported access_policy from new galaxy_ng.app.access_control
  New imported SyncListViewSet from new synclist
  Class MySyncListViewSet changed:
    Removed method get_permissions
    Method get_queryset changed implementation:
      Code semantics changed
      No longer uses imported permissions
      Newly uses imported get_objects_for_user
Module galaxy_ng/app/api/ui/viewsets/namespace.py changed:
  Removed import of serializers from removed galaxy_ng.app.api.ui
  Class NamespaceViewSet changed:
    Removed method get_serializer_class
Module galaxy_ng/app/api/ui/viewsets/synclist.py changed:
  Removed import of permissions from galaxy_ng.app.api
  New imported access_policy from new galaxy_ng.app.access_control
  Class SyncListViewSet changed:
    Removed method get_permissions
Module galaxy_ng/app/api/ui/viewsets/tags.py changed:
  New imported access_policy from new galaxy_ng.app.access_control
Module galaxy_ng/app/api/ui/viewsets/user.py changed:
  Removed import of drf_permissions from rest_framework
  Removed import of permissions from galaxy_ng.app.api
  New imported access_policy from new galaxy_ng.app.access_control
  Class CurrentUserViewSet changed:
    Removed method get_permissions
  Class UserViewSet changed:
    Removed method get_permissions
Module galaxy_ng/app/api/v3/serializers/namespace.py changed:
  Removed import of auth_models from removed galaxy_ng.app.models
  Removed import of GroupSummarySerializer from removed galaxy_ng.app.api.v3.serializers.group
  New imported GroupPermissionField from new galaxy_ng.app.access_control.fields
  Class NamespaceSerializer changed:
    Removed method to_internal_value
    Method create changed implementation:
      Code semantics changed
      No longer uses imported auth_models
    Method update changed implementation:
      Code semantics changed
      No longer uses imported auth_models
Module galaxy_ng/app/api/v3/views/auth.py changed:
  Removed import of IsAuthenticated from removed rest_framework.permissions
  Removed import of RestrictOnCloudDeployments from removed galaxy_ng.app.api.permissions
  New imported access_policy from new galaxy_ng.app.access_control
Module galaxy_ng/app/api/v3/viewsets/collection.py changed:
  Removed import of GALAXY_PERMISSION_CLASSES from galaxy_ng.app.api.base
  Removed import of permissions from removed galaxy_ng.app.api
  New imported access_policy from new galaxy_ng.app.access_control
  Class CollectionUploadViewSet changed:
    Method _dispatch_import_collection_task changed implementation:
       Removed arg temp_file_pk
       Added arg artifact_pk
      Code semantics changed
    Method create changed implementation:
      Code semantics changed
      No longer uses imported CollectionUploadSerializer
    New method _get_data
Module galaxy_ng/app/api/v3/viewsets/namespace.py changed:
  Removed import of permissions from galaxy_ng.app.api
  New imported NamespaceAccessPolicy from new galaxy_ng.app.access_control.access_policy
  Class NamespaceViewSet changed:
    Removed method get_permissions
    New method get_serializer_class
Module galaxy_ng/app/api/v3/viewsets/task.py changed:
  Removed import of GALAXY_PERMISSION_CLASSES from galaxy_ng.app.api.base
  New imported access_policy from new galaxy_ng.app.access_control
Module galaxy_ng/app/auth/auth.py changed:
  Removed import of settings from removed django.conf
  Removed import of BasePermission from removed rest_framework.permissions
Module galaxy_ng/app/models/collectionimport.py changed:
  New imported LifecycleModel from new django_lifecycle
  New imported AutoDeleteObjPermsMixin from new pulpcore.plugin.models
Module galaxy_ng/app/models/namespace.py changed:
  New imported LifecycleModel from new django_lifecycle
  New imported AutoDeleteObjPermsMixin from new pulpcore.plugin.models
  New imported mixins from new galaxy_ng.app.access_control
Module galaxy_ng/app/models/synclist.py changed:
  New imported AutoDeleteObjPermsMixin from new pulpcore.plugin.models
  New imported LifecycleModel from new django_lifecycle
  New imported GroupModelPermissionsMixin from new galaxy_ng.app.access_control.mixins
Module galaxy_ng/app/tasks/publishing.py changed:
  Removed import of ContentType from removed django.contrib.contenttypes.models
  Removed import of Task from pulpcore.plugin.models
  Removed import of AnsibleDistribution, CollectionVersion from pulp_ansible.app.models
  New imported ContentArtifact from pulpcore.plugin.models
  Removed function get_created_collection_versions
  Function import_and_auto_approve changed implementation:
     Removed arg temp_file_pk
     Added arg artifact_pk
    Code semantics changed
    No longer uses imported AnsibleDistribution, AnsibleRepository, add_content_to_repository, enqueue_with_reservation, remove_content_from_repository
    Newly uses imported ContentArtifact
  Function import_and_move_to_staging changed implementation:
     Removed arg temp_file_pk
     Added arg artifact_pk
    Code semantics changed
    No longer uses imported AnsibleDistribution
    Newly uses imported ContentArtifact
Module galaxy_ng/tests/unit/api/base.py changed:
  Removed import of auth from removed galaxy_ng.app.auth
  New imported access_policy from new galaxy_ng.app.access_control
  New imported assign_perm from new guardian.shortcuts
  Class BaseTestCase changed:
    Method _create_namespace changed implementation:
      Code semantics changed
    Method setUp changed implementation:
      Code semantics changed
      No longer uses imported auth
      Newly uses imported access_policy
    New method _create_partner_engineer_group
Module galaxy_ng/tests/unit/api/test_api_ui_my_synclists.py changed:
  Removed import of permissions from removed galaxy_ng.app.api
  Class TestUiMySyncListViewSet changed:
    Method _create_synclist changed implementation:
       Removed arg users
      Code semantics changed
    Method setUp changed implementation:
      Code semantics changed
      No longer uses imported permissions
    Method test_my_synclist_create changed implementation:
      Code semantics changed
    Method test_my_synclist_delete changed implementation:
      Code semantics changed
    Method test_my_synclist_list changed implementation:
      Code semantics changed
    Method test_my_synclist_update changed implementation:
      Code semantics changed
Module galaxy_ng/tests/unit/api/test_api_ui_synclists.py changed:
  Removed import of permissions from removed galaxy_ng.app.api
  Class TestUiSynclistViewSet changed:
    Method _create_synclist changed implementation:
       Removed arg users
      Code semantics changed
    Method setUp changed implementation:
      Code semantics changed
      No longer uses imported permissions
    Method test_synclist_create_as_pe_group changed implementation:
      Code semantics changed
    Method test_synclist_create_as_user changed implementation:
      Code semantics changed
    Method test_synclist_update_as_non_pe_group_user changed implementation:
      Code semantics changed
    Method test_synclist_update_as_pe_group_user changed implementation:
      Code semantics changed
Module galaxy_ng/tests/unit/api/test_api_ui_user_viewsets.py changed:
  Removed import of permissions from removed galaxy_ng.app.api
  Class TestUiNamespaceViewSet changed:
    Method setUp changed implementation:
      Code semantics changed
      No longer uses imported permissions
    Method test_user_get changed implementation:
      Code semantics changed
Module galaxy_ng/tests/unit/api/test_api_v3_namespace_viewsets.py changed:
  Removed import of permissions from removed galaxy_ng.app.api
  Class TestV3NamespaceViewSet changed:
    Method setUp changed implementation:
      Code semantics changed
      No longer uses imported permissions
    Method test_delete_namespace_no_error_if_no_repo_exist changed implementation:
      Code semantics changed
    Method test_namespace_api_creates_deletes_inbound_repo changed implementation:
      Code semantics changed
Module galaxy_ng/tests/unit/app/test_tasks.py changed:
  Removed import of settings from removed django.conf
  Removed import of override_settings from django.test
  Removed import of PulpTemporaryFile from pulpcore.plugin.models
  Removed import of AnsibleDistribution from pulp_ansible.app.models
  Class TestTaskPublish changed:
    Removed attribute pulp_temp_file
    Method setUp changed implementation:
      Code semantics changed
      No longer uses imported PulpTemporaryFile
    Method test_import_and_auto_approve changed implementation:
       Removed arg mocked_enqueue
       Removed arg mocked_import
       Removed arg mocked_get_created
       Added arg mocked_import_collection
      Code semantics changed
      No longer uses imported AnsibleDistribution, AnsibleRepository
    Method test_import_and_move_to_staging changed implementation:
       Removed arg mocked_get_created
      Code semantics changed
      No longer uses imported AnsibleDistribution
New modules galaxy_ng/app/access_control/__init__.py, galaxy_ng/app/access_control/access_policy.py, galaxy_ng/app/access_control/fields.py, galaxy_ng/app/access_control/mixins.py, galaxy_ng/app/access_control/statements/__init__.py, galaxy_ng/app/access_control/statements/insights.py, galaxy_ng/app/access_control/statements/standalone.py, galaxy_ng/app/migrations/0004_rbac.py