Skip to content

Instantly share code, notes, and snippets.

@alonecuzzo

alonecuzzo/apnHandOff.md

Last active May 25, 2016 19:51
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save alonecuzzo/87011f45f450eb22893e91db79d3613a to your computer and use it in GitHub Desktop.
Save alonecuzzo/87011f45f450eb22893e91db79d3613a to your computer and use it in GitHub Desktop.
Download ZIP
Raw
apnHandOff.md

State of things: The story functionally works. There is an issue IOS-364 that was created as a result of a conversation on IOS-125 and findings by Stephanie. Those details are on the referenced stories in the Stories of Interest section.

###Stories of Interest

  1. https://paperless.atlassian.net/browse/IOS-125 - main story
  2. https://paperless.atlassian.net/browse/IOS-364 - currently blocking the main story. There's a usability issue that Corey suggested a solution for. He made the comment on the IOS-125 story. IOS-364 is an investigation into changing the settings panel. We'll also need design direction.

###Code

This was the original pull request for the feature: https://github.com/paperlesspost/paperless-ios/pull/2570/files It all works and I think it is relatively straightforward. If the app determines that the APN panel should be shown https://github.com/paperlesspost/paperless-ios/pull/2628/files#diff-d72f45ee993bc380c272d8f37e44ad80R519, it'll show it.

I replied to your comment on this pull request: https://github.com/paperlesspost/paperless-ios/pull/2628 which has been tested and works. I haven't merged it because it's related to the IOS-364 investigation because it doesn't address the edge case of a user on a device with a fresh token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment