CT390 Spring '14 Submission #1

ct390-spring14-sub1.java

package edu.drexel.goodwin.cst.ct390;

 

import java.io.IOException;

 

import javax.servlet.ServletException;

import javax.servlet.annotation.WebServlet;

import javax.servlet.http.HttpServlet;

import javax.servlet.http.HttpServletRequest;

import javax.servlet.http.HttpServletResponse;

import javax.servlet.http.HttpSession;

 

@WebServlet("/HelloName")

public class HelloName extends HttpServlet {

 

        protected void doGet(HttpServletRequest request, HttpServletResponse response)

                        throws ServletException, IOException {

                handleGreeting(request, response);

        }

 

        protected void doPost(HttpServletRequest request, HttpServletResponse response)

                        throws ServletException, IOException {

                handleGreeting(request, response);

        }

 

        /**

         * Generic method to handle greetings

         * 

         * @param request

         * @param response

         * @throws ServletException

         * @throws IOException

         */

        protected void handleGreeting(HttpServletRequest request, HttpServletResponse response)

                        throws ServletException, IOException {

 

                // TODO: Clean XSS-vulnerable parameters 

 

                HttpSession session = request.getSession();

                // Handle cookie output

                int cookieCount = request.getCookies().length;

                response.addHeader("Cookie-Count", "Hi " + session.getAttribute("name") + " you have " + String.valueOf(cookieCount) + " cookie(s)");


                // Get provided name

                String name = request.getParameter("name");


                if(name == null)

                {

                        // No name set

                        response.getWriter().println("hello world");

                }

                else

                {

                        // Set session attribute

                        session.setAttribute("name", name);


                        // Greet with name

                        response.getWriter().println("Greetings, " + name);

                }

        }


}

I really think this one is well written! I like how that the author created a function that handled either a POST or GET request. I think that it is beneficially and cut down on the amount of code being written (way more functional then my submission!).

I also like the use of the request.getCookies().length. When doing my research I must have missed that method! So once again this code is more practical to my submission.

This submission also makes good use of comments throughout to help someone over looking the code know exactly what the author intended to do. Overall I would say a superb submission, I can't really think of anything that could be improved.

All variables and methods are comprehensible, properly named, and functional which allows this code to be well written. I do not see any obvious errors, correct me if I'm wrong..

The commentary provided throughout is helpful. It makes it easier for the reader to follow along step by step and get a better understanding of exactly what is happening on each line.

The overall code would be easy to update and maintain because it is organized without any excess code.

Great submission.