amrvitale

 

 FAIL  src/draftlingpage/DraftlingPage.test.js      
  ● Console

    console.log src/draftlingpage/DraftlingPage.js:86
      undefined
    console.log src/draftlingpage/DraftlingPage.js:87
      [] draftlings
    console.log src/draftlingpage/DraftlingPage.js:89

amrvitale

Hi Angela,

I'm Jeff from the Grading Team. Good job on your assignment so far.

Please review the following grading criteria and fix any items that I've marked with an ❌ .
Good job on all the items that I've marked with a 👍 !

Feedback Key
[ 👍 ] = What you did well
[ ❌ ] = Required changes to pass assignment

amrvitale

const { expect } = require('chai');
const supertest = require('supertest');
const app = require('../app');

describe('GET /drafting', () => {
    it('should return an draftling/s page', () => {
        return supertest(app)
        .get('/')
        .expect(200)
        .expect('Content-Type', /json/)

amrvitale

I asked my mother and my husband again for their feedback on my now MVP for Reciplease.

Mother's feedback: Love the images! Still could use some work on mobile sizing, images stay the same size, so you
only see part of them on smaller devices. Overall, flow makes sense, good job on that.

Husband's feedback: Overall, works well and it's very pretty, but needs some mobile adjustments.

What I did in response:  I am working on the mobile enhancement to create a better experience on smaller devices. 
Will use media queries or something similar to adjust the images to a smaller screen size.

amrvitale

ISSUE: I'm only seeing results when I click "search" but without any terms searched on. 
If I enter a search term that should return results, I get "No results found, search again" message

CLIENT CODE: https://github.com/amrvitale/reciplease-capstone/blob/master/src/components/search/Search.js  (search component)
SERVER CODE: https://github.com/amrvitale/reciplease-capstone-api/tree/master/src/searchRecipes

POSTMAN: I've tried get request in Postman, but only get the empty {"recipes": []} array object when I search http://localhost:8000/api/search?recipename=chocolate

WHAT I'VE TRIED: I have lots of "sanity testing" console logs throughout my server code, and these are now appearing in the vs code terminal.

amrvitale

2020-07-19T18:58:49.514916+00:00 app[web.1]: andWhereNotBetween: [Function],
2020-07-19T18:58:49.514917+00:00 app[web.1]: orWhereBetween: [Function],
2020-07-19T18:58:49.514917+00:00 app[web.1]: orWhereNotBetween: [Function],
2020-07-19T18:58:49.514917+00:00 app[web.1]: groupBy: [Function],
2020-07-19T18:58:49.514918+00:00 app[web.1]: groupByRaw: [Function],
2020-07-19T18:58:49.514918+00:00 app[web.1]: orderBy: [Function],
2020-07-19T18:58:49.514918+00:00 app[web.1]: orderByRaw: [Function],
2020-07-19T18:58:49.514919+00:00 app[web.1]: union: [Function],
2020-07-19T18:58:49.514919+00:00 app[web.1]: unionAll: [Function],
2020-07-19T18:58:49.514919+00:00 app[web.1]: intersect: [Function],

amrvitale

I asked my mother and my husband again for their feedback on my now MVP for Draftling.

Mother's feedback: Love the images! Still could use some work on mobile sizing, images stay the same size, so you
only see part of them on smaller devices. Overall, flow makes sense, good job on that.

Husband's feedback: Lots of questions on the template critique, but also good that you provide an option for the "freeform" 
critique so that the editor can decide if they want to enter lots of feedback or not.

What I did in response: Going to keep the number of questions on critiques since I do provide an option (between longer and shorter 
critiques), but I am working on the mobile enhancement to create a better experience on smaller devices. Will use media queries

amrvitale

 npm run deploy

> draftling-capstone-api@1.0.0 predeploy C:\Users\abumgarner\Desktop\draftling-capstone-api
> npm audit && npm run migrate:production


                       === npm audit security report ===                        

# Run  npm install --save-dev mocha@8.0.1  to resolve 1 vulnerability
SEMVER WARNING: Recommended action is a potentially breaking change

amrvitale

 npm run deploy

> draftling-capstone-api@1.0.0 predeploy C:\Users\abumgarner\Desktop\draftling-capstone-api
> npm audit && npm run migrate:production


                       === npm audit security report ===                        

# Run  npm install --save-dev mocha@8.0.1  to resolve 1 vulnerability
SEMVER WARNING: Recommended action is a potentially breaking change

amrvitale

$ npm install
npm WARN draftling-capstone-api@1.0.0 No description
npm WARN draftling-capstone-api@1.0.0 No repository field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.7: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

npm ERR! code EPERM
npm ERR! syscall rename
npm ERR! path C:\Users\abumgarner\Desktop\draftling-capstone-api\node_modules\has-flag\package.json.2001523142
npm ERR! dest C:\Users\abumgarner\Desktop\draftling-capstone-api\node_modules\has-flag\package.json