Skip to content

Instantly share code, notes, and snippets.

@andrewnicols
Created October 5, 2019 06:01
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save andrewnicols/c0bcf320b193b8d32d638508c5978ad8 to your computer and use it in GitHub Desktop.
Save andrewnicols/c0bcf320b193b8d32d638508c5978ad8 to your computer and use it in GitHub Desktop.
course/amd/build/repository.min.js.map | Bin 5808 -> 5738 bytes
course/amd/src/repository.js | 17 +++++++----------
mod/forum/db/upgrade.php | 1 -
rating/lib.php | 5 ++---
version.php | 2 +-
5 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/course/amd/build/repository.min.js.map b/course/amd/build/repository.min.js.map
index 6522f91e228..1e49dc2d9b0 100644
Binary files a/course/amd/build/repository.min.js.map and b/course/amd/build/repository.min.js.map differ
diff --git a/course/amd/src/repository.js b/course/amd/src/repository.js
index b1061146b75..7e530a72543 100644
--- a/course/amd/src/repository.js
+++ b/course/amd/src/repository.js
@@ -95,20 +95,17 @@ define(['jquery', 'core/ajax'], function($, Ajax) {
};
/**
- * Get the list of courses that the user has most recently accessed.
+ * Get the list of users enrolled in this cmid.
*
- * @method getUsersFromCourseModuleID
- * @param {int} cmid Course Module from which the users will be obtained
- * @return {promise} Resolved with an array of users
+ * @param {Number} cmid Course Module from which the users will be obtained
+ * @returns {Promise} Promise containing a list of users
*/
var getEnrolledUsersFromCourseModuleID = function(cmid) {
- var args = {};
-
- args.cmid = cmid;
-
var request = {
methodname: 'core_course_get_enrolled_users_by_cmid',
- args: args
+ args: {
+ cmid: cmid,
+ },
};
return Ajax.call([request])[0];
@@ -117,6 +114,6 @@ define(['jquery', 'core/ajax'], function($, Ajax) {
return {
getEnrolledCoursesByTimelineClassification: getEnrolledCoursesByTimelineClassification,
getLastAccessedCourses: getLastAccessedCourses,
- getUsersFromCourseModuleID: getEnrolledUsersFromCourseModuleID
+ getUsersFromCourseModuleID: getEnrolledUsersFromCourseModuleID,
};
});
diff --git a/mod/forum/db/upgrade.php b/mod/forum/db/upgrade.php
index d24a7b85baf..0c4def253f4 100644
--- a/mod/forum/db/upgrade.php
+++ b/mod/forum/db/upgrade.php
@@ -202,6 +202,5 @@ function xmldb_forum_upgrade($oldversion) {
upgrade_mod_savepoint(true, 2019100100, 'forum');
}
-
return true;
}
diff --git a/rating/lib.php b/rating/lib.php
index 5248e5631cd..f70fbb3ffc8 100644
--- a/rating/lib.php
+++ b/rating/lib.php
@@ -1224,14 +1224,13 @@ class rating_exception extends moodle_exception {
* @var string The message to accompany the thrown exception
*/
public $message;
-
/**
* Generate exceptions that can be easily identified as coming from the ratings system
*
* @param string $errorcode the error code to generate
*/
- public function __construct(string $errorcode, string $component = 'error', stdClass $a = null) {
+ public function __construct($errorcode) {
$this->errorcode = $errorcode;
- $this->message = get_string($errorcode, $component, $a);
+ $this->message = get_string($errorcode, 'error');
}
}
diff --git a/version.php b/version.php
index 5ab51b10f17..770b3d4afa6 100644
--- a/version.php
+++ b/version.php
@@ -29,7 +29,7 @@
defined('MOODLE_INTERNAL') || die();
-$version = 2019100400.03; // YYYYMMDD = weekly release date of this DEV branch.
+$version = 2019100401.00; // YYYYMMDD = weekly release date of this DEV branch.
// RR = release increments - 00 in DEV branches.
// .XX = incremental changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment