Methods vs Properties, Kyiv 2010

properties_vs_methods.cs

public class UserManager {
  // This property is doing WAY too much work to be a property
  public string[] Users {
    get { 
      var usersList = new List<string>();

      using (var connection = ConnectToDatabase()) {
        var users = connection.GetUsersTable();
        users.Rows.ForEach((row) => usersList.Add(row.UserName));
      }

      return usersList.ToArray();
    } 
  }

  // This method doesn't do anything; it just wraps a field.
  public string GetCurrentUserName() {
    return _userName;
  }
}