Skip to content

Instantly share code, notes, and snippets.

View anjohnson's full-sized avatar

Andrew Johnson anjohnson

  • Argonne
  • Chicagoland
View GitHub Profile
@anjohnson
anjohnson / pull-request-guidelines.md
Last active August 29, 2015 14:25
Github pull request handling for the EPICS V4 Working Group

Github pull request handling for the EPICS V4 Working Group

  • Module owners may commit and push minor changes directly to the master branch of their own modules on github.
  • For major changes that should be tested and reviewed by other people, module owners should work in a private repository and create a pull request when the work is ready for review.
  • Anybody may create or comment on a pull request on any module -- this includes unsolicited contributions from non-members.
  • A module's owner normally makes the final decision on merging pull requests for their modules and performs the merge (in many cases this just means pushing the green Merge button on the pull request webpage and confirming the merge).
  • A meeting of the working group may nominate someone other than a module's owner to perform merge operations for specific changes discussed by the group.
  • Large or API-changing modifications should never be merged without allowing time for discussion, which should happen through the gith