Skip to content

Instantly share code, notes, and snippets.

Created January 10, 2011 01:26
Show Gist options
  • Save anonymous/772218 to your computer and use it in GitHub Desktop.
Save anonymous/772218 to your computer and use it in GitHub Desktop.
diff --git a/plugins/mod_storage_sql.lua b/plugins/mod_storage_sql.lua
--- a/plugins/mod_storage_sql.lua
+++ b/plugins/mod_storage_sql.lua
@@ -28,14 +28,35 @@
local xpcall = xpcall;
local json = require "util.json";
+local DBI;
local connection;
local host,user,store = module.host;
local params = module:get_option("sql");
local resolve_relative_path = require "core.configmanager".resolve_relative_path;
+local function test_connection()
+ if connection and connection:ping() then then return true; end
+ connection = nil;
+end
+local function connect()
+ if not test_connection() then
+ prosody.unlock_globals();
+ local dbh, err = DBI.Connect(
+ params.driver, params.database,
+ params.username, params.password,
+ params.host, params.port
+ );
+ prosody.lock_globals();
+ if not dbh then return nil, err; end
+ dbh:autocommit(false); -- don't commit automatically
+ connection = dbh;
+ return connection;
+ end
+end
+
do -- process options to get a db connection
- local DBI = require "DBI";
+ DBI = require "DBI";
params = params or { driver = "SQLite3" };
@@ -45,17 +66,7 @@
assert(params.driver and params.database, "Both the SQL driver and the database need to be specified");
- prosody.unlock_globals();
- local dbh, err = DBI.Connect(
- params.driver, params.database,
- params.username, params.password,
- params.host, params.port
- );
- prosody.lock_globals();
- assert(dbh, err);
-
- dbh:autocommit(false); -- don't commit automatically
- connection = dbh;
+ assert(connect());
-- Automatically create table, ignore failure (table probably already exists)
local create_sql = "CREATE TABLE `prosody` (`host` TEXT, `user` TEXT, `store` TEXT, `key` TEXT, `type` TEXT, `value` TEXT);";
@@ -101,9 +112,11 @@
end
-- do prepared statement stuff
local stmt, err = connection:prepare(sql);
+ if not stmt and not test_connection() then error("connection failed"); end
if not stmt then module:log("error", "QUERY FAILED: %s %s", err, debug.traceback()); return nil, err; end
-- run query
local ok, err = stmt:execute(host or "", user or "", store or "", ...);
+ if not ok and not test_connection() then error("connection failed"); end
if not ok then return nil, err; end
return stmt;
@@ -127,7 +140,7 @@
local function keyval_store_get()
local stmt, err = getsql("SELECT * FROM `prosody` WHERE `host`=? AND `user`=? AND `store`=?");
- if not stmt then return nil, err; end
+ if not stmt then return rollback(nil, err); end
local haveany;
local result = {};
@@ -147,6 +160,7 @@
end
local function keyval_store_set(data)
local affected, err = setsql("DELETE FROM `prosody` WHERE `host`=? AND `user`=? AND `store`=?");
+ if not affected then return rollback(affected, err); end
if data and next(data) ~= nil then
local extradata = {};
@@ -175,17 +189,23 @@
function keyval_store:get(username)
user,store = username,self.store;
local success, ret, err = xpcall(keyval_store_get, debug.traceback);
+ if not connection and connect() then
+ success, ret, err = xpcall(keyval_store_get, debug.traceback);
+ end
if success then return ret, err; else return rollback(nil, ret); end
end
function keyval_store:set(username, data)
user,store = username,self.store;
local success, ret, err = xpcall(function() return keyval_store_set(data); end, debug.traceback);
+ if not connection and connect() then
+ success, ret, err = xpcall(function() return keyval_store_set(data); end, debug.traceback);
+ end
if success then return ret, err; else return rollback(nil, ret); end
end
local function map_store_get(key)
local stmt, err = getsql("SELECT * FROM `prosody` WHERE `host`=? AND `user`=? AND `store`=? AND `key`=?", key or "");
- if not stmt then return nil, err; end
+ if not stmt then return rollback(nil, err); end
local haveany;
local result = {};
@@ -205,6 +225,7 @@
end
local function map_store_set(key, data)
local affected, err = setsql("DELETE FROM `prosody` WHERE `host`=? AND `user`=? AND `store`=? AND `key`=?", key or "");
+ if not affected then return rollback(affected, err); end
if data and next(data) ~= nil then
if type(key) == "string" and key ~= "" then
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment