Created
May 20, 2016 15:36
-
-
Save anonymous/a73d099195a0b8215e8504151db5071d to your computer and use it in GitHub Desktop.
opengapps_shellcheck
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| In ./report_sources.sh line 49: | |
| *) [ ! -z "${1##*[!0-9]*}" ] && maxsdk="$1" || { echo "ERROR: invalid argument" && exit 1; };; | |
| ^-- SC2015: Note that A && B || C is not if-then-else. C may run when A is true. | |
| In ./add_sourceapp.sh line 117: | |
| if [ "$(echo $native)" = "" ]; then # we can't use -z here, because there can be a spaces in it | |
| ^-- SC2116: Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.packagetarget.sh line 16: | |
| for f in $(find "$build" -name '*.apk'); do | |
| ^-- SC2044: For loops over find output are fragile. Use find -exec or a while read loop. | |
| In ./scripts/inc.packagetarget.sh line 174: | |
| for d in $(ls -d */ | grep -v "META-INF"); do #notice that d will end with a slash, ls is safe here because there are no directories with spaces | |
| ^-- SC2010: Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames. | |
| ^-- SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options. | |
| In ./scripts/inc.packagetarget.sh line 179: | |
| printf "%s\t%s\t%d\n" "$f" "odex" "$(($(echo "$(unzip -ql "$apk" "classes*.dex" | tail -n 1)" | awk '{print $1"*(("$2"/2)+2)/1024"}')))" >> "$build/app_sizes.txt" # estimation heuristic: size-dexfiles * ((#-dexfiles/2)+2); bytes -> KiB | |
| ^-- SC2005: Useless echo? Instead of 'echo $(cmd)', just use 'cmd'. | |
| In ./scripts/inc.packagetarget.sh line 195: | |
| if [ $threads -ge $THREADS ] || [ $MEMORY -ge $memory ] || [ $memory -lt $MEMORY_MIN ]; then | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.packagetarget.sh line 221: | |
| for p in $pidlist; do wait $p; done | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.packagetarget.sh line 237: | |
| zip -q -r -D -X -$ZIPCOMPRESSIONLEVEL "$unsignedzip" ./* #don't doublequote zipfolders, contains multiple (safe) arguments | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/bkup_tail.sh line 6: | |
| installed_gapps_size_kb=$(cd /system; du -ak $(list_files) | awk '{ i+=$1 } END { print i }') | |
| ^-- SC2046: Quote this to prevent word splitting. | |
| In ./scripts/bkup_tail.sh line 23: | |
| list_files | while read FILE DUMMY; do | |
| ^-- SC2162: read without -r will mangle backslashes. | |
| In ./scripts/bkup_tail.sh line 28: | |
| list_files | while read FILE REPLACEMENT; do | |
| ^-- SC2162: read without -r will mangle backslashes. | |
| In ./scripts/bkup_tail.sh line 59: | |
| find $i -type d | xargs -r rmdir -p --ignore-fail-on-non-empty; | |
| ^-- SC2038: Use -print0/-0 or -exec + to allow for non-alphanumeric filenames. | |
| In ./scripts/bkup_tail.sh line 66: | |
| chmod 755 $(dirname "/system/$i") | |
| ^-- SC2046: Quote this to prevent word splitting. | |
| In ./scripts/inc.buildhelper.sh line 209: | |
| for foundapk in $(find $SOURCES/$2/*app/$1 -iname '*.apk' | sed 's!.*/\(.*\)!\1/&!' | sort -r -t/ -k1,1 | cut -d/ -f2-); do | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.buildhelper.sh line 246: | |
| for foundlib in $(find $SOURCES/$2/lib*/ $SOURCES/$2/vendor/lib*/ -iname "$1" | sort -r); do | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.buildhelper.sh line 286: | |
| rm -rf "$targetdir/lib/" | |
| ^-- SC2115: Use "${var:?}" to ensure this never expands to /lib . | |
| In ./scripts/inc.sourceshelper.sh line 103: | |
| if [ "$(echo $compatiblescreens)" = "" ]; then # we can't use -z here, because there can be a linecontrol character or such in it | |
| ^-- SC2116: Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./download_sources.sh line 34: | |
| git submodule deinit -f sources/$module | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./download_sources.sh line 35: | |
| rm -rf .git/modules/sources/$module | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./download_sources.sh line 47: | |
| argument $arg | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./download_sources.sh line 52: | |
| git submodule update --init --remote $depth -- sources/$module # --rebase is specifed in .gitmodules | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| In ./report_sources.sh line 49: | |
| *) [ ! -z "${1##*[!0-9]*}" ] && maxsdk="$1" || { echo "ERROR: invalid argument" && exit 1; };; | |
| ^-- SC2015: Note that A && B || C is not if-then-else. C may run when A is true. | |
| In ./add_sourceapp.sh line 117: | |
| if [ "$(echo $native)" = "" ]; then # we can't use -z here, because there can be a spaces in it | |
| ^-- SC2116: Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.packagetarget.sh line 16: | |
| for f in $(find "$build" -name '*.apk'); do | |
| ^-- SC2044: For loops over find output are fragile. Use find -exec or a while read loop. | |
| ^-- SC2154: build is referenced but not assigned. | |
| In ./scripts/inc.packagetarget.sh line 106: | |
| compression="$COMPRESSION" | |
| ^-- SC2153: Possible misspelling: COMPRESSION may not be assigned, but compression is. | |
| In ./scripts/inc.packagetarget.sh line 156: | |
| cd "$build" | |
| ^-- SC2164: Use cd ... || exit in case cd fails. | |
| In ./scripts/inc.packagetarget.sh line 174: | |
| for d in $(ls -d */ | grep -v "META-INF"); do #notice that d will end with a slash, ls is safe here because there are no directories with spaces | |
| ^-- SC2010: Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames. | |
| ^-- SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options. | |
| In ./scripts/inc.packagetarget.sh line 175: | |
| cd "$build/$d" | |
| ^-- SC2164: Use cd ... || exit in case cd fails. | |
| In ./scripts/inc.packagetarget.sh line 176: | |
| for f in $(ls); do # ls is safe here because there are no directories with spaces | |
| ^-- SC2045: Iterating over ls output is fragile. Use globs. | |
| In ./scripts/inc.packagetarget.sh line 178: | |
| if [ -f "$apk" ] && ! (unzip -ql "$apk" | grep -q "META-INF/MANIFEST.MF" && unzip -p "$apk" "META-INF/MANIFEST.MF" | grep -q "$classes.dex"); then | |
| ^-- SC2154: classes is referenced but not assigned. | |
| In ./scripts/inc.packagetarget.sh line 179: | |
| printf "%s\t%s\t%d\n" "$f" "odex" "$(($(echo "$(unzip -ql "$apk" "classes*.dex" | tail -n 1)" | awk '{print $1"*(("$2"/2)+2)/1024"}')))" >> "$build/app_sizes.txt" # estimation heuristic: size-dexfiles * ((#-dexfiles/2)+2); bytes -> KiB | |
| ^-- SC2005: Useless echo? Instead of 'echo $(cmd)', just use 'cmd'. | |
| In ./scripts/inc.packagetarget.sh line 181: | |
| for g in $(ls "$f"); do | |
| ^-- SC2045: Iterating over ls output is fragile. Use globs. | |
| In ./scripts/inc.packagetarget.sh line 195: | |
| if [ $threads -ge $THREADS ] || [ $MEMORY -ge $memory ] || [ $memory -lt $MEMORY_MIN ]; then | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.packagetarget.sh line 221: | |
| for p in $pidlist; do wait $p; done | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.packagetarget.sh line 235: | |
| cd "$build" | |
| ^-- SC2164: Use cd ... || exit in case cd fails. | |
| In ./scripts/inc.packagetarget.sh line 237: | |
| zip -q -r -D -X -$ZIPCOMPRESSIONLEVEL "$unsignedzip" ./* #don't doublequote zipfolders, contains multiple (safe) arguments | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.packagetarget.sh line 238: | |
| cd "$TOP" | |
| ^-- SC2164: Use cd ... || exit in case cd fails. | |
| In ./scripts/inc.compatibility.sh line 24: | |
| echo ' | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.compatibility.sh line 46: | |
| echo ' sed -i "\:/system/app/LatinImeGoogle.apk:d" $gapps_removal_list;'>> "$1" | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.compatibility.sh line 48: | |
| echo ' sed -i "\:/system/app/LatinImeGoogle:d" $gapps_removal_list;'>> "$1" | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.compatibility.sh line 55: | |
| REQDLIST='/system/lib/libjni_latinimegoogle.so | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.compatibility.sh line 65: | |
| KEYBDINSTALLCODE='# Install/Remove SwypeLibs | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.compatibility.sh line 97: | |
| REQDLIST='/system/lib/libjni_latinimegoogle.so | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.compatibility.sh line 103: | |
| KEYBDINSTALLCODE='# Install/Remove SwypeLibs | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.compatibility.sh line 140: | |
| KEYBDINSTALLCODE='# Install/Remove SwypeLibs | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.compatibility.sh line 155: | |
| *) REQDLIST="" | |
| ^-- SC2034: REQDLIST appears unused. Verify it or export it. | |
| In ./scripts/inc.compatibility.sh line 156: | |
| KEYBDLIBS="" | |
| ^-- SC2034: KEYBDLIBS appears unused. Verify it or export it. | |
| In ./scripts/inc.compatibility.sh line 157: | |
| KEYBDINSTALLCODE="";; | |
| ^-- SC2034: KEYBDINSTALLCODE appears unused. Verify it or export it. | |
| In ./scripts/inc.compatibility.sh line 164: | |
| DATASIZESCODE=' # Broken lib configuration on KitKat, so some apps do not count for the /system space because they are on /data | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.compatibility.sh line 168: | |
| DATAINSTALLCODE=' | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.compatibility.sh line 245: | |
| DATASIZESCODE="" | |
| ^-- SC2034: DATASIZESCODE appears unused. Verify it or export it. | |
| In ./scripts/inc.compatibility.sh line 246: | |
| DATAINSTALLCODE="" | |
| ^-- SC2034: DATAINSTALLCODE appears unused. Verify it or export it. | |
| In ./scripts/inc.compatibility.sh line 262: | |
| REMOVALSUFFIX="" | |
| ^-- SC2034: REMOVALSUFFIX appears unused. Verify it or export it. | |
| In ./scripts/inc.compatibility.sh line 263: | |
| REMOVALBYPASS="" | |
| ^-- SC2034: REMOVALBYPASS appears unused. Verify it or export it. | |
| In ./scripts/inc.compatibility.sh line 269: | |
| case "$package" in | |
| ^-- SC2154: package is referenced but not assigned. | |
| In ./scripts/inc.compatibility.sh line 274: | |
| useminapi="21" | |
| ^-- SC2034: useminapi appears unused. Verify it or export it. | |
| In ./scripts/inc.compatibility.sh line 295: | |
| *) systemlib="false";; | |
| ^-- SC2034: systemlib appears unused. Verify it or export it. | |
| In ./scripts/inc.compatibility.sh line 380: | |
| webviewstocklibs='lib/$WebView_lib_filename | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.compatibility.sh line 391: | |
| webviewstocklibs="" # on non-Marshmallow the WebViewlibs should not be considered part of the Stock/AOSP WebView, since they are shared with the Google WebView | |
| ^-- SC2034: webviewstocklibs appears unused. Verify it or export it. | |
| In ./scripts/inc.compatibility.sh line 392: | |
| webviewgappsremove="lib/libwebviewchromium.so | |
| ^-- SC2034: webviewgappsremove appears unused. Verify it or export it. | |
| In ./scripts/inc.compatibility.sh line 404: | |
| com.android.facelock) if [ "$versioncode" = "23" ]; then sdkversion="23"; fi;; | |
| ^-- SC2154: versioncode is referenced but not assigned. | |
| In ./scripts/inc.compatibility.sh line 405: | |
| com.google.android.partnersetup) if [ "$versioncode" = "23" ]; then sdkversion="23"; fi;; | |
| ^-- SC2034: sdkversion appears unused. Verify it or export it. | |
| In ./scripts/bkup_tail.sh line 6: | |
| installed_gapps_size_kb=$(cd /system; du -ak $(list_files) | awk '{ i+=$1 } END { print i }') | |
| ^-- SC2164: Use cd ... || exit in case cd fails. | |
| ^-- SC2046: Quote this to prevent word splitting. | |
| In ./scripts/bkup_tail.sh line 23: | |
| list_files | while read FILE DUMMY; do | |
| ^-- SC2162: read without -r will mangle backslashes. | |
| ^-- SC2034: DUMMY appears unused. Verify it or export it. | |
| In ./scripts/bkup_tail.sh line 28: | |
| list_files | while read FILE REPLACEMENT; do | |
| ^-- SC2162: read without -r will mangle backslashes. | |
| In ./scripts/bkup_tail.sh line 59: | |
| find $i -type d | xargs -r rmdir -p --ignore-fail-on-non-empty; | |
| ^-- SC2038: Use -print0/-0 or -exec + to allow for non-alphanumeric filenames. | |
| In ./scripts/bkup_tail.sh line 66: | |
| chmod 755 $(dirname "/system/$i") | |
| ^-- SC2046: Quote this to prevent word splitting. | |
| In ./scripts/inc.buildhelper.sh line 17: | |
| build="$BUILD/$ARCH/$API/$VARIANT" | |
| ^-- SC2153: Possible misspelling: BUILD may not be assigned, but build is. | |
| In ./scripts/inc.buildhelper.sh line 64: | |
| if [ "$usearch" != "$fallback_arch" ]; then | |
| ^-- SC2154: fallback_arch is referenced but not assigned. | |
| In ./scripts/inc.buildhelper.sh line 146: | |
| if getapksforapi "$package" "$usearch" "$usemaxapi" "$useminapi"; then | |
| ^-- SC2154: useminapi is referenced but not assigned (did you mean 'usemaxapi'?). | |
| In ./scripts/inc.buildhelper.sh line 154: | |
| if [ "$API" -le "19" ] || [ "$systemlib" = "true" ]; then | |
| ^-- SC2154: systemlib is referenced but not assigned. | |
| In ./scripts/inc.buildhelper.sh line 209: | |
| for foundapk in $(find $SOURCES/$2/*app/$1 -iname '*.apk' | sed 's!.*/\(.*\)!\1/&!' | sort -r -t/ -k1,1 | cut -d/ -f2-); do | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.buildhelper.sh line 246: | |
| for foundlib in $(find $SOURCES/$2/lib*/ $SOURCES/$2/vendor/lib*/ -iname "$1" | sort -r); do | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.buildhelper.sh line 283: | |
| cd "$targetdir" | |
| ^-- SC2164: Use cd ... || exit in case cd fails. | |
| In ./scripts/inc.buildhelper.sh line 285: | |
| cd "$CURRENTPWD" | |
| ^-- SC2164: Use cd ... || exit in case cd fails. | |
| In ./scripts/inc.buildhelper.sh line 286: | |
| rm -rf "$targetdir/lib/" | |
| ^-- SC2115: Use "${var:?}" to ensure this never expands to /lib . | |
| In ./scripts/inc.sourceshelper.sh line 15: | |
| LOWESTAPI_all="19" | |
| ^-- SC2034: LOWESTAPI_all appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 16: | |
| LOWESTAPI_arm="19" | |
| ^-- SC2034: LOWESTAPI_arm appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 17: | |
| LOWESTAPI_arm64="21" | |
| ^-- SC2034: LOWESTAPI_arm64 appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 18: | |
| LOWESTAPI_x86="19" | |
| ^-- SC2034: LOWESTAPI_x86 appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 19: | |
| LOWESTAPI_x86_64="21" | |
| ^-- SC2034: LOWESTAPI_x86_64 appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 20: | |
| LOWESTAPI_leanback="22" | |
| ^-- SC2034: LOWESTAPI_leanback appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 30: | |
| name="$(echo "$apkproperties" | grep -a "application-label:" | sed 's/application-label://g' | sed "s/'//g")" | |
| ^-- SC2034: name appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 33: | |
| versioncode="$(echo "$apkproperties" | awk -F="'" '/versionCode=/ {print $3}' | sed "s/'.*//g")" | |
| ^-- SC2034: versioncode appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 34: | |
| sdkversion="$(echo "$apkproperties" | grep -a "sdkVersion:" | sed 's/sdkVersion://' | sed "s/'//g")" | |
| ^-- SC2034: sdkversion appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 36: | |
| native="$(echo "$apkproperties" | grep -av "alt-native-code:" | grep -a "native-code:" | sed 's/native-code://g' | sed "s/'//g") " # add a space at the end | |
| ^-- SC2034: native appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 37: | |
| altnative="$(echo "$apkproperties" | grep -a "alt-native-code:" | sed 's/alt-native-code://g' | sed "s/'//g") " # add a space at the end | |
| ^-- SC2034: altnative appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 86: | |
| *) type="app";; | |
| ^-- SC2034: type appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 90: | |
| if [ -n "$BETA" ]; then | |
| ^-- SC2153: Possible misspelling: BETA may not be assigned, but beta is. | |
| In ./scripts/inc.sourceshelper.sh line 96: | |
| *.beta/*) beta="beta" #report beta status as a property | |
| ^-- SC2034: beta appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 103: | |
| if [ "$(echo $compatiblescreens)" = "" ]; then # we can't use -z here, because there can be a linecontrol character or such in it | |
| ^-- SC2116: Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./scripts/inc.sourceshelper.sh line 106: | |
| dpis=$(echo "$compatiblescreens" | grep "compatible-screens:" | grep -oE "/([0-9][0-9])[0-9]" | sort -u | tr -d '\012\015' | tr '/' '-' | cut -c 2-) | |
| ^-- SC2034: dpis appears unused. Verify it or export it. | |
| In ./scripts/inc.sourceshelper.sh line 133: | |
| product="$(grep '<string name="product">' "$tmpapkdir/res/values/strings.xml" | sed -r 's#.*<string name="product">([^<]*)</string>#\1#')" | |
| ^-- SC2034: product appears unused. Verify it or export it. | |
| In ./scripts/inc.tools.sh line 26: | |
| echo 'Coreutils is required for install, basename, readlink, md5sum and other utilities, but is not installed or found in sh $PATH.';; | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.tools.sh line 28: | |
| echo 'JDK is required for jarsigner and keytools utilities, but is not installed or found in sh $PATH.';; | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.tools.sh line 30: | |
| echo 'Android SDK is required for aapt and zipalign utilities, but is not installed or found in sh $PATH.';; | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.tools.sh line 39: | |
| echo 'zipalign is outdated. Install a more recent version from the Android SDK and findable in sh $PATH.' >&2 | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.tools.sh line 45: | |
| echo 'aapt is outdated. Install a more recent version from the Android SDK and findable in sh $PATH.' >&2 | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/build_gapps.sh line 37: | |
| LOGFOLDER="$TOP/log" | |
| ^-- SC2034: LOGFOLDER appears unused. Verify it or export it. | |
| In ./scripts/inc.installer.sh line 23: | |
| # end addon properties" > "$build/$1" | |
| ^-- SC2154: build is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 34: | |
| get_gapps_list "$supported_variants" | |
| ^-- SC2154: supported_variants is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 35: | |
| for gapp in $gapps_list; do | |
| ^-- SC2154: gapps_list is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 37: | |
| if [ -n "$packagetarget" ]; then | |
| ^-- SC2154: packagetarget is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 41: | |
| for lib in $packagelibs; do | |
| ^-- SC2154: packagelibs is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 49: | |
| for file in $packagefiles; do | |
| ^-- SC2154: packagefiles is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 53: | |
| for extraline in $packagegappsremove; do | |
| ^-- SC2154: packagegappsremove is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 63: | |
| echo '#!/sbin/sh | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.installer.sh line 86: | |
| bb="$TMP/'"$2"'-$BINARCH" | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.installer.sh line 89: | |
| for f in '"$4"'; do | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.installer.sh line 92: | |
| for f in '"$5"'; do | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.installer.sh line 101: | |
| echo "ui_print ERROR 10: Failed to set-up Open GApps'"'"' pre-bundled '"$2"'" > "$OUTFD" | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.installer.sh line 112: | |
| echo "ui_print ERROR 64: Wrong architecture to set-up Open GApps'"'"' pre-bundled '"$2"'" > "$OUTFD" | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.installer.sh line 175: | |
| '"$gappscore"' | |
| ^-- SC2154: gappscore is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 179: | |
| '"$gappssuper"' | |
| ^-- SC2154: gappssuper is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 183: | |
| '"$gappsstock"' | |
| ^-- SC2154: gappsstock is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 187: | |
| '"$gappsfull"' | |
| ^-- SC2154: gappsfull is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 191: | |
| '"$gappsmini"' | |
| ^-- SC2154: gappsmini is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 195: | |
| '"$gappsmicro"' | |
| ^-- SC2154: gappsmicro is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 199: | |
| '"$gappsnano"' | |
| ^-- SC2154: gappsnano is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 203: | |
| '"$gappspico"' | |
| ^-- SC2154: gappspico is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 209: | |
| '"$stockremove"' | |
| ^-- SC2154: stockremove is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 507: | |
| '"$webviewstocklibs"'"; | |
| ^-- SC2154: webviewstocklibs is referenced but not assigned. | |
| In ./scripts/inc.installer.sh line 2137: | |
| echo '# Create WebView lib symlink if WebView was installed | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./scripts/inc.aromadata.sh line 16: | |
| tee "$build/META-INF/com/google/android/aroma-config" > /dev/null <<'EOFILE' | |
| ^-- SC2154: build is referenced but not assigned. | |
| In ./scripts/inc.buildtarget.sh line 32: | |
| gappssuper="androidpay | |
| ^-- SC2034: gappssuper appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 45: | |
| gappsstock="cameragoogle | |
| ^-- SC2034: gappsstock appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 49: | |
| gappsstock_optional="" | |
| ^-- SC2034: gappsstock_optional appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 51: | |
| gappsfull="books | |
| ^-- SC2034: gappsfull appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 69: | |
| gappsmini="clockgoogle | |
| ^-- SC2034: gappsmini appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 76: | |
| gappsmicro="calendargoogle | |
| ^-- SC2034: gappsmicro appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 81: | |
| gappsnano="facedetect | |
| ^-- SC2034: gappsnano appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 86: | |
| gappspico="calsync" | |
| ^-- SC2034: gappspico appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 88: | |
| stockremove="browser | |
| ^-- SC2034: stockremove appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 107: | |
| gappstvstock="backdrop | |
| ^-- SC2034: gappstvstock appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 131: | |
| miniremove="" | |
| ^-- SC2034: miniremove appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 144: | |
| *) fallback_arch="$1";; #return original arch if no fallback available | |
| ^-- SC2034: fallback_arch appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 164: | |
| tvstock) supported_variants="tvstock"; gappsremove_variant="tvstock";; | |
| ^-- SC2034: gappsremove_variant appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 166: | |
| *) supported_variants="";; | |
| ^-- SC2034: supported_variants appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 173: | |
| tv*) gapps_list="$gappstvcore $gappstvcore_optional";; | |
| ^-- SC2154: gappstvcore_optional is referenced but not assigned (did you mean 'gappscore_optional'?). | |
| In ./scripts/inc.buildtarget.sh line 178: | |
| gapps_list="$gapps_list $addtogapps" | |
| ^-- SC2154: addtogapps is referenced but not assigned. | |
| In ./scripts/inc.buildtarget.sh line 202: | |
| EXTRACTFILES="app_densities.txt app_sizes.txt" #is executed as first | |
| ^-- SC2034: EXTRACTFILES appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 203: | |
| CHMODXFILES="" | |
| ^-- SC2034: CHMODXFILES appears unused. Verify it or export it. | |
| In ./scripts/inc.buildtarget.sh line 220: | |
| webviewgoogle) packagetype="GApps"; packagename="com.google.android.webview"; packagetarget="app/WebViewGoogle"; packagegappsremove="$webviewgappsremove";; | |
| ^-- SC2034: packagegappsremove appears unused. Verify it or export it. | |
| ^-- SC2154: webviewgappsremove is referenced but not assigned. | |
| In ./download_sources.sh line 34: | |
| git submodule deinit -f sources/$module | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./download_sources.sh line 35: | |
| rm -rf .git/modules/sources/$module | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./download_sources.sh line 47: | |
| argument $arg | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./download_sources.sh line 52: | |
| git submodule update --init --remote $depth -- sources/$module # --rebase is specifed in .gitmodules | |
| ^-- SC2086: Double quote to prevent globbing and word splitting. | |
| In ./download_sources.sh line 58: | |
| git submodule foreach -q 'branch="$(git config -f "$toplevel/.gitmodules" "submodule.$name.branch")"; git checkout -q "$branch"; git pull -q $depth --rebase' | |
| ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that. | |
| In ./upload_sources.sh line 45: | |
| if [ "$sdkversion" -le "$lowestapi" ]; then | |
| ^-- SC2154: lowestapi is referenced but not assigned. | |
| In ./upload_sources.sh line 74: | |
| cd "$SOURCES/$arch" | |
| ^-- SC2164: Use cd ... || exit in case cd fails. | |
| In ./upload_sources.sh line 136: | |
| cd "$TOP" | |
| ^-- SC2164: Use cd ... || exit in case cd fails. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment