-
-
Save anonymous/b366b2d078290777858b to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08:39 notmyname: we've got a proposed patch to python-swiftclient that adds a dependency to requirements.txt (it's already in global requirements). however, jenkins never passes because grenade fails with an ImportError error | |
08:39 notmyname: any ideas on why that happens or how to fix it? | |
08:39 notmyname: https://review.openstack.org/#/c/85453/ | |
08:44 sdague: notmyname: so I think what's going on is that because the old side is stable/havana (but clients are always master) it's stripping out futures as that's not in stable/havana requirements | |
08:44 notmyname: stable/havana for what project? it's a client library, so that doesn't exist AFAIK | |
08:44 sdague: the direct fix would be to propose futures into stable/havana requirements | |
08:44 sdague: stable/havana requirements | |
08:45 notmyname: which isn't true. ie it's not a requirement in havana, nor does "havana" exist for python-*client | |
08:48 notmyname: sdague: oh, do you mean the openstack/requirements repo itself? on its stable/havana branch? | |
08:50 sdague: notmyname: yep | |
08:52 sdague: because master clients need to exist with stable/havana servers, we do a sync on stable/havana requirements on the old side for grenade | |
08:53 sdague: we really should *also* be making the clients run against old servers outside of grenade (which would also catch it), but they don't today | |
08:54 notmyname: sdague: but clients and servers are independent (and separated by a network, almost by definition). so why does the server-side dependency matter to the client? eg swift doesn't use requests but swiftclient does, and that's ok | |
08:54 sdague: notmyname: because glance stable/master needs to use swift | |
08:55 sdague: swiftclient | |
08:55 sdague: the dependencies are on the client consumers, which are the other openstack services, so a if a glance stable/havana can't import swiftclient master, that's no good | |
09:00 notmyname: sdague: I don't agree with that logic, but thanks for the explanation. I'll tell the patch submitter that he also needs to patch the stable branch of the requirements repo | |
09:00 sdague: I'm rechecking it to see if it takes now | |
09:02 sdague: notmyname: ok. if you have an alternative proposal about how we ensure we can run glance stable/havana with swiftclient master, it's something we could put back on the drawing board. This is where we got to after having clients completely wedge the gate by dragging in incompatible requirements. | |
09:03 sdague: before we did that the install process would often install / uninstall keystone client 4 - 6 times during a devstack setup at different versions | |
09:04 sdague: as an example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment