Skip to content

Instantly share code, notes, and snippets.

@ardalis
Created January 17, 2012 20:34
Show Gist options
  • Save ardalis/1628720 to your computer and use it in GitHub Desktop.
Save ardalis/1628720 to your computer and use it in GitHub Desktop.
What's wrong with this?
if (ChkRemeberMe.Checked)
{
var hcEmail = new HttpCookie("AcmeEmail", Convert.ToString(TxtUserName.Text.Trim()));
var hcPassword = new HttpCookie("AcmePassword", Convert.ToString(TxtPassword.Text.Trim()));
hcEmail.Expires = DateTime.Now.AddDays(30);
hcPassword.Expires = DateTime.Now.AddDays(30);
Response.Cookies.Add(hcEmail);
Response.Cookies.Add(hcPassword);
}
@bsimser
Copy link

bsimser commented Jan 17, 2012

I would agree that's the main thing. I would just store the hash. There should also be checks to ensure that hcEmail and hcPassword are not null but that's probably not the point of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment