Skip to content

Instantly share code, notes, and snippets.

@arianvp

arianvp/review.md

Last active July 7, 2020 11:51
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save arianvp/59038f1073ee6af7a85ddde3980c13b5 to your computer and use it in GitHub Desktop.
Save arianvp/59038f1073ee6af7a85ddde3980c13b5 to your computer and use it in GitHub Desktop.
Download ZIP
publiccode review
Raw
review.md
  • Code in the open - Development is done on a closed platform (Azure) that is periodically synced with GitHub. Some teams do work primarily on GitHub.
  • Bundle policy and source code - No. there are some requirement documents; but they're not in editable form, and are not the policy itself
  • Create reusable and portable code - Impossible due to dependence on GAEN which violates the "The codebase MUST be independent from any secret, undisclosed, proprietary or non-open licensed code or services for execution and understanding." requirement
  • Welcome contributions
  • Maintain version control
  • Require review of contributions
  • Document your objectives - . There is a requirements document but it's uneditable
  • Document your code. Partially. there are architecture documentation, but no code docs.
  • Use plain English
  • Use open standards
  • Use continuous integration - It is claimed that this exists but it is not accessible for contributors. Outside contributions don't go through the CI pipeline and results are not visible
  • Publish with an open license
  • Use a coherent style
  • Pay attention to codebase maturity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment