Skip to content

Instantly share code, notes, and snippets.

@ashcrow
Created November 28, 2016 12:44
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save ashcrow/e7b033070d74b8d2eb973fb14ee0ac9d to your computer and use it in GitHub Desktop.
Save ashcrow/e7b033070d74b8d2eb973fb14ee0ac9d to your computer and use it in GitHub Desktop.
07:31:43 ashcrow | gbraad / portdirect_away / mbarnes: Morning/Afternoon/Evening. Let's begin!
07:31:55 ashcrow | Agenga: https://gist.github.com/ashcrow/ca15174334044c0be77591fb1f330617
07:32:07 ashcrow | Agengad Item 1: Presentations
07:32:20 ashcrow | None this week.
07:32:28 ashcrow | Agenda Item 2: Open PR Discussions
07:32:54 ashcrow | There are 3 open PRs. All of which look to be ready for review.
07:33:01 ashcrow | Use appropriate to_dict() or to_json() calls
07:33:15 ashcrow | Drop 'secure' arg from model methods (2 PRs for this)
07:33:24 mbarnes | yeah, those are all just cleanups from last week. all pretty simple.
07:33:30 ashcrow | excellent
07:33:36 ashcrow | I'll take a look this morning
07:34:33 ashcrow | Last week was a US holiday week. I was away for most of it myself and mbarnes was out for at least 2 days. However, we all still got a decent amount of work in!
07:34:35 ashcrow | commissaire: 4 merged
07:34:35 ashcrow | commissaire-http: 2 merged
07:34:35 ashcrow | commissaire-service: 2 merged
07:34:59 ashcrow | The big one being in commissaire-service. The clusterexec service has been merged.
07:35:37 ashcrow | gbraad / mbarnes: Any questions on open or merged prs from the last 2 weeks?
07:36:11 mbarnes | none from me
07:36:24 mbarnes | is gbraad awake?
07:36:42 ashcrow | mbarnes: He may have fallen asleep early :-P
07:37:05 ashcrow | Moving along
07:37:21 ashcrow | Agenda Item 3: Open Issues
07:37:30 ashcrow | There are 2 new issues opened since last we spoke
07:37:38 ashcrow | Decrese Complexity: https://github.com/projectatomic/commissaire-service/issues/30
07:37:49 ashcrow | Remove/update default bus-uri from services: https://github.com/projectatomic/commissaire-service/issues/28
07:38:34 ashcrow | The fist being related to the clusterexec work. Some of the MVP port is kept in mainly one function which blows complexity metrics out of the water.
07:38:53 mbarnes | I can tackle that
07:39:06 ashcrow | The second one is a reminder to remove/update the bus-uri default before the next official release
07:39:09 ashcrow | mbarnes: perfect
07:39:56 ashcrow | The rest of the issues were brought up last meeting and are low priority or already being worked on.
07:40:25 ashcrow | Agenda Item 4: Open Floor
07:40:44 ashcrow | Reminder: Next Meeting: 2016-12-12
07:40:59 mbarnes | I'm going to be mostly writing commissaire-service tests this week. should I open an issue about that for tracking?
07:41:15 mbarnes | kinda overlaps Trello, but open issues are more community-friendly I think
07:41:40 ashcrow | mbarnes: I think it's a good idea to do so, yes. It's not required, but it is easier for community members to see what is going on.
07:41:44 ashcrow | I'm trying to do the same myself
07:42:03 ashcrow | and use the linking in trello with the github issue
07:43:16 ashcrow | Thanks for attending todays meeting. See you all on 12-12!
07:43:19 ashcrow | End of meeting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment