Broken use of REQUIRES_NEW

req-new-broken.java

@Singleton
public class Importer {

  @EJBContext
  private EJBContext ctx;
  private ConcurrentLinkedQueue queue = new ...
  private AtomicBoolean isRunning = false;
 
  public void add(ImportItem itm) {
      queue.offer(item);
      if(!isRunning) start();
  }

  public void start() {
      while(!queue.isEmpty())
          this.importItem(queue.poll());
  }

    @TransactionAttribute(REQUIRES_NEW)
    public void importItem() {
        try {
            // do some fancy xml stuff
        } catch (Exception ex) {
            ctx.setRollbackOnly();
        }
    }
}

req-new-easy-fix.java

@EJB
private Importer thisBean;
public void start()
{
    while(!queue.isEmpty())
        thisBean.importItem(queue.poll());
}