Navigation Menu

Skip to content

Instantly share code, notes, and snippets.

@atimb
Last active May 16, 2023 12:20
Show Gist options
  • Star 13 You must be signed in to star a gist
  • Fork 1 You must be signed in to fork a gist
  • Save atimb/2963672 to your computer and use it in GitHub Desktop.
Save atimb/2963672 to your computer and use it in GitHub Desktop.
Real keep-alive HTTP agent for node.js
/**
* Real keep-alive HTTP agent
*
* ------------=================----------------
* UPDATE: There are more proper implementations for this problem, distributed as
* npm modules like this one: https://github.com/TBEDP/agentkeepalive
* ------------=================----------------
*
* The http module's agent implementation only keeps the underlying TCP
* connection alive, if there are pending requests towards that endpoint in the agent
* queue. (Not bug, but "feature": https://github.com/joyent/node/issues/1958)
*
* You might be in a situation, where you send requests one-by-one, so closing
* the connection every time simply does not make sense, since you know you will
* send the next one in a matter of milliseconds.
*
* This module provides a modified Agent implementation that does exactly that.
*
* TODO: The implementation lacks connection closing: there is no timeout for terminating
* the connections.
*
* http://atimb.me
*/
var util = require('util');
var EventEmitter = require('events').EventEmitter;
var net = require('net');
var Agent = function(options) {
var self = this;
self.options = options || {};
self.requests = {};
self.sockets = {};
self.unusedSockets = {};
self.maxSockets = self.options.maxSockets || Agent.defaultMaxSockets;
self.on('free', function(socket, host, port) {
var name = host + ':' + port;
if (self.requests[name] && self.requests[name].length) {
self.requests[name].shift().onSocket(socket);
} else {
// If there are no pending requests just destroy the
// socket and it will get removed from the pool. This
// gets us out of timeout issues and allows us to
// default to Connection:keep-alive.
//socket.destroy();
if (!self.unusedSockets[name]) {
self.unusedSockets[name] = [];
}
self.unusedSockets[name].push(socket);
}
});
self.createConnection = net.createConnection;
}
util.inherits(Agent, EventEmitter);
Agent.defaultMaxSockets = 5;
Agent.prototype.defaultPort = 80;
Agent.prototype.addRequest = function(req, host, port) {
var name = host + ':' + port;
if (this.unusedSockets[name] && this.unusedSockets[name].length) {
req.onSocket(this.unusedSockets[name].shift());
//if (!this.unusedSockets[name].length) {
// delete this.unusedSockets[name];
//}
return;
}
if (!this.sockets[name]) {
this.sockets[name] = [];
}
if (this.sockets[name].length < this.maxSockets) {
// If we are under maxSockets create a new one.
req.onSocket(this.createSocket(name, host, port));
} else {
// We are over limit so we'll add it to the queue.
if (!this.requests[name]) {
this.requests[name] = [];
}
this.requests[name].push(req);
}
};
Agent.prototype.createSocket = function(name, host, port) {
var self = this;
var s = self.createConnection(port, host, self.options);
if (!self.sockets[name]) {
self.sockets[name] = [];
}
this.sockets[name].push(s);
var onFree = function() {
self.emit('free', s, host, port);
}
s.on('free', onFree);
var onClose = function(err) {
// This is the only place where sockets get removed from the Agent.
// If you want to remove a socket from the pool, just close it.
// All socket errors end in a close event anyway.
self.removeSocket(s, name, host, port);
}
s.on('close', onClose);
var onRemove = function() {
// We need this function for cases like HTTP "upgrade"
// (defined by WebSockets) where we need to remove a socket from the pool
// because it'll be locked up indefinitely
self.removeSocket(s, name, host, port);
s.removeListener('close', onClose);
s.removeListener('free', onFree);
s.removeListener('agentRemove', onRemove);
}
s.on('agentRemove', onRemove);
return s;
};
Agent.prototype.removeSocket = function(s, name, host, port) {
if (this.sockets[name]) {
var index = this.sockets[name].indexOf(s);
if (index !== -1) {
this.sockets[name].splice(index, 1);
}
} else if (this.sockets[name] && this.sockets[name].length === 0) {
// don't leak
delete this.sockets[name];
delete this.requests[name];
}
if (this.requests[name] && this.requests[name].length) {
// If we have pending requests and a socket gets closed a new one
// needs to be created to take over in the pool for the one that closed.
this.createSocket(name, host, port).emit('free');
}
};
module.exports = Agent;
/**
* Use it like this:
*/
var http = require('http');
var keepAliveAgent = require('./agent.js');
var agent = new keepAliveAgent({ maxSockets: 100 }); // Optionally define more parallel sockets
var options = {
agent: agent,
hostname: 'example.com',
path: '/path'
};
http.get(options);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment