awolfe76

From https://github.com/Conexon/signup/pull/107/files...

Option 1

That currenty uses all inline, logic and render, like this

<dd className="mt-1 text-sm leading-5 text-gray-900">
  {phy_add && state
    ? `${phy_add}, ${state}`

awolfe76

Tests

• clean up our tests
  • https://twitter.com/thejameskyle/status/954906997169664000
• a lot of tests (checking css or elements) would be better off as jest snapshots
• possibly move to enzyme

Performance

• do some analysis
• https://reactjs.org/docs/perf.html
• https://github.com/nitin42/react-perf-devtool

awolfe76

{
  "institutions":
  [
     {
       "id": "0",
       "name": "Bank 0",
       "domains": ["test@bank0.com"],
       "externalIds":[
         {
           "value": "1234",

awolfe76

[36mapi_1          | [2017-08-23 14:30:10,941][INFO ][hmda-akka.actor.default-dispatcher-18] Actor stopped at akka://hmda/user/supervisor/filings-6999998
api_1          | [2017-08-23 14:30:10,942][INFO ][hmda-akka.actor.default-dispatcher-18] Actor stopped at akka://hmda/user/supervisor/submissions-6999998-2017
api_1          | [2017-08-23 14:30:10,944][INFO ][hmda-akka.actor.default-dispatcher-18] actor akka://hmda/user/supervisor/filings-6999998 terminated
api_1          | [2017-08-23 14:30:10,944][INFO ][hmda-akka.actor.default-dispatcher-18] actor akka://hmda/user/supervisor/submissions-6999998-2017 terminated
api_1          | [2017-08-23 15:01:14,070][INFO ][hmda-akka.actor.default-dispatcher-4] Actor started at akka://hmda/user/supervisor/filings-6999998
api_1          | [2017-08-23 15:01:14,071][INFO ][hmda-akka.actor.default-dispatcher-4] Thread name for actor: hmda-persistence-dispatcher-6805
api_1          | [2017-08-23 15:01:14,075][INFO ][h

awolfe76

Attaching to hmdaplatform_api_1
api_1          | [DEBUG] [08/16/2017 13:31:45.659] [main] [EventStream] StandardOutLogger started
api_1          | [2017-08-16 13:31:48,174][INFO ][hmda-akka.actor.default-dispatcher-4] Slf4jLogger started
api_1          | [DEBUG] [08/16/2017 13:31:48.227] [main] [EventStream(akka://hmda)] logger log1-Slf4jLogger started
api_1          | [DEBUG] [08/16/2017 13:31:48.244] [main] [EventStream(akka://hmda)] Default Loggers started
api_1          | [2017-08-16 13:31:49,330][INFO ][hmda-akka.actor.default-dispatcher-4] Starting remoting
api_1          | [2017-08-16 13:31:50,490][INFO ][hmda-akka.actor.default-dispatcher-4] Remoting started; listening on addresses :[akka.tcp://hmda@127.0.0.1:34914]
api_1          | [2017-08-16 13:31:50,617][INFO ][hmda-akka.actor.default-dispatcher-4] Cluster Node [akka.tcp://hmda@127.0.0.1:34914] - Starting up...
api_1          | [2017-08-16 13:31:51,091][INFO ][hmda-akka.actor.

awolfe76

Attaching to hmdaplatform_api_1
api_1          | [DEBUG] [08/15/2017 20:16:07.119] [main] [EventStream] StandardOutLogger started
api_1          | [2017-08-15 20:16:09,069][INFO ][hmda-akka.actor.default-dispatcher-4] Slf4jLogger started
api_1          | [DEBUG] [08/15/2017 20:16:09.129] [main] [EventStream(akka://hmda)] logger log1-Slf4jLogger started
api_1          | [DEBUG] [08/15/2017 20:16:09.148] [main] [EventStream(akka://hmda)] Default Loggers started
api_1          | [2017-08-15 20:16:10,378][INFO ][hmda-akka.actor.default-dispatcher-4] Starting remoting
api_1          | [2017-08-15 20:16:11,551][INFO ][hmda-akka.actor.default-dispatcher-4] Remoting started; listening on addresses :[akka.tcp://hmda@127.0.0.1:43054]
api_1          | [2017-08-15 20:16:11,678][INFO ][hmda-akka.actor.default-dispatcher-4] Cluster Node [akka.tcp://hmda@127.0.0.1:43054] - Starting up...
api_1          | [2017-08-15 20:16:12,210][INFO ][hmda-akka.actor.

awolfe76

Just as a recap to help me put this all together, and to add some of my thoughts, suggestions, and questions. This comment ignores responses for now, I just want to make sure we all agree on the API endpoints.

GET /institutions

• list all institutions for an account

GET /institutions/{id}

• details about an institution
• possible slug version with `/{id}-{bank-name}

awolfe76

{
  "macro": [
    {
      "id": 1,
      "desc": "Here is a desc",
      "justification": "",
      "verified": false,
      "calculation": // will need to know the calculation performed and the values used
    },
    {

awolfe76

{
  "validity": [
    {
      "loanNumber": "12345",
      "edits": [
        {
          "id": 1,
          "desc": "Here is a desc",
          "field": "Year",
          "valueSubmitted": "1967"

awolfe76

{
  "syntactical": [
    {
      "loanNumber": "12345",
      "edits": [
        {
          "id": 1,
          "desc": "Here is a desc",
          "field": "Year",
          "valueSubmitted": "1967"