Skip to content

Instantly share code, notes, and snippets.

@axilleas

axilleas/rubocop_after Secret

Created June 17, 2014 16:52
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save axilleas/b65a909a5d0b73fcb2a8 to your computer and use it in GitHub Desktop.
Save axilleas/b65a909a5d0b73fcb2a8 to your computer and use it in GitHub Desktop.
Download ZIP
Rubocop Violations
Raw
rubocop_after
Inspecting 105 files
.....................W.......CC.CC...CCCCCCCCCCCCCCCWCCCCW...CCCCCCCCCCCCCCCCCCCCCCCCCC.............C....
Offenses:
spec/rails_helper.rb:8:1: W: Do not suppress exceptions.
rescue LoadError
^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:93:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Updating #{name} failed due to #{e}"
^^^^
app/models/fedora_rpm.rb:81:25: C: Use next to skip iteration.
dependency_packages.each do |p|
^^^^
app/models/fedora_rpm.rb:92:24: C: Use next to skip iteration.
dependent_packages.each do |p|
^^^^
app/models/fedora_rpm.rb:106:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Importing #{name} commits"
^^^^
app/models/fedora_rpm.rb:130:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Importing #{name} spec info"
^^^^
app/models/fedora_rpm.rb:131:21: C: Use next to skip iteration.
FEDORA_VERSIONS.each do |version_title, version_git|
^^^^
app/models/fedora_rpm.rb:166:22: C: Use next to skip iteration.
fedora_user_list.each do |user|
^^^^
app/models/fedora_rpm.rb:181:26: C: Use next to skip iteration.
rpm_spec.split("\n").each do |line|
^^^^
app/models/fedora_rpm.rb:204:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Retrieving gem #{gem_name} data"
^^^^
app/models/fedora_rpm.rb:211:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Importing rpm #{name} bugs"
^^^^
app/models/fedora_rpm.rb:229:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Importing rpm #{name} builds"
^^^^
app/models/fedora_rpm.rb:278:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Updating #{name} failed due to #{e}"
^^^^
app/models/build.rb:13:1: C: Missing top-level class documentation comment.
class Build < ActiveRecord::Base
^^^^^
app/models/historical_gem.rb:13:1: C: Missing top-level class documentation comment.
class HistoricalGem < ActiveRecord::Base
^^^^^
app/helpers/application_helper.rb:1:1: C: Missing top-level module documentation comment.
module ApplicationHelper
^^^^^^
app/helpers/rpmcomments_helper.rb:1:1: C: Missing top-level module documentation comment.
module RpmcommentsHelper
^^^^^^
app/helpers/static_pages_helper.rb:1:1: C: Missing top-level module documentation comment.
module StaticPagesHelper
^^^^^^
app/helpers/fedorarpms_helper.rb:1:1: C: Missing top-level module documentation comment.
module FedorarpmsHelper
^^^^^^
app/helpers/home_helper.rb:1:1: C: Missing top-level module documentation comment.
module HomeHelper
^^^^^^
app/helpers/searches_helper.rb:1:1: C: Missing top-level module documentation comment.
module SearchesHelper
^^^^^^
app/helpers/gemcomments_helper.rb:1:1: C: Missing top-level module documentation comment.
module GemcommentsHelper
^^^^^^
app/helpers/builds_helper.rb:1:1: C: Missing top-level module documentation comment.
module BuildsHelper
^^^^^^
app/helpers/errors_helper.rb:1:1: C: Missing top-level module documentation comment.
module ErrorsHelper
^^^^^^
app/helpers/rubygems_helper.rb:1:1: C: Missing top-level module documentation comment.
module RubygemsHelper
^^^^^^
app/helpers/stats_helper.rb:1:1: C: Missing top-level module documentation comment.
module StatsHelper
^^^^^^
app/controllers/fedorarpms_controller.rb:1:1: C: Missing top-level class documentation comment.
class FedorarpmsController < ApplicationController
^^^^^
app/controllers/fedorarpms_controller.rb:72:5: C: Avoid multi-line ?: (the ternary operator); use if/unless instead.
%w(name commits last_commit_date fedora_user).include?(params[:sort]) ?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:1:1: C: Missing top-level class documentation comment.
class ApplicationController < ActionController::Base
^^^^^
app/controllers/searches_controller.rb:3:1: C: Missing top-level class documentation comment.
class SearchesController < ApplicationController
^^^^^
app/controllers/searches_controller.rb:9:5: C: Use a guard clause instead of wrapping the code inside a conditional expression.
if @results == []
^^
app/controllers/home_controller.rb:1:1: C: Missing top-level class documentation comment.
class HomeController < ApplicationController
^^^^^
app/controllers/stats_controller.rb:1:1: C: Missing top-level class documentation comment.
class StatsController < ApplicationController
^^^^^
app/controllers/stats_controller.rb:48:5: C: Use a guard clause instead of wrapping the code inside a conditional expression.
if params[:gemfile]
^^
app/controllers/stats_controller.rb:76:13: W: Do not suppress exceptions.
rescue Versionomy::Errors::ParseError
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:84:15: C: Use next to skip iteration.
lines.each do |line|
^^^^
app/controllers/stats_controller.rb:90:13: W: Do not suppress exceptions.
rescue Versionomy::Errors::ParseError
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:97:20: C: Use next to skip iteration.
dependencies.each do |dep|
^^^^
app/controllers/stats_controller.rb:106:30: C: Use next to skip iteration.
rpm.rpm_versions.each do |rv|
^^^^
app/controllers/builds_controller.rb:1:1: C: Missing top-level class documentation comment.
class BuildsController < ApplicationController
^^^^^
app/controllers/builds_controller.rb:11:30: C: Use next to skip iteration.
p[:gem].dependencies.each do |dep|
^^^^
app/controllers/static_pages_controller.rb:1:1: C: Missing top-level class documentation comment.
class StaticPagesController < ApplicationController
^^^^^
app/controllers/rubygems_controller.rb:1:1: C: Missing top-level class documentation comment.
class RubygemsController < ApplicationController
^^^^^
app/controllers/errors_controller.rb:1:1: C: Missing top-level class documentation comment.
class ErrorsController < ApplicationController
^^^^^
Rakefile:14:1: W: Do not suppress exceptions.
rescue LoadError
^^^^^^^^^^^^^^^^
db/migrate/20120716155426_create_rpm_versions.rb:1:1: C: Missing top-level class documentation comment.
class CreateRpmVersions < ActiveRecord::Migration
^^^^^
db/migrate/20120723053651_add_source_uri_column_to_ruby_gem.rb:1:1: C: Missing top-level class documentation comment.
class AddSourceUriColumnToRubyGem < ActiveRecord::Migration
^^^^^
db/migrate/20120724100214_create_dependencies.rb:1:1: C: Missing top-level class documentation comment.
class CreateDependencies < ActiveRecord::Migration
^^^^^
db/migrate/20120712122611_add_downloads_to_ruby_gems.rb:1:1: C: Missing top-level class documentation comment.
class AddDownloadsToRubyGems < ActiveRecord::Migration
^^^^^
db/migrate/20130312132803_add_is_open_to_bugs.rb:1:1: C: Missing top-level class documentation comment.
class AddIsOpenToBugs < ActiveRecord::Migration
^^^^^
db/migrate/20120618141450_modify_fedora_rpm.rb:1:1: C: Missing top-level class documentation comment.
class ModifyFedoraRpm < ActiveRecord::Migration
^^^^^
db/migrate/20121212173207_create_historical_gems.rb:1:1: C: Missing top-level class documentation comment.
class CreateHistoricalGems < ActiveRecord::Migration
^^^^^
db/migrate/20120713162923_add_commits_to_fedora_rpms.rb:1:1: C: Missing top-level class documentation comment.
class AddCommitsToFedoraRpms < ActiveRecord::Migration
^^^^^
db/migrate/20120619162832_add_reference_to_ruby_gem.rb:1:1: C: Missing top-level class documentation comment.
class AddReferenceToRubyGem < ActiveRecord::Migration
^^^^^
db/migrate/20120614134039_remove_last_patch_column_from_fedora_rpm.rb:1:1: C: Missing top-level class documentation comment.
class RemoveLastPatchColumnFromFedoraRpm < ActiveRecord::Migration
^^^^^
db/migrate/20140519095419_change_fedora_rpm_description_from_string_to_text.rb:1:1: C: Missing top-level class documentation comment.
class ChangeFedoraRpmDescriptionFromStringToText < ActiveRecord::Migration
^^^^^
db/migrate/20120724121813_set_dependent_not_null.rb:1:1: C: Missing top-level class documentation comment.
class SetDependentNotNull < ActiveRecord::Migration
^^^^^
db/migrate/20120904112311_add_bugs.rb:1:1: C: Missing top-level class documentation comment.
class AddBugs < ActiveRecord::Migration
^^^^^
db/migrate/20120606144830_create_fedora_rpms.rb:1:1: C: Missing top-level class documentation comment.
class CreateFedoraRpms < ActiveRecord::Migration
^^^^^
db/migrate/20120724121403_remove_name_column_from_dependencies.rb:1:1: C: Missing top-level class documentation comment.
class RemoveNameColumnFromDependencies < ActiveRecord::Migration
^^^^^
db/migrate/20130103111220_add_more_to_fedora_rpms.rb:1:1: C: Missing top-level class documentation comment.
class AddMoreToFedoraRpms < ActiveRecord::Migration
^^^^^
db/migrate/20120620123237_remove_redundant_ref_in_ruby_gem.rb:1:1: C: Missing top-level class documentation comment.
class RemoveRedundantRefInRubyGem < ActiveRecord::Migration
^^^^^
db/migrate/20120606144817_create_ruby_gems.rb:1:1: C: Missing top-level class documentation comment.
class CreateRubyGems < ActiveRecord::Migration
^^^^^
db/migrate/20140115094251_add_ruby_gem_versions.rb:1:1: C: Missing top-level class documentation comment.
class AddRubyGemVersions < ActiveRecord::Migration
^^^^^
db/migrate/20121015133744_mark_patched_rpms.rb:1:1: C: Missing top-level class documentation comment.
class MarkPatchedRpms < ActiveRecord::Migration
^^^^^
db/migrate/20121208152321_add_last_updated_to_bugs.rb:1:1: C: Missing top-level class documentation comment.
class AddLastUpdatedToBugs < ActiveRecord::Migration
^^^^^
db/migrate/20121208152321_add_last_updated_to_bugs.rb:1:1: C: Carriage return character detected.
class AddLastUpdatedToBugs < ActiveRecord::Migration
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
db/migrate/20121203163133_add_fedora_user_column_to_fedora_rpms.rb:1:1: C: Missing top-level class documentation comment.
class AddFedoraUserColumnToFedoraRpms < ActiveRecord::Migration
^^^^^
db/migrate/20121015122648_add_builds.rb:1:1: C: Missing top-level class documentation comment.
class AddBuilds < ActiveRecord::Migration
^^^^^
db/migrate/20120613142106_alter_fedora_rpm_table_schema.rb:1:1: C: Missing top-level class documentation comment.
class AlterFedoraRpmTableSchema < ActiveRecord::Migration
^^^^^
db/migrate/20120724124409_add_dependency_column.rb:1:1: C: Missing top-level class documentation comment.
class AddDependencyColumn < ActiveRecord::Migration
^^^^^
config/application.rb:10:3: C: Missing top-level class documentation comment.
class Application < Rails::Application
^^^^^
config/initializers/jazz_hands.rb:1:1: C: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
if defined?(JazzHands)
^^
105 files inspected, 73 offenses detected
Raw
rubocop_before
Inspecting 105 files
C.CCCC..C...WCCCCC...CW.CCC.CWWCCCCCCCCCCCCCCCCCCWWCWWCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCCC..C.C...CCCCCC.
Offenses:
features/support/env.rb:4:81: C: Line is too long. [84/80]
# instead of editing this one. Cucumber will automatically load all features/**/*.rb
^^^^
features/support/env.rb:16:81: C: Line is too long. [82/80]
# your application behaves in the production environment, where an error page will
^^
features/support/env.rb:20:81: C: Line is too long. [89/80]
# exceptions and display an error page (just like when the app is running in production).
^^^^^^^^^
features/support/env.rb:32:81: C: Line is too long. [88/80]
# For some databases (like MongoDB and CouchDB) you may need to use :truncation instead.
^^^^^^^^
features/support/env.rb:36:9: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
raise "You need to add database_cleaner to your Gemfile (in the :test group) if you wish to use it."
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
features/support/env.rb:36:81: C: Line is too long. [102/80]
raise "You need to add database_cleaner to your Gemfile (in the :test group) if you wish to use it."
^^^^^^^^^^^^^^^^^^^^^^
features/support/env.rb:39:81: C: Line is too long. [112/80]
# You may also want to configure DatabaseCleaner to use different strategies for certain features and scenarios.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
features/support/env.rb:49:81: C: Line is too long. [83/80]
# Before('~@no-txn', '~@selenium', '~@culerity', '~@celerity', '~@javascript') do
^^^
features/support/env.rb:56:81: C: Line is too long. [113/80]
# See https://github.com/cucumber/cucumber-rails/blob/master/features/choose_javascript_database_strategy.feature
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
features/support/env.rb:58:1: C: 1 trailing blank lines detected.
spec/views/errors/error_404.html.haml_spec.rb:3:10: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
describe "errors/error_404.html.haml" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/views/errors/error_500.html.haml_spec.rb:3:10: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
describe "errors/error_500.html.haml" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/views/static_pages/successes.html.haml_spec.rb:3:10: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
describe "static_pages/successes.html.haml" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/views/static_pages/contribute.html.haml_spec.rb:3:10: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
describe "static_pages/contribute.html.haml" do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/factories/bugs.rb:20:13: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
b.bz_id "12345"
^^^^^^^
spec/models/bug_spec.rb:19:6: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
it "has valid factory" do
^^^^^^^^^^^^^^^^^^^
spec/models/bug_spec.rb:25:21: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
@bugzilla_url = "https://bugzilla.redhat.com/show_bug.cgi?id="
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/bug_spec.rb:28:6: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
it "has valid bugzilla url" do
^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/bug_spec.rb:29:31: W: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the / if it should be a division.
expect(@bug.url).to match /#{Regexp.quote(@bugzilla_url)}\d+/
^
spec/models/bug_spec.rb:32:6: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
it "bug is a Review Request" do
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/models/bug_spec.rb:37:6: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
it "bug is open" do
^^^^^^^^^^^^^
spec/models/bug_spec.rb:38:3: C: Use 2 (not 1) spaces for indentation.
@bug.is_open = true
^
spec/models/bug_spec.rb:42:6: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
it "bug is closed" do
^^^^^^^^^^^^^^^
spec/models/bug_spec.rb:43:3: C: Use 2 (not 1) spaces for indentation.
@bug.is_open = false
^
spec/models/bug_spec.rb:48:1: C: 1 trailing blank lines detected.
spec/models/rpm_version_spec.rb:16:28: C: Use the new Ruby 1.9 hash syntax.
RSpec.describe RpmVersion, :type => :model do
^^^^^^^^
spec/models/ruby_gem_spec.rb:19:25: C: Use the new Ruby 1.9 hash syntax.
RSpec.describe RubyGem, :type => :model do
^^^^^^^^
spec/models/dependency_spec.rb:17:28: C: Use the new Ruby 1.9 hash syntax.
RSpec.describe Dependency, :type => :model do
^^^^^^^^
spec/models/fedora_rpm_spec.rb:25:27: C: Use the new Ruby 1.9 hash syntax.
RSpec.describe FedoraRpm, :type => :model do
^^^^^^^^
spec/models/build_spec.rb:15:23: C: Use the new Ruby 1.9 hash syntax.
RSpec.describe Build, :type => :model do
^^^^^^^^
spec/rails_helper.rb:2:5: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
ENV["RAILS_ENV"] ||= 'test'
^^^^^^^^^^^
spec/rails_helper.rb:3:26: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
require File.expand_path("../../config/environment", __FILE__)
^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/rails_helper.rb:8:21: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Dir[Rails.root.join("spec/support/**/*.rb")].each {|f| require f}
^^^^^^^^^^^^^^^^^^^^^^
spec/rails_helper.rb:8:51: C: Space between { and | missing.
Dir[Rails.root.join("spec/support/**/*.rb")].each {|f| require f}
^^
spec/rails_helper.rb:8:65: C: Space missing inside }.
Dir[Rails.root.join("spec/support/**/*.rb")].each {|f| require f}
^
spec/spec_helper.rb:1:81: C: Line is too long. [92/80]
# This file was generated by the `rails generate rspec:install` command. Conventionally, all
^^^^^^^^^^^^
spec/spec_helper.rb:3:81: C: Line is too long. [84/80]
# The generated `.rspec` file contains `--require spec_helper` which will cause this
^^^^
spec/spec_helper.rb:4:81: C: Line is too long. [81/80]
# file to always be loaded, without a need to explicitly require it in any files.
^
spec/spec_helper.rb:17:21: W: Unused block argument - config. You can omit the argument if you don't care about it.
RSpec.configure do |config|
^^^^^^
spec/spec_helper.rb:20:1: C: Do not use block comments.
=begin
^^^^^^
spec/spec_helper.rb:70:81: C: Line is too long. [85/80]
# - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
^^^^^
spec/support/database_cleaner.rb:1:81: C: Line is too long. [105/80]
# http://devblog.avdi.org/2012/08/31/configuring-database_cleaner-with-rails-rspec-capybara-and-selenium/
^^^^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/errors_controller_spec.rb:6:8: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
it "returns http success" do
^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/errors_controller_spec.rb:13:8: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
it "returns http success" do
^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/static_pages_controller_spec.rb:6:8: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
it "returns http success" do
^^^^^^^^^^^^^^^^^^^^^^
spec/controllers/static_pages_controller_spec.rb:13:8: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
it "returns http success" do
^^^^^^^^^^^^^^^^^^^^^^
spec/requests/static_pages_spec.rb:3:10: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
describe "Static Pages" do
^^^^^^^^^^^^^^
spec/requests/static_pages_spec.rb:5:12: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
describe "Success Stories" do
^^^^^^^^^^^^^^^^^
spec/requests/static_pages_spec.rb:8:42: C: Use the new Ruby 1.9 hash syntax.
page.should have_selector('title', :text => 'Success Stories')
^^^^^^^^
spec/requests/static_pages_spec.rb:16:12: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
describe "Contribute" do
^^^^^^^^^^^^
spec/requests/static_pages_spec.rb:19:42: C: Use the new Ruby 1.9 hash syntax.
page.should have_selector('title', :text => 'Contribute')
^^^^^^^^
app/models/ruby_gem.rb:19:1: C: Class definition is too long. [133/100]
class RubyGem < ActiveRecord::Base
^^^^^
app/models/ruby_gem.rb:19:1: C: Missing top-level class documentation comment.
class RubyGem < ActiveRecord::Base
^^^^^
app/models/ruby_gem.rb:20:1: C: Extra empty line detected at body beginning.
app/models/ruby_gem.rb:21:24: C: Use the new Ruby 1.9 hash syntax.
has_one :fedora_rpm, :dependent => :destroy
^^^^^^^^^^^^^
app/models/ruby_gem.rb:22:59: C: Use the new Ruby 1.9 hash syntax.
has_many :dependencies, -> { order 'created_at desc' }, :as => :package,
^^^^^^
app/models/ruby_gem.rb:23:12: C: Align the elements of a hash literal if they span more than one line.
:dependent => :destroy
^^^^^^^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:23:12: C: Use the new Ruby 1.9 hash syntax.
:dependent => :destroy
^^^^^^^^^^^^^
app/models/ruby_gem.rb:24:30: C: Use the new Ruby 1.9 hash syntax.
has_many :historical_gems, :foreign_key => :gem_id
^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:25:27: C: Use the new Ruby 1.9 hash syntax.
has_many :gem_versions, :dependent => :destroy
^^^^^^^^^^^^^
app/models/ruby_gem.rb:43:5: C: Use ! instead of not.
not metadata.is_a?(String)
^^^
app/models/ruby_gem.rb:46:3: C: Method has too many lines. [17/10]
def retrieve_metadata
^^^
app/models/ruby_gem.rb:57:5: C: Redundant self detected.
self.dependencies.clear
^^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:70:29: C: Redundant self detected.
rpm_name = 'rubygem-' + self.name
^^^^^^^^^
app/models/ruby_gem.rb:72:32: C: Redundant self detected.
self.has_rpm = true unless self.fedora_rpm.nil?
^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:76:5: C: Redundant self detected.
self.gem_versions.clear
^^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:77:30: C: Redundant self detected.
versions = Gems.versions self.name
^^^^^^^^^
app/models/ruby_gem.rb:80:7: C: Redundant self detected.
self.gem_versions << ver
^^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:90:3: W: Avoid rescuing the Exception class.
rescue Exception => e
^^^^^^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:91:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Updating #{name} failed due to #{e.to_s}"
^^^^
app/models/ruby_gem.rb:91:46: W: Redundant use of Object#to_s in interpolation.
puts "Updating #{name} failed due to #{e.to_s}"
^^^^
app/models/ruby_gem.rb:97:31: C: Space missing after comma.
s = search.gsub(/rubygem-/,'')
^
app/models/ruby_gem.rb:98:10: C: Prefer the use of the nil? predicate.
if s == nil || s.blank?
^^
app/models/ruby_gem.rb:101:7: C: Redundant self detected.
self.where('name LIKE ?', s.strip)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:106:5: C: Redundant self detected.
self.name
^^^^^^^^^
app/models/ruby_gem.rb:109:7: C: Rename has_rpm? to rpm?.
def has_rpm?
^^^^^^^^
app/models/ruby_gem.rb:110:5: C: Redundant self detected.
self.has_rpm
^^^^^^^^^^^^
app/models/ruby_gem.rb:114:19: C: Redundant self detected.
return nil if self.fedora_rpm.nil?
^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:115:5: C: Redundant self detected.
self.fedora_rpm.version_for(fedora_version)
^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:119:21: C: Redundant self detected.
return false if self.fedora_rpm.nil?
^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:120:5: C: Redundant self detected.
self.fedora_rpm.upto_date?
^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:124:5: C: Redundant self detected.
self.dependencies.collect { |d|
^^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:124:23: C: Prefer map over collect.
self.dependencies.collect { |d|
^^^^^^^
app/models/ruby_gem.rb:124:31: C: Avoid using {...} for multi-line blocks.
self.dependencies.collect { |d|
^
app/models/ruby_gem.rb:130:33: C: Redundant self detected.
Dependency.where(dependent: self.name).to_a.collect { |d| d.package }
^^^^^^^^^
app/models/ruby_gem.rb:130:49: C: Prefer map over collect.
Dependency.where(dependent: self.name).to_a.collect { |d| d.package }
^^^^^^^
app/models/ruby_gem.rb:133:23: W: Unused method argument - version. If it's necessary, use _ or _version as an argument name to indicate that it won't be used. You can also write as uri_for_version(*) if you want the method to accept any arguments but don't care about them.
def uri_for_version(version)
^^^^^^^
app/models/ruby_gem.rb:134:33: C: Redundant self detected.
"http://rubygems.org/gems/#{self.name}-#{self.version}.gem"
^^^^^^^^^
app/models/ruby_gem.rb:137:29: W: Unused method argument - version. If it's necessary, use _ or _version as an argument name to indicate that it won't be used. You can also write as local_gem_for_version(*) if you want the method to accept any arguments but don't care about them.
def local_gem_for_version(version)
^^^^^^^
app/models/ruby_gem.rb:138:46: C: Redundant self detected.
"#{Rails.root}/public/rpmbuild/SOURCES/#{self.name}-#{self.version}.gem"
^^^^^^^^^
app/models/ruby_gem.rb:142:22: C: Redundant self detected.
download_version(self.version)
^^^^^^^^^^^^
app/models/ruby_gem.rb:147:20: W: File.exists? is deprecated in favor of File.exist?.
return if File.exists?(local_gem) # just return if version already downloaded
^^^^^^^
app/models/ruby_gem.rb:147:81: C: Line is too long. [81/80]
return if File.exists?(local_gem) # just return if version already downloaded
^
app/models/ruby_gem.rb:152:26: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
File.open(local_gem, "w") { |f|
^^^
app/models/ruby_gem.rb:152:31: C: Avoid using {...} for multi-line blocks.
File.open(local_gem, "w") { |f|
^
app/models/ruby_gem.rb:158:17: C: Redundant self detected.
version2rpm(self.version)
^^^^^^^^^^^^
app/models/ruby_gem.rb:162:81: C: Line is too long. [89/80]
rpm_spec_file = "#{Rails.root}/public/rpmbuild/SPECS/rubygem-#{name}-#{version}.spec"
^^^^^^^^^
app/models/ruby_gem.rb:163:34: W: File.exists? is deprecated in favor of File.exist?.
return rpm_spec_file if File.exists?(rpm_spec_file) # just return if already built
^^^^^^^
app/models/ruby_gem.rb:163:81: C: Line is too long. [86/80]
return rpm_spec_file if File.exists?(rpm_spec_file) # just return if already built
^^^^^^
app/models/ruby_gem.rb:166:30: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
File.open(rpm_spec_file, "w") { |f|
^^^
app/models/ruby_gem.rb:166:35: C: Avoid using {...} for multi-line blocks.
File.open(rpm_spec_file, "w") { |f|
^
app/models/ruby_gem.rb:173:8: C: Redundant self detected.
if self.description.blank?
^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:176:7: C: Redundant self detected.
self.description
^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:180:1: C: Indent access modifiers like private.
private
^^^^^^^
app/models/ruby_gem.rb:182:3: C: Use the new "sexy" validations (validates ...).
validates_uniqueness_of :name
^^^^^^^^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:183:3: C: Use the new "sexy" validations (validates ...).
validates_presence_of :name
^^^^^^^^^^^^^^^^^^^^^
app/models/ruby_gem.rb:184:1: C: Extra empty line detected at body end.
app/models/fedora_rpm.rb:28:1: C: Class definition is too long. [254/100]
class FedoraRpm < ActiveRecord::Base
^^^^^
app/models/fedora_rpm.rb:28:1: C: Missing top-level class documentation comment.
class FedoraRpm < ActiveRecord::Base
^^^^^
app/models/fedora_rpm.rb:30:21: C: Space inside { missing.
FEDORA_VERSIONS = {'rawhide' => 'master',
^
app/models/fedora_rpm.rb:32:42: C: Space inside } missing.
'Fedora 19' => 'f19'}
^
app/models/fedora_rpm.rb:35:27: C: Use the new Ruby 1.9 hash syntax.
has_many :rpm_versions, :dependent => :destroy
^^^^^^^^^^^^^
app/models/fedora_rpm.rb:36:46: C: Use the new Ruby 1.9 hash syntax.
has_many :bugs, -> { order 'bz_id desc' }, :dependent => :destroy
^^^^^^^^^^^^^
app/models/fedora_rpm.rb:37:51: C: Use the new Ruby 1.9 hash syntax.
has_many :builds, -> { order 'build_id desc' }, :dependent => :destroy
^^^^^^^^^^^^^
app/models/fedora_rpm.rb:38:37: C: Put one space between the method name and the first argument.
has_many :dependencies, -> { order 'created_at desc' }, :as => :package,
^^
app/models/fedora_rpm.rb:38:60: C: Use the new Ruby 1.9 hash syntax.
has_many :dependencies, -> { order 'created_at desc' }, :as => :package,
^^^^^^
app/models/fedora_rpm.rb:39:12: C: Align the elements of a hash literal if they span more than one line.
:dependent => :destroy
^^^^^^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:39:12: C: Use the new Ruby 1.9 hash syntax.
:dependent => :destroy
^^^^^^^^^^^^^
app/models/fedora_rpm.rb:43:5: C: Redundant self detected.
self.name
^^^^^^^^^
app/models/fedora_rpm.rb:47:5: C: Redundant self detected.
self.name.gsub(/rubygem-/, '')
^^^^^^^^^
app/models/fedora_rpm.rb:51:5: C: Redundant self detected.
self.rpm_versions.collect { |rv| rv.to_s }.join(', ')
^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:51:23: C: Prefer map over collect.
self.rpm_versions.collect { |rv| rv.to_s }.join(', ')
^^^^^^^
app/models/fedora_rpm.rb:55:10: C: Redundant self detected.
rv = self.rpm_versions.find { |rv| rv.fedora_version == fedora_version }
^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:55:36: W: Shadowing outer local variable - rv.
rv = self.rpm_versions.find { |rv| rv.fedora_version == fedora_version }
^^
app/models/fedora_rpm.rb:60:10: C: Redundant self detected.
rv = self.rpm_versions.find { |rv| rv.fedora_version == 'rawhide' }
^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:60:36: W: Shadowing outer local variable - rv.
rv = self.rpm_versions.find { |rv| rv.fedora_version == 'rawhide' }
^^
app/models/fedora_rpm.rb:64:60: C: Redundant self detected.
Versionomy.parse(rv.rpm_version) >= Versionomy.parse(self.ruby_gem.version)
^^^^^^^^^^^^^
app/models/fedora_rpm.rb:64:81: C: Line is too long. [81/80]
Versionomy.parse(rv.rpm_version) >= Versionomy.parse(self.ruby_gem.version)
^
app/models/fedora_rpm.rb:71:5: C: Redundant self detected.
self.rpm_versions.any? { |rv| rv.is_patched }
^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:74:33: C: Surrounding space missing in default value assignment.
def json_dependencies(packages=[])
^
app/models/fedora_rpm.rb:76:25: C: Use next to skip iteration.
dependency_packages.each { |p|
^^^^
app/models/fedora_rpm.rb:76:30: C: Avoid using {...} for multi-line blocks.
dependency_packages.each { |p|
^
app/models/fedora_rpm.rb:82:5: C: Space inside { missing.
{name: shortname, children: children}
^
app/models/fedora_rpm.rb:82:41: C: Space inside } missing.
{name: shortname, children: children}
^
app/models/fedora_rpm.rb:85:31: C: Surrounding space missing in default value assignment.
def json_dependents(packages=[])
^
app/models/fedora_rpm.rb:87:24: C: Use next to skip iteration.
dependent_packages.each do |p|
^^^^
app/models/fedora_rpm.rb:93:5: C: Space inside { missing.
{name: shortname, children: children}
^
app/models/fedora_rpm.rb:93:41: C: Space inside } missing.
{name: shortname, children: children}
^
app/models/fedora_rpm.rb:100:3: C: Method has too many lines. [15/10]
def retrieve_commits
^^^
app/models/fedora_rpm.rb:101:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Importing #{self.name} commits"
^^^^
app/models/fedora_rpm.rb:101:23: C: Redundant self detected.
puts "Importing #{self.name} commits"
^^^^^^^^^
app/models/fedora_rpm.rb:107:31: C: Redundant self detected.
log_uri = "#{base_uri}#{self.name}.git/log/?ofs=#{offset}"
^^^^^^^^^
app/models/fedora_rpm.rb:109:81: C: Line is too long. [81/80]
ct = doc.xpath("//tr/td[@class='commitgraph']").count { |x| x.text == '* '}
^
app/models/fedora_rpm.rb:109:81: C: Space missing inside }.
ct = doc.xpath("//tr/td[@class='commitgraph']").count { |x| x.text == '* '}
^
app/models/fedora_rpm.rb:116:32: C: Redundant self detected.
commit_uri = "#{base_uri}#{self.name}.git/commit/"
^^^^^^^^^
app/models/fedora_rpm.rb:118:81: C: Line is too long. [81/80]
date = doc.xpath("//table[@class='commit-info']//td[@class='right']")[1].text
^
app/models/fedora_rpm.rb:122:3: C: Method has too many lines. [13/10]
def retrieve_specs
^^^
app/models/fedora_rpm.rb:123:5: C: Redundant self detected.
self.rpm_versions.clear
^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:124:5: C: Redundant self detected.
self.dependencies.clear
^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:125:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Importing #{name} spec info"
^^^^
app/models/fedora_rpm.rb:126:21: C: Use next to skip iteration.
FEDORA_VERSIONS.each do |version_title, version_git|
^^^^
app/models/fedora_rpm.rb:138:3: C: Method has too many lines. [17/10]
def retrieve_versions(rpm_spec, fedora_version)
^^^
app/models/fedora_rpm.rb:155:5: C: Redundant self detected.
self.rpm_versions << rv
^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:161:22: C: Use next to skip iteration.
fedora_user_list.each do |user|
^^^^
app/models/fedora_rpm.rb:162:18: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
if user != "<rel-eng@lists.fedoraproject.org>"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:175:3: C: Method has too many lines. [12/10]
def retrieve_dependencies(rpm_spec)
^^^
app/models/fedora_rpm.rb:176:26: C: Use next to skip iteration.
rpm_spec.split("\n").each do |line|
^^^^
app/models/fedora_rpm.rb:185:9: C: Redundant self detected.
self.dependencies << d
^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:199:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Retrieving gem #{gem_name} data"
^^^^
app/models/fedora_rpm.rb:201:5: C: Redundant self detected.
self.ruby_gem.update_from_source
^^^^^^^^^^^^^
app/models/fedora_rpm.rb:202:5: C: Redundant self detected.
self.ruby_gem.has_rpm = true
^^^^^^^^^^^^^
app/models/fedora_rpm.rb:205:3: C: Method has too many lines. [14/10]
def retrieve_bugs
^^^
app/models/fedora_rpm.rb:206:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Importing rpm #{name} bugs"
^^^^
app/models/fedora_rpm.rb:207:5: C: Redundant self detected.
self.bugs.clear
^^^^^^^^^
app/models/fedora_rpm.rb:210:49: C: Place the . on the next line, together with the method name.
Bicho.client.instance_variable_get(:@client).
^
app/models/fedora_rpm.rb:212:22: C: Use the new Ruby 1.9 hash syntax.
Bicho::Bug.where(:summary => name, :product => 'fedora').each do |bug|
^^^^^^^^^^^
app/models/fedora_rpm.rb:212:40: C: Use the new Ruby 1.9 hash syntax.
Bicho::Bug.where(:summary => name, :product => 'fedora').each do |bug|
^^^^^^^^^^^
app/models/fedora_rpm.rb:219:7: C: Redundant self detected.
self.bugs << arb
^^^^^^^^^
app/models/fedora_rpm.rb:224:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Importing rpm #{name} builds"
^^^^
app/models/fedora_rpm.rb:225:5: C: Redundant self detected.
self.builds.clear
^^^^^^^^^^^
app/models/fedora_rpm.rb:228:17: C: Avoid using {...} for multi-line blocks.
builds.each { |build|
^
app/models/fedora_rpm.rb:272:3: W: Avoid rescuing the Exception class.
rescue Exception => e
^^^^^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:273:5: C: Do not write to stdout. Use Rails' logger if you want to log.
puts "Updating #{name} failed due to #{e.to_s}"
^^^^
app/models/fedora_rpm.rb:273:46: W: Redundant use of Object#to_s in interpolation.
puts "Updating #{name} failed due to #{e.to_s}"
^^^^
app/models/fedora_rpm.rb:277:5: C: Redundant self detected.
self.name
^^^^^^^^^
app/models/fedora_rpm.rb:283:15: C: Prefer the use of the nil? predicate.
if search == nil || search.blank?
^^
app/models/fedora_rpm.rb:286:7: C: Redundant self detected.
self.where('name LIKE ?', 'rubygem-' + search.strip)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:291:5: C: Redundant self detected.
self.dependencies.collect { |d|
^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:291:23: C: Prefer map over collect.
self.dependencies.collect { |d|
^^^^^^^
app/models/fedora_rpm.rb:291:31: C: Avoid using {...} for multi-line blocks.
self.dependencies.collect { |d|
^
app/models/fedora_rpm.rb:297:44: C: Prefer map over collect.
Dependency.where(dependent: shortname).collect { |d|
^^^^^^^
app/models/fedora_rpm.rb:297:52: C: Avoid using {...} for multi-line blocks.
Dependency.where(dependent: shortname).collect { |d|
^
app/models/fedora_rpm.rb:305:81: C: Line is too long. [82/80]
output = `/usr/bin/rpmbuild --define="%_topdir #{buildroot}" -ba #{spec_file}`
^^
app/models/fedora_rpm.rb:306:22: C: Avoid using {...} for multi-line blocks.
output.each_line { |l|
^
app/models/fedora_rpm.rb:307:15: C: Avoid the use of Perl-style backrefs.
rpms << $1 if l =~ /Wrote: (.*)/
^^
app/models/fedora_rpm.rb:313:5: C: Redundant self detected.
self.fedora_user.to_s.gsub("@", " AT ").gsub(".", " DOT ")
^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:313:32: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
self.fedora_user.to_s.gsub("@", " AT ").gsub(".", " DOT ")
^^^
app/models/fedora_rpm.rb:313:37: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
self.fedora_user.to_s.gsub("@", " AT ").gsub(".", " DOT ")
^^^^^^
app/models/fedora_rpm.rb:313:50: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
self.fedora_user.to_s.gsub("@", " AT ").gsub(".", " DOT ")
^^^
app/models/fedora_rpm.rb:313:55: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
self.fedora_user.to_s.gsub("@", " AT ").gsub(".", " DOT ")
^^^^^^^
app/models/fedora_rpm.rb:317:5: C: Use a guard clause instead of wrapping the code inside a conditional expression.
unless self.last_commit_date.nil?
^^^^^^
app/models/fedora_rpm.rb:317:12: C: Redundant self detected.
unless self.last_commit_date.nil?
^^^^^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:318:28: C: Redundant self detected.
"#{time_ago_in_words(self.last_commit_date)} ago"
^^^^^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:323:5: C: Redundant self detected.
self.fedora_user.split('@').first unless self.fedora_user.nil?
^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:323:46: C: Redundant self detected.
self.fedora_user.split('@').first unless self.fedora_user.nil?
^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:326:1: C: Indent access modifiers like private.
private
^^^^^^^
app/models/fedora_rpm.rb:328:3: C: Use the new "sexy" validations (validates ...).
validates_uniqueness_of :name
^^^^^^^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:329:3: C: Use the new "sexy" validations (validates ...).
validates_presence_of :name
^^^^^^^^^^^^^^^^^^^^^
app/models/fedora_rpm.rb:330:1: C: Extra empty line detected at body end.
app/models/dependency.rb:15:1: C: Missing top-level class documentation comment.
class Dependency < ActiveRecord::Base
^^^^^
app/models/dependency.rb:16:1: C: Extra empty line detected at body beginning.
app/models/dependency.rb:27:1: C: Indent access modifiers like private.
private
^^^^^^^
app/models/dependency.rb:29:3: C: Use the new "sexy" validations (validates ...).
validates_presence_of :dependent
^^^^^^^^^^^^^^^^^^^^^
app/models/dependency.rb:30:1: C: Extra empty line detected at body end.
app/models/build.rb:13:1: C: Missing top-level class documentation comment.
class Build < ActiveRecord::Base
^^^^^
app/models/build.rb:16:18: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
KOJI_API_URL = "http://koji.fedoraproject.org/kojihub"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/build.rb:17:20: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
KOJI_BUILD_URL = "http://koji.fedoraproject.org/koji/buildinfo?buildID="
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/historical_gem.rb:13:1: C: Missing top-level class documentation comment.
class HistoricalGem < ActiveRecord::Base
^^^^^
app/models/historical_gem.rb:14:25: C: Use the new Ruby 1.9 hash syntax.
belongs_to :ruby_gem, :foreign_key => :gem_id
^^^^^^^^^^^^^^^
app/models/historical_gem.rb:16:1: C: Indent access modifiers like private.
private
^^^^^^^
app/models/historical_gem.rb:16:1: C: Keep a blank line before and after private.
private
^^^^^^^
app/models/gem_version.rb:12:1: C: Missing top-level class documentation comment.
class GemVersion < ActiveRecord::Base
^^^^^
app/models/rpm_version.rb:14:1: C: Missing top-level class documentation comment.
class RpmVersion < ActiveRecord::Base
^^^^^
app/models/bug.rb:16:1: C: Missing top-level class documentation comment.
class Bug < ActiveRecord::Base
^^^^^
app/helpers/application_helper.rb:1:1: C: Missing top-level module documentation comment.
module ApplicationHelper
^^^^^^
app/helpers/application_helper.rb:4:60: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
direction = column == sort_column && sort_direction == "asc" ? "desc" : "asc"
^^^^^
app/helpers/application_helper.rb:4:68: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
direction = column == sort_column && sort_direction == "asc" ? "desc" : "asc"
^^^^^^
app/helpers/application_helper.rb:4:77: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
direction = column == sort_column && sort_direction == "asc" ? "desc" : "asc"
^^^^^
app/helpers/application_helper.rb:4:81: C: Line is too long. [81/80]
direction = column == sort_column && sort_direction == "asc" ? "desc" : "asc"
^
app/helpers/application_helper.rb:5:20: C: Use the new Ruby 1.9 hash syntax.
link_to title, :sort => column, :direction => direction
^^^^^^^^
app/helpers/application_helper.rb:5:37: C: Use the new Ruby 1.9 hash syntax.
link_to title, :sort => column, :direction => direction
^^^^^^^^^^^^^
app/helpers/rpmcomments_helper.rb:1:1: C: Missing top-level module documentation comment.
module RpmcommentsHelper
^^^^^^
app/helpers/static_pages_helper.rb:1:1: C: Missing top-level module documentation comment.
module StaticPagesHelper
^^^^^^
app/helpers/fedorarpms_helper.rb:1:1: C: Missing top-level module documentation comment.
module FedorarpmsHelper
^^^^^^
app/helpers/home_helper.rb:1:1: C: Missing top-level module documentation comment.
module HomeHelper
^^^^^^
app/helpers/searches_helper.rb:1:1: C: Missing top-level module documentation comment.
module SearchesHelper
^^^^^^
app/helpers/gemcomments_helper.rb:1:1: C: Missing top-level module documentation comment.
module GemcommentsHelper
^^^^^^
app/helpers/builds_helper.rb:1:1: C: Missing top-level module documentation comment.
module BuildsHelper
^^^^^^
app/helpers/errors_helper.rb:1:1: C: Missing top-level module documentation comment.
module ErrorsHelper
^^^^^^
app/helpers/rubygems_helper.rb:1:1: C: Missing top-level module documentation comment.
module RubygemsHelper
^^^^^^
app/helpers/stats_helper.rb:1:1: C: Missing top-level module documentation comment.
module StatsHelper
^^^^^^
app/controllers/fedorarpms_controller.rb:1:1: C: Missing top-level class documentation comment.
class FedorarpmsController < ApplicationController
^^^^^
app/controllers/fedorarpms_controller.rb:2:1: C: Extra empty line detected at body beginning.
app/controllers/fedorarpms_controller.rb:7:32: C: Use the new Ruby 1.9 hash syntax.
@rpms = FedoraRpm.paginate(:page => params[:page], :per_page => 50).
^^^^^^^^
app/controllers/fedorarpms_controller.rb:7:56: C: Use the new Ruby 1.9 hash syntax.
@rpms = FedoraRpm.paginate(:page => params[:page], :per_page => 50).
^^^^^^^^^^^^
app/controllers/fedorarpms_controller.rb:7:72: C: Place the . on the next line, together with the method name.
@rpms = FedoraRpm.paginate(:page => params[:page], :per_page => 50).
^
app/controllers/fedorarpms_controller.rb:17:5: C: Missing space after #.
#We can register a global error handler inside the application controller for this.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/fedorarpms_controller.rb:17:81: C: Line is too long. [87/80]
#We can register a global error handler inside the application controller for this.
^^^^^^^
app/controllers/fedorarpms_controller.rb:19:19: C: Use the new Ruby 1.9 hash syntax.
redirect_to :action => 'not_found'
^^^^^^^^^^
app/controllers/fedorarpms_controller.rb:20:1: C: Extra empty line detected at body end.
app/controllers/fedorarpms_controller.rb:40:28: C: Use the new Ruby 1.9 hash syntax.
format.json { render :json => @rpm.json_dependencies }
^^^^^^^^
app/controllers/fedorarpms_controller.rb:48:28: C: Use the new Ruby 1.9 hash syntax.
format.json { render :json => @rpm.json_dependents }
^^^^^^^^
app/controllers/fedorarpms_controller.rb:57:3: C: Method has too many lines. [11/10]
def badge
^^^
app/controllers/fedorarpms_controller.rb:63:15: C: Avoid using {...} for multi-line blocks.
rpms.each { |i|
^
app/controllers/fedorarpms_controller.rb:68:12: C: Use the new Ruby 1.9 hash syntax.
render :layout => false
^^^^^^^^^^
app/controllers/fedorarpms_controller.rb:71:1: C: Indent access modifiers like private.
private
^^^^^^^
app/controllers/fedorarpms_controller.rb:74:5: C: Avoid multi-line ?: (the ternary operator); use if/unless instead.
%w[name commits last_commit_date fedora_user].include?(params[:sort]) ?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/fedorarpms_controller.rb:74:5: C: %w-literals should be delimited by ( and )
%w[name commits last_commit_date fedora_user].include?(params[:sort]) ?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/fedorarpms_controller.rb:79:5: C: %w-literals should be delimited by ( and )
%w[asc desc].include?(params[:direction]) ? params[:direction] : 'asc'
^^^^^^^^^^^^
app/controllers/fedorarpms_controller.rb:81:1: C: Extra empty line detected at body end.
app/controllers/application_controller.rb:1:1: C: Missing top-level class documentation comment.
class ApplicationController < ActionController::Base
^^^^^
app/controllers/application_controller.rb:5:3: C: Prefer before_action over before_filter.
before_filter :set_gettext_locale
^^^^^^^^^^^^^
app/controllers/application_controller.rb:8:34: C: Use the new lambda literal syntax ->(params) {...}.
rescue_from Exception, with: lambda { |exception| render_error 500, exception }
^^^^^^
app/controllers/application_controller.rb:8:81: C: Line is too long. [83/80]
rescue_from Exception, with: lambda { |exception| render_error 500, exception }
^^^
app/controllers/application_controller.rb:9:81: C: Line is too long. [209/80]
rescue_from ActionController::RoutingError, ActionController::UnknownController, ::AbstractController::ActionNotFound, ActiveRecord::RecordNotFound, with: lambda { |exception| render_error 404, exception }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/application_controller.rb:9:160: C: Use the new lambda literal syntax ->(params) {...}.
rescue_from ActionController::RoutingError, ActionController::UnknownController, ::AbstractController::ActionNotFound, ActiveRecord::RecordNotFound, with: lambda { |exception| render_error 404, exception }
^^^^^^
app/controllers/application_controller.rb:12:3: C: Keep a blank line before and after private.
private
^^^^^^^
app/controllers/application_controller.rb:13:28: W: Unused method argument - exception. If it's necessary, use _ or _exception as an argument name to indicate that it won't be used.
def render_error(status, exception)
^^^^^^^^^
app/controllers/application_controller.rb:15:81: C: Line is too long. [110/80]
format.html { render template: "errors/error_#{status}", layout: 'layouts/application', status: status }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/searches_controller.rb:3:1: C: Missing top-level class documentation comment.
class SearchesController < ApplicationController
^^^^^
app/controllers/searches_controller.rb:4:1: C: Extra empty line detected at body beginning.
app/controllers/searches_controller.rb:5:3: C: Method has too many lines. [13/10]
def index
^^^
app/controllers/searches_controller.rb:8:75: C: Use the new Ruby 1.9 hash syntax.
@results = RubyGem.where('name LIKE ?', "%#{searchphrase}%").paginate(:page => params[:page], :per_page => 50, :group => "name", :order => "length(name) asc")
^^^^^^^^
app/controllers/searches_controller.rb:8:81: C: Line is too long. [162/80]
@results = RubyGem.where('name LIKE ?', "%#{searchphrase}%").paginate(:page => params[:page], :per_page => 50, :group => "name", :order => "length(name) asc")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/searches_controller.rb:8:99: C: Use the new Ruby 1.9 hash syntax.
@results = RubyGem.where('name LIKE ?', "%#{searchphrase}%").paginate(:page => params[:page], :per_page => 50, :group => "name", :order => "length(name) asc")
^^^^^^^^^^^^
app/controllers/searches_controller.rb:8:116: C: Use the new Ruby 1.9 hash syntax.
@results = RubyGem.where('name LIKE ?', "%#{searchphrase}%").paginate(:page => params[:page], :per_page => 50, :group => "name", :order => "length(name) asc")
^^^^^^^^^
app/controllers/searches_controller.rb:8:126: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
@results = RubyGem.where('name LIKE ?', "%#{searchphrase}%").paginate(:page => params[:page], :per_page => 50, :group => "name", :order => "length(name) asc")
^^^^^^
app/controllers/searches_controller.rb:8:134: C: Use the new Ruby 1.9 hash syntax.
@results = RubyGem.where('name LIKE ?', "%#{searchphrase}%").paginate(:page => params[:page], :per_page => 50, :group => "name", :order => "length(name) asc")
^^^^^^^^^
app/controllers/searches_controller.rb:8:144: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
@results = RubyGem.where('name LIKE ?', "%#{searchphrase}%").paginate(:page => params[:page], :per_page => 50, :group => "name", :order => "length(name) asc")
^^^^^^^^^^^^^^^^^^
app/controllers/searches_controller.rb:10:5: C: Use a guard clause instead of wrapping the code inside a conditional expression.
if @results == []
^^
app/controllers/searches_controller.rb:11:44: C: Space missing to the left of {.
all_gems = RubyGem.select('name').map{|x| x.name}
^
app/controllers/searches_controller.rb:11:44: C: Space between { and | missing.
all_gems = RubyGem.select('name').map{|x| x.name}
^^
app/controllers/searches_controller.rb:11:55: C: Space missing inside }.
all_gems = RubyGem.select('name').map{|x| x.name}
^
app/controllers/searches_controller.rb:12:37: C: Space missing to the left of {.
dist_score = Hash[all_gems.map{|x| [x, Text::Levenshtein.distance(x, searchphrase)]}]
^
app/controllers/searches_controller.rb:12:37: C: Space between { and | missing.
dist_score = Hash[all_gems.map{|x| [x, Text::Levenshtein.distance(x, searchphrase)]}]
^^
app/controllers/searches_controller.rb:12:81: C: Line is too long. [91/80]
dist_score = Hash[all_gems.map{|x| [x, Text::Levenshtein.distance(x, searchphrase)]}]
^^^^^^^^^^^
app/controllers/searches_controller.rb:12:90: C: Space missing inside }.
dist_score = Hash[all_gems.map{|x| [x, Text::Levenshtein.distance(x, searchphrase)]}]
^
app/controllers/searches_controller.rb:13:38: C: Space missing to the left of {.
dist_score = dist_score.sort_by{|x,d| d}.collect{|x,d| x}
^
app/controllers/searches_controller.rb:13:38: C: Space between { and | missing.
dist_score = dist_score.sort_by{|x,d| d}.collect{|x,d| x}
^^
app/controllers/searches_controller.rb:13:40: W: Unused block argument - x. If it's necessary, use _ or _x as an argument name to indicate that it won't be used.
dist_score = dist_score.sort_by{|x,d| d}.collect{|x,d| x}
^
app/controllers/searches_controller.rb:13:41: C: Space missing after comma.
dist_score = dist_score.sort_by{|x,d| d}.collect{|x,d| x}
^
app/controllers/searches_controller.rb:13:46: C: Space missing inside }.
dist_score = dist_score.sort_by{|x,d| d}.collect{|x,d| x}
^
app/controllers/searches_controller.rb:13:48: C: Prefer map over collect.
dist_score = dist_score.sort_by{|x,d| d}.collect{|x,d| x}
^^^^^^^
app/controllers/searches_controller.rb:13:55: C: Space missing to the left of {.
dist_score = dist_score.sort_by{|x,d| d}.collect{|x,d| x}
^
app/controllers/searches_controller.rb:13:55: C: Space between { and | missing.
dist_score = dist_score.sort_by{|x,d| d}.collect{|x,d| x}
^^
app/controllers/searches_controller.rb:13:58: C: Space missing after comma.
dist_score = dist_score.sort_by{|x,d| d}.collect{|x,d| x}
^
app/controllers/searches_controller.rb:13:59: W: Unused block argument - d. If it's necessary, use _ or _d as an argument name to indicate that it won't be used.
dist_score = dist_score.sort_by{|x,d| d}.collect{|x,d| x}
^
app/controllers/searches_controller.rb:13:63: C: Space missing inside }.
dist_score = dist_score.sort_by{|x,d| d}.collect{|x,d| x}
^
app/controllers/searches_controller.rb:14:36: C: Space missing to the left of {.
sim_score = Hash[all_gems.map{|x| [x, Text::WhiteSimilarity.similarity(x, searchphrase)]}]
^
app/controllers/searches_controller.rb:14:36: C: Space between { and | missing.
sim_score = Hash[all_gems.map{|x| [x, Text::WhiteSimilarity.similarity(x, searchphrase)]}]
^^
app/controllers/searches_controller.rb:14:81: C: Line is too long. [96/80]
sim_score = Hash[all_gems.map{|x| [x, Text::WhiteSimilarity.similarity(x, searchphrase)]}]
^^^^^^^^^^^^^^^^
app/controllers/searches_controller.rb:14:95: C: Space missing inside }.
sim_score = Hash[all_gems.map{|x| [x, Text::WhiteSimilarity.similarity(x, searchphrase)]}]
^
app/controllers/searches_controller.rb:15:36: C: Space missing to the left of {.
sim_score = sim_score.sort_by{|x,s| s}.reverse.collect{|x,s| x}
^
app/controllers/searches_controller.rb:15:36: C: Space between { and | missing.
sim_score = sim_score.sort_by{|x,s| s}.reverse.collect{|x,s| x}
^^
app/controllers/searches_controller.rb:15:38: W: Unused block argument - x. If it's necessary, use _ or _x as an argument name to indicate that it won't be used.
sim_score = sim_score.sort_by{|x,s| s}.reverse.collect{|x,s| x}
^
app/controllers/searches_controller.rb:15:39: C: Space missing after comma.
sim_score = sim_score.sort_by{|x,s| s}.reverse.collect{|x,s| x}
^
app/controllers/searches_controller.rb:15:44: C: Space missing inside }.
sim_score = sim_score.sort_by{|x,s| s}.reverse.collect{|x,s| x}
^
app/controllers/searches_controller.rb:15:54: C: Prefer map over collect.
sim_score = sim_score.sort_by{|x,s| s}.reverse.collect{|x,s| x}
^^^^^^^
app/controllers/searches_controller.rb:15:61: C: Space missing to the left of {.
sim_score = sim_score.sort_by{|x,s| s}.reverse.collect{|x,s| x}
^
app/controllers/searches_controller.rb:15:61: C: Space between { and | missing.
sim_score = sim_score.sort_by{|x,s| s}.reverse.collect{|x,s| x}
^^
app/controllers/searches_controller.rb:15:64: C: Space missing after comma.
sim_score = sim_score.sort_by{|x,s| s}.reverse.collect{|x,s| x}
^
app/controllers/searches_controller.rb:15:65: W: Unused block argument - s. If it's necessary, use _ or _s as an argument name to indicate that it won't be used.
sim_score = sim_score.sort_by{|x,s| s}.reverse.collect{|x,s| x}
^
app/controllers/searches_controller.rb:15:69: C: Space missing inside }.
sim_score = sim_score.sort_by{|x,s| s}.reverse.collect{|x,s| x}
^
app/controllers/searches_controller.rb:16:81: C: Line is too long. [83/80]
# suggestions are intersection of max similarity and min Levenshtein distance
^^^
app/controllers/searches_controller.rb:20:38: C: Space missing to the left of {.
@suggests = @suggests[0..4].map{|x| RubyGem.find_by_name(x)}
^
app/controllers/searches_controller.rb:20:38: C: Space between { and | missing.
@suggests = @suggests[0..4].map{|x| RubyGem.find_by_name(x)}
^^
app/controllers/searches_controller.rb:20:66: C: Space missing inside }.
@suggests = @suggests[0..4].map{|x| RubyGem.find_by_name(x)}
^
app/controllers/searches_controller.rb:24:19: C: Never put a space between a method name and the opening parenthesis.
def suggest_gems (result = [])
^
app/controllers/searches_controller.rb:25:27: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
@gems = RubyGem.where("name like ?", "%#{params[:q]}%").limit(10)
^^^^^^^^^^^^^
app/controllers/searches_controller.rb:26:16: C: Avoid using {...} for multi-line blocks.
@gems.each { |g|
^
app/controllers/searches_controller.rb:27:7: C: Use 2 (not 0) spaces for indentation.
result << {:name => g.name}
app/controllers/searches_controller.rb:27:17: C: Space inside { missing.
result << {:name => g.name}
^
app/controllers/searches_controller.rb:27:18: C: Use the new Ruby 1.9 hash syntax.
result << {:name => g.name}
^^^^^^^^
app/controllers/searches_controller.rb:27:33: C: Space inside } missing.
result << {:name => g.name}
^
app/controllers/searches_controller.rb:28:7: W: end at 28, 6 is not aligned with @gems.each { |g| at 26, 4
}
^
app/controllers/searches_controller.rb:30:28: C: Use the new Ruby 1.9 hash syntax.
format.json { render :json => result.to_json }
^^^^^^^^
app/controllers/searches_controller.rb:35:5: C: Use a guard clause instead of wrapping the code inside a conditional expression.
if params[:search]
^^
app/controllers/searches_controller.rb:35:5: C: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
if params[:search]
^^
app/controllers/home_controller.rb:1:1: C: Missing top-level class documentation comment.
class HomeController < ApplicationController
^^^^^
app/controllers/stats_controller.rb:1:1: C: Class definition is too long. [104/100]
class StatsController < ApplicationController
^^^^^
app/controllers/stats_controller.rb:1:1: C: Missing top-level class documentation comment.
class StatsController < ApplicationController
^^^^^
app/controllers/stats_controller.rb:9:29: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
@rpms = FedoraRpm.where("fedora_user LIKE ?", @name + "@%")
^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:9:59: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
@rpms = FedoraRpm.where("fedora_user LIKE ?", @name + "@%")
^^^^
app/controllers/stats_controller.rb:17:29: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
@rpms = FedoraRpm.where("fedora_user LIKE ?", @name + "@%")
^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:17:59: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
@rpms = FedoraRpm.where("fedora_user LIKE ?", @name + "@%")
^^^^
app/controllers/stats_controller.rb:26:7: C: Inconsistent indentation detected.
respond_to do |format|
^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:28:5: W: end at 28, 4 is not aligned with respond_to do |format| at 26, 6
end
^^^
app/controllers/stats_controller.rb:31:3: C: Method has too many lines. [12/10]
def tljson (result = [])
^^^
app/controllers/stats_controller.rb:31:13: C: Never put a space between a method name and the opening parenthesis.
def tljson (result = [])
^
app/controllers/stats_controller.rb:34:40: C: Avoid using {...} for multi-line blocks.
@rpm.ruby_gem.historical_gems.each { |h|
^
app/controllers/stats_controller.rb:35:19: C: Use the new Ruby 1.9 hash syntax.
result << { :content => h.version, :start => h.build_date }
^^^^^^^^^^^
app/controllers/stats_controller.rb:35:42: C: Use the new Ruby 1.9 hash syntax.
result << { :content => h.version, :start => h.build_date }
^^^^^^^^^
app/controllers/stats_controller.rb:37:20: C: Avoid using {...} for multi-line blocks.
@rpm.bugs.each { |b|
^
app/controllers/stats_controller.rb:38:19: C: Use the new Ruby 1.9 hash syntax.
result << { :content => b.name, :start => b.bz_id }
^^^^^^^^^^^
app/controllers/stats_controller.rb:38:39: C: Use the new Ruby 1.9 hash syntax.
result << { :content => b.name, :start => b.bz_id }
^^^^^^^^^
app/controllers/stats_controller.rb:46:3: C: Cyclomatic complexity for gemfile_tool is too high. [17/6]
def gemfile_tool
^^^
app/controllers/stats_controller.rb:46:3: C: Method has too many lines. [63/10]
def gemfile_tool
^^^
app/controllers/stats_controller.rb:47:5: C: Use a guard clause instead of wrapping the code inside a conditional expression.
if params[:gemfile]
^^
app/controllers/stats_controller.rb:49:7: C: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
unless @gemfile.is_a?(String)
^^^^^^
app/controllers/stats_controller.rb:64:9: C: Annotation keywords should be all upper case, followed by a colon and a space, then a note describing the problem.
# FIXME very hacky way to do this,
^^^^^
app/controllers/stats_controller.rb:67:20: C: Avoid using {...} for multi-line blocks.
lines.each { |line|
^
app/controllers/stats_controller.rb:69:13: C: Incorrect indentation detected (column 12 instead of 11).
# gem name only
^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:70:11: C: Use 2 (not 1) spaces for indentation.
dependencies << {:name => $1, :version => nil}
^
app/controllers/stats_controller.rb:70:28: C: Space inside { missing.
dependencies << {:name => $1, :version => nil}
^
app/controllers/stats_controller.rb:70:29: C: Use the new Ruby 1.9 hash syntax.
dependencies << {:name => $1, :version => nil}
^^^^^^^^
app/controllers/stats_controller.rb:70:38: C: Avoid the use of Perl-style backrefs.
dependencies << {:name => $1, :version => nil}
^^
app/controllers/stats_controller.rb:70:42: C: Use the new Ruby 1.9 hash syntax.
dependencies << {:name => $1, :version => nil}
^^^^^^^^^^^
app/controllers/stats_controller.rb:70:57: C: Space inside } missing.
dependencies << {:name => $1, :version => nil}
^
app/controllers/stats_controller.rb:74:20: C: Avoid the use of Perl-style backrefs.
name = $1
^^
app/controllers/stats_controller.rb:77:42: C: Avoid the use of Perl-style backrefs.
version = Versionomy.parse($2.split.last)
^^
app/controllers/stats_controller.rb:78:13: W: Do not suppress exceptions.
rescue Versionomy::Errors::ParseError
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:78:13: C: Avoid more than 3 levels of block nesting.
rescue Versionomy::Errors::ParseError
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:80:29: C: Space inside { missing.
dependencies << {:name => name, :version => version}
^
app/controllers/stats_controller.rb:80:30: C: Use the new Ruby 1.9 hash syntax.
dependencies << {:name => name, :version => version}
^^^^^^^^
app/controllers/stats_controller.rb:80:45: C: Use the new Ruby 1.9 hash syntax.
dependencies << {:name => name, :version => version}
^^^^^^^^^^^
app/controllers/stats_controller.rb:80:64: C: Space inside } missing.
dependencies << {:name => name, :version => version}
^
app/controllers/stats_controller.rb:82:13: C: Missing space after #.
#else # ignore
^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:86:15: C: Use next to skip iteration.
lines.each { |line|
^^^^
app/controllers/stats_controller.rb:86:20: C: Avoid using {...} for multi-line blocks.
lines.each { |line|
^
app/controllers/stats_controller.rb:89:29: C: Avoid the use of Perl-style backrefs.
name, version = $1, $2
^^
app/controllers/stats_controller.rb:89:33: C: Avoid the use of Perl-style backrefs.
name, version = $1, $2
^^
app/controllers/stats_controller.rb:92:13: W: Do not suppress exceptions.
rescue Versionomy::Errors::ParseError
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:92:13: C: Avoid more than 3 levels of block nesting.
rescue Versionomy::Errors::ParseError
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:94:29: C: Space inside { missing.
dependencies << {:name => name, :version => version}
^
app/controllers/stats_controller.rb:94:30: C: Use the new Ruby 1.9 hash syntax.
dependencies << {:name => name, :version => version}
^^^^^^^^
app/controllers/stats_controller.rb:94:45: C: Use the new Ruby 1.9 hash syntax.
dependencies << {:name => name, :version => version}
^^^^^^^^^^^
app/controllers/stats_controller.rb:94:64: C: Space inside } missing.
dependencies << {:name => name, :version => version}
^
app/controllers/stats_controller.rb:99:20: C: Use next to skip iteration.
dependencies.each { |dep|
^^^^
app/controllers/stats_controller.rb:99:25: C: Avoid using {...} for multi-line blocks.
dependencies.each { |dep|
^
app/controllers/stats_controller.rb:102:40: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
rpm = FedoraRpm.find_by_name("rubygem-" + dep[:name])
^^^^^^^^^^
app/controllers/stats_controller.rb:105:24: C: Space inside { missing.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} not found in Fedora') % { :dep_name => dep[:name]}}
^
app/controllers/stats_controller.rb:105:25: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} not found in Fedora') % { :dep_name => dep[:name]}}
^^^^^^^^
app/controllers/stats_controller.rb:105:46: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} not found in Fedora') % { :dep_name => dep[:name]}}
^^^^^^^^^^^
app/controllers/stats_controller.rb:105:65: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} not found in Fedora') % { :dep_name => dep[:name]}}
^^^^^^^^^^^
app/controllers/stats_controller.rb:105:81: C: Line is too long. [142/80]
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} not found in Fedora') % { :dep_name => dep[:name]}}
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:105:118: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} not found in Fedora') % { :dep_name => dep[:name]}}
^^^^^^^^^^^^
app/controllers/stats_controller.rb:105:141: C: Space inside } missing.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} not found in Fedora') % { :dep_name => dep[:name]}}
^
app/controllers/stats_controller.rb:105:142: C: Space inside } missing.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} not found in Fedora') % { :dep_name => dep[:name]}}
^
app/controllers/stats_controller.rb:108:30: C: Use next to skip iteration.
rpm.rpm_versions.each { |rv|
^^^^
app/controllers/stats_controller.rb:108:35: C: Avoid using {...} for multi-line blocks.
rpm.rpm_versions.each { |rv|
^
app/controllers/stats_controller.rb:109:15: C: Avoid more than 3 levels of block nesting.
unless rv.rpm_version.nil?
^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:112:30: C: Space inside { missing.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} (%{dep_version}) is too old in %{rv_fedora_version} (which has %{rv_rpm_version})') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version, :rv_rpm_version => rv.rpm_version}}
^
app/controllers/stats_controller.rb:112:31: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} (%{dep_version}) is too old in %{rv_fedora_version} (which has %{rv_rpm_version})') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version, :rv_rpm_version => rv.rpm_version}}
^^^^^^^^
app/controllers/stats_controller.rb:112:52: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} (%{dep_version}) is too old in %{rv_fedora_version} (which has %{rv_rpm_version})') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version, :rv_rpm_version => rv.rpm_version}}
^^^^^^^^^^^
app/controllers/stats_controller.rb:112:71: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} (%{dep_version}) is too old in %{rv_fedora_version} (which has %{rv_rpm_version})') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version, :rv_rpm_version => rv.rpm_version}}
^^^^^^^^^^^
app/controllers/stats_controller.rb:112:81: C: Line is too long. [317/80]
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} (%{dep_version}) is too old in %{rv_fedora_version} (which has %{rv_rpm_version})') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version, :rv_rpm_version => rv.rpm_version}}
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:112:186: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} (%{dep_version}) is too old in %{rv_fedora_version} (which has %{rv_rpm_version})') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version, :rv_rpm_version => rv.rpm_version}}
^^^^^^^^^^^^
app/controllers/stats_controller.rb:112:211: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} (%{dep_version}) is too old in %{rv_fedora_version} (which has %{rv_rpm_version})') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version, :rv_rpm_version => rv.rpm_version}}
^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:112:242: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} (%{dep_version}) is too old in %{rv_fedora_version} (which has %{rv_rpm_version})') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version, :rv_rpm_version => rv.rpm_version}}
^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:112:283: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} (%{dep_version}) is too old in %{rv_fedora_version} (which has %{rv_rpm_version})') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version, :rv_rpm_version => rv.rpm_version}}
^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:112:316: C: Space inside } missing.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} (%{dep_version}) is too old in %{rv_fedora_version} (which has %{rv_rpm_version})') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version, :rv_rpm_version => rv.rpm_version}}
^
app/controllers/stats_controller.rb:112:317: C: Space inside } missing.
@result << {:name => dep[:name], :success => false, :message => _('%{dep_name} (%{dep_version}) is too old in %{rv_fedora_version} (which has %{rv_rpm_version})') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version, :rv_rpm_version => rv.rpm_version}}
^
app/controllers/stats_controller.rb:114:24: C: Annotation keywords should be all upper case, followed by a colon and a space, then a note describing the problem.
else # TODO comment: (?)
^^^^
app/controllers/stats_controller.rb:115:30: C: Space inside { missing.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} (%{dep_version}) is sufficient in %{rv_fedora_version}') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version}}
^
app/controllers/stats_controller.rb:115:31: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} (%{dep_version}) is sufficient in %{rv_fedora_version}') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version}}
^^^^^^^^
app/controllers/stats_controller.rb:115:52: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} (%{dep_version}) is sufficient in %{rv_fedora_version}') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version}}
^^^^^^^^^^^
app/controllers/stats_controller.rb:115:70: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} (%{dep_version}) is sufficient in %{rv_fedora_version}') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version}}
^^^^^^^^^^^
app/controllers/stats_controller.rb:115:81: C: Line is too long. [254/80]
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} (%{dep_version}) is sufficient in %{rv_fedora_version}') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version}}
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:115:158: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} (%{dep_version}) is sufficient in %{rv_fedora_version}') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version}}
^^^^^^^^^^^^
app/controllers/stats_controller.rb:115:183: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} (%{dep_version}) is sufficient in %{rv_fedora_version}') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version}}
^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:115:214: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} (%{dep_version}) is sufficient in %{rv_fedora_version}') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version}}
^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:115:253: C: Space inside } missing.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} (%{dep_version}) is sufficient in %{rv_fedora_version}') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version}}
^
app/controllers/stats_controller.rb:115:254: C: Space inside } missing.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} (%{dep_version}) is sufficient in %{rv_fedora_version}') % { :dep_name => dep[:name], :dep_version => dep[:version], :rv_fedora_version => rv.fedora_version}}
^
app/controllers/stats_controller.rb:122:24: C: Space inside { missing.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} is in Fedora!') % { :dep_name => dep[:name]}}
^
app/controllers/stats_controller.rb:122:25: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} is in Fedora!') % { :dep_name => dep[:name]}}
^^^^^^^^
app/controllers/stats_controller.rb:122:46: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} is in Fedora!') % { :dep_name => dep[:name]}}
^^^^^^^^^^^
app/controllers/stats_controller.rb:122:64: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} is in Fedora!') % { :dep_name => dep[:name]}}
^^^^^^^^^^^
app/controllers/stats_controller.rb:122:81: C: Line is too long. [135/80]
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} is in Fedora!') % { :dep_name => dep[:name]}}
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/stats_controller.rb:122:111: C: Use the new Ruby 1.9 hash syntax.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} is in Fedora!') % { :dep_name => dep[:name]}}
^^^^^^^^^^^^
app/controllers/stats_controller.rb:122:134: C: Space inside } missing.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} is in Fedora!') % { :dep_name => dep[:name]}}
^
app/controllers/stats_controller.rb:122:135: C: Space inside } missing.
@result << {:name => dep[:name], :success => true, :message => _('%{dep_name} is in Fedora!') % { :dep_name => dep[:name]}}
^
app/controllers/builds_controller.rb:1:1: C: Missing top-level class documentation comment.
class BuildsController < ApplicationController
^^^^^
app/controllers/builds_controller.rb:2:3: C: Cyclomatic complexity for import is too high. [8/6]
def import
^^^
app/controllers/builds_controller.rb:2:3: C: Method has too many lines. [32/10]
def import
^^^
app/controllers/builds_controller.rb:9:20: C: Space inside { missing.
@packages = [{:gem => @gem, :version => @version}]
^
app/controllers/builds_controller.rb:9:21: C: Use the new Ruby 1.9 hash syntax.
@packages = [{:gem => @gem, :version => @version}]
^^^^^^^
app/controllers/builds_controller.rb:9:35: C: Use the new Ruby 1.9 hash syntax.
@packages = [{:gem => @gem, :version => @version}]
^^^^^^^^^^^
app/controllers/builds_controller.rb:9:55: C: Space inside } missing.
@packages = [{:gem => @gem, :version => @version}]
^
app/controllers/builds_controller.rb:10:22: C: Avoid using {...} for multi-line blocks.
@packages.each { |p|
^
app/controllers/builds_controller.rb:11:30: C: Use next to skip iteration.
p[:gem].dependencies.each { |d|
^^^^
app/controllers/builds_controller.rb:11:35: C: Avoid using {...} for multi-line blocks.
p[:gem].dependencies.each { |d|
^
app/controllers/builds_controller.rb:13:28: C: Prefer map over collect.
@packages.collect { |pkg| pkg[:gem] }.include?(d.dependent_package)
^^^^^^^
app/controllers/builds_controller.rb:13:81: C: Line is too long. [84/80]
@packages.collect { |pkg| pkg[:gem] }.include?(d.dependent_package)
^^^^
app/controllers/builds_controller.rb:14:26: C: Space inside { missing.
@packages << {:gem => d.dependent_package,
^
app/controllers/builds_controller.rb:14:27: C: Use the new Ruby 1.9 hash syntax.
@packages << {:gem => d.dependent_package,
^^^^^^^
app/controllers/builds_controller.rb:15:27: C: Use the new Ruby 1.9 hash syntax.
:version => d.dependent_version.split.last}
^^^^^^^^^^^
app/controllers/builds_controller.rb:15:69: C: Space inside } missing.
:version => d.dependent_version.split.last}
^
app/controllers/builds_controller.rb:21:22: C: Avoid using {...} for multi-line blocks.
@packages.each { |pkg|
^
app/controllers/builds_controller.rb:34:67: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
pkg[:spec_path] = spec_file.gsub(/#{Rails.root}\/public/, "")
^^
app/controllers/builds_controller.rb:35:49: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
pkg[:spec_name] = pkg[:spec_path].split("/").last
^^^
app/controllers/builds_controller.rb:36:9: C: Missing space after #.
#pkg[:rpms] = FedoraRpm.build_rpms spec_file
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/builds_controller.rb:39:9: C: Annotation keywords should be all upper case, followed by a colon and a space, then a note describing the problem.
# TODO run this in a lock
^^^^
app/controllers/builds_controller.rb:40:7: C: Missing space after #.
#`createrepo #{Rails.root}/public/rpmbuild/RPMS`
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/builds_controller.rb:54:5: W: Useless assignment to variable - gem.
gem = RubyGem.find_by_name(params[:gem])
^^^
app/controllers/builds_controller.rb:55:5: W: Useless assignment to variable - version.
version = params[:version]
^^^^^^^
app/controllers/static_pages_controller.rb:1:1: C: Missing top-level class documentation comment.
class StaticPagesController < ApplicationController
^^^^^
app/controllers/static_pages_controller.rb:9:1: C: Trailing whitespace detected.
app/controllers/rubygems_controller.rb:1:1: C: Missing top-level class documentation comment.
class RubygemsController < ApplicationController
^^^^^
app/controllers/rubygems_controller.rb:2:1: C: Extra empty line detected at body beginning.
app/controllers/rubygems_controller.rb:7:30: C: Use the new Ruby 1.9 hash syntax.
@gems = RubyGem.paginate(:page => params[:page], :per_page => 50).
^^^^^^^^
app/controllers/rubygems_controller.rb:7:54: C: Use the new Ruby 1.9 hash syntax.
@gems = RubyGem.paginate(:page => params[:page], :per_page => 50).
^^^^^^^^^^^^
app/controllers/rubygems_controller.rb:7:70: C: Place the . on the next line, together with the method name.
@gems = RubyGem.paginate(:page => params[:page], :per_page => 50).
^
app/controllers/rubygems_controller.rb:19:1: C: Indent access modifiers like private.
private
^^^^^^^
app/controllers/rubygems_controller.rb:22:5: C: %w-literals should be delimited by ( and )
%w[name downloads].include?(params[:sort]) ? params[:sort] : 'name'
^^^^^^^^^^^^^^^^^^
app/controllers/rubygems_controller.rb:26:5: C: %w-literals should be delimited by ( and )
%w[asc desc].include?(params[:direction]) ? params[:direction] : 'asc'
^^^^^^^^^^^^
app/controllers/rubygems_controller.rb:28:1: C: Extra empty line detected at body end.
app/controllers/errors_controller.rb:1:1: C: Missing top-level class documentation comment.
class ErrorsController < ApplicationController
^^^^^
Rakefile:3:81: C: Line is too long. [90/80]
# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
^^^^^^^^^^
script/cucumber:3:81: C: Line is too long. [110/80]
vendored_cucumber_bin = Dir["#{File.dirname(__FILE__)}/../vendor/{gems,plugins}/cucumber*/bin/cucumber"].first
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
db/seeds.rb:1:81: C: Line is too long. [103/80]
# This file should contain all the record creation needed to seed the database with its default values.
^^^^^^^^^^^^^^^^^^^^^^^
db/seeds.rb:2:81: C: Line is too long. [96/80]
# The data can then be loaded with the rake db:seed (or created alongside the db with db:setup).
^^^^^^^^^^^^^^^^
db/schema.rb:4:81: C: Line is too long. [81/80]
# incrementally modify your database, and then regenerate this schema definition.
^
db/schema.rb:9:81: C: Line is too long. [86/80]
# from scratch. The latter is a flawed and unsustainable approach (the more migrations
^^^^^^
db/schema.rb:12:81: C: Line is too long. [86/80]
# It's strongly recommended that you check this file into your version control system.
^^^^^^
db/schema.rb:14:38: C: Separate every 3 digits in the integer portion of a number with underscores(_).
ActiveRecord::Schema.define(version: 20140519095419) do
^^^^^^^^^^^^^^
db/schema.rb:16:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
create_table "bugs", force: true do |t|
^^^^^^
db/schema.rb:17:13: C: Put one space between the method name and the first argument.
t.string "name"
^^^
db/schema.rb:17:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "name"
^^^^^^
db/schema.rb:18:13: C: Put one space between the method name and the first argument.
t.string "bz_id"
^^^
db/schema.rb:18:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "bz_id"
^^^^^^^
db/schema.rb:19:14: C: Put one space between the method name and the first argument.
t.integer "fedora_rpm_id"
^^
db/schema.rb:19:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.integer "fedora_rpm_id"
^^^^^^^^^^^^^^^
db/schema.rb:20:14: C: Put one space between the method name and the first argument.
t.boolean "is_review"
^^
db/schema.rb:20:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.boolean "is_review"
^^^^^^^^^^^
db/schema.rb:21:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "created_at"
^^^^^^^^^^^^
db/schema.rb:22:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "updated_at"
^^^^^^^^^^^^
db/schema.rb:23:13: C: Put one space between the method name and the first argument.
t.string "last_updated"
^^^
db/schema.rb:23:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "last_updated"
^^^^^^^^^^^^^^
db/schema.rb:24:14: C: Put one space between the method name and the first argument.
t.boolean "is_open"
^^
db/schema.rb:24:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.boolean "is_open"
^^^^^^^^^
db/schema.rb:27:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
create_table "builds", force: true do |t|
^^^^^^^^
db/schema.rb:28:13: C: Put one space between the method name and the first argument.
t.string "name"
^^^
db/schema.rb:28:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "name"
^^^^^^
db/schema.rb:29:13: C: Put one space between the method name and the first argument.
t.string "build_id"
^^^
db/schema.rb:29:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "build_id"
^^^^^^^^^^
db/schema.rb:30:14: C: Put one space between the method name and the first argument.
t.integer "fedora_rpm_id"
^^
db/schema.rb:30:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.integer "fedora_rpm_id"
^^^^^^^^^^^^^^^
db/schema.rb:31:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "created_at"
^^^^^^^^^^^^
db/schema.rb:32:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "updated_at"
^^^^^^^^^^^^
db/schema.rb:35:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
create_table "dependencies", force: true do |t|
^^^^^^^^^^^^^^
db/schema.rb:36:13: C: Put one space between the method name and the first argument.
t.string "environment"
^^^
db/schema.rb:36:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "environment"
^^^^^^^^^^^^^
db/schema.rb:37:13: C: Put one space between the method name and the first argument.
t.string "dependent", null: false
^^^
db/schema.rb:37:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "dependent", null: false
^^^^^^^^^^^
db/schema.rb:38:13: C: Put one space between the method name and the first argument.
t.string "dependent_version"
^^^
db/schema.rb:38:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "dependent_version"
^^^^^^^^^^^^^^^^^^^
db/schema.rb:39:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "created_at"
^^^^^^^^^^^^
db/schema.rb:40:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "updated_at"
^^^^^^^^^^^^
db/schema.rb:41:14: C: Put one space between the method name and the first argument.
t.integer "package_id"
^^
db/schema.rb:41:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.integer "package_id"
^^^^^^^^^^^^
db/schema.rb:42:13: C: Put one space between the method name and the first argument.
t.string "package_type"
^^^
db/schema.rb:42:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "package_type"
^^^^^^^^^^^^^^
db/schema.rb:45:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
create_table "fedora_rpms", force: true do |t|
^^^^^^^^^^^^^
db/schema.rb:46:13: C: Put one space between the method name and the first argument.
t.string "name", null: false
^^^
db/schema.rb:46:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "name", null: false
^^^^^^
db/schema.rb:47:13: C: Put one space between the method name and the first argument.
t.string "source_uri"
^^^
db/schema.rb:47:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "source_uri"
^^^^^^^^^^^^
db/schema.rb:48:13: C: Put one space between the method name and the first argument.
t.string "last_commit_message"
^^^
db/schema.rb:48:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "last_commit_message"
^^^^^^^^^^^^^^^^^^^^^
db/schema.rb:49:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "created_at"
^^^^^^^^^^^^
db/schema.rb:50:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "updated_at"
^^^^^^^^^^^^
db/schema.rb:51:13: C: Put one space between the method name and the first argument.
t.string "author"
^^^
db/schema.rb:51:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "author"
^^^^^^^^
db/schema.rb:52:13: C: Put one space between the method name and the first argument.
t.string "last_committer"
^^^
db/schema.rb:52:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "last_committer"
^^^^^^^^^^^^^^^^
db/schema.rb:53:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "last_commit_date"
^^^^^^^^^^^^^^^^^^
db/schema.rb:54:13: C: Put one space between the method name and the first argument.
t.string "last_commit_sha"
^^^
db/schema.rb:54:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "last_commit_sha"
^^^^^^^^^^^^^^^^^
db/schema.rb:55:13: C: Put one space between the method name and the first argument.
t.string "homepage"
^^^
db/schema.rb:55:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "homepage"
^^^^^^^^^^
db/schema.rb:56:14: C: Put one space between the method name and the first argument.
t.integer "ruby_gem_id"
^^
db/schema.rb:56:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.integer "ruby_gem_id"
^^^^^^^^^^^^^
db/schema.rb:57:14: C: Put one space between the method name and the first argument.
t.integer "commits"
^^
db/schema.rb:57:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.integer "commits"
^^^^^^^^^
db/schema.rb:58:13: C: Put one space between the method name and the first argument.
t.string "fedora_user"
^^^
db/schema.rb:58:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "fedora_user"
^^^^^^^^^^^^^
db/schema.rb:59:11: C: Put one space between the method name and the first argument.
t.text "summary", limit: 255
^^^^^
db/schema.rb:59:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.text "summary", limit: 255
^^^^^^^^^
db/schema.rb:60:11: C: Put one space between the method name and the first argument.
t.text "description", limit: 255
^^^^^
db/schema.rb:60:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.text "description", limit: 255
^^^^^^^^^^^^^
db/schema.rb:63:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
create_table "gem_versions", force: true do |t|
^^^^^^^^^^^^^^
db/schema.rb:64:13: C: Put one space between the method name and the first argument.
t.string "gem_version"
^^^
db/schema.rb:64:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "gem_version"
^^^^^^^^^^^^^
db/schema.rb:65:14: C: Put one space between the method name and the first argument.
t.integer "ruby_gem_id"
^^
db/schema.rb:65:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.integer "ruby_gem_id"
^^^^^^^^^^^^^
db/schema.rb:66:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "created_at"
^^^^^^^^^^^^
db/schema.rb:67:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "updated_at"
^^^^^^^^^^^^
db/schema.rb:70:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
create_table "historical_gems", force: true do |t|
^^^^^^^^^^^^^^^^^
db/schema.rb:71:14: C: Put one space between the method name and the first argument.
t.integer "gem_id"
^^
db/schema.rb:71:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.integer "gem_id"
^^^^^^^^
db/schema.rb:72:13: C: Put one space between the method name and the first argument.
t.string "version"
^^^
db/schema.rb:72:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "version"
^^^^^^^^^
db/schema.rb:73:13: C: Put one space between the method name and the first argument.
t.string "build_date"
^^^
db/schema.rb:73:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "build_date"
^^^^^^^^^^^^
db/schema.rb:74:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "created_at"
^^^^^^^^^^^^
db/schema.rb:75:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "updated_at"
^^^^^^^^^^^^
db/schema.rb:78:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
create_table "rpm_versions", force: true do |t|
^^^^^^^^^^^^^^
db/schema.rb:79:14: C: Put one space between the method name and the first argument.
t.integer "fedora_rpm_id"
^^
db/schema.rb:79:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.integer "fedora_rpm_id"
^^^^^^^^^^^^^^^
db/schema.rb:80:13: C: Put one space between the method name and the first argument.
t.string "rpm_version"
^^^
db/schema.rb:80:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "rpm_version"
^^^^^^^^^^^^^
db/schema.rb:81:13: C: Put one space between the method name and the first argument.
t.string "fedora_version"
^^^
db/schema.rb:81:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "fedora_version"
^^^^^^^^^^^^^^^^
db/schema.rb:82:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "created_at"
^^^^^^^^^^^^
db/schema.rb:83:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "updated_at"
^^^^^^^^^^^^
db/schema.rb:84:14: C: Put one space between the method name and the first argument.
t.boolean "is_patched"
^^
db/schema.rb:84:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.boolean "is_patched"
^^^^^^^^^^^^
db/schema.rb:87:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
create_table "ruby_gems", force: true do |t|
^^^^^^^^^^^
db/schema.rb:88:13: C: Put one space between the method name and the first argument.
t.string "name", null: false
^^^
db/schema.rb:88:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "name", null: false
^^^^^^
db/schema.rb:89:11: C: Put one space between the method name and the first argument.
t.text "description", limit: 255
^^^^^
db/schema.rb:89:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.text "description", limit: 255
^^^^^^^^^^^^^
db/schema.rb:90:13: C: Put one space between the method name and the first argument.
t.string "homepage"
^^^
db/schema.rb:90:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "homepage"
^^^^^^^^^^
db/schema.rb:91:13: C: Put one space between the method name and the first argument.
t.string "version"
^^^
db/schema.rb:91:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "version"
^^^^^^^^^
db/schema.rb:92:14: C: Put one space between the method name and the first argument.
t.boolean "has_rpm"
^^
db/schema.rb:92:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.boolean "has_rpm"
^^^^^^^^^
db/schema.rb:93:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "created_at"
^^^^^^^^^^^^
db/schema.rb:94:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.datetime "updated_at"
^^^^^^^^^^^^
db/schema.rb:95:14: C: Put one space between the method name and the first argument.
t.integer "downloads"
^^
db/schema.rb:95:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.integer "downloads"
^^^^^^^^^^^
db/schema.rb:96:13: C: Put one space between the method name and the first argument.
t.string "source_uri"
^^^
db/schema.rb:96:16: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
t.string "source_uri"
^^^^^^^^^^^^
db/migrate/20120716155426_create_rpm_versions.rb:1:1: C: Missing top-level class documentation comment.
class CreateRpmVersions < ActiveRecord::Migration
^^^^^
db/migrate/20120723053651_add_source_uri_column_to_ruby_gem.rb:1:1: C: Missing top-level class documentation comment.
class AddSourceUriColumnToRubyGem < ActiveRecord::Migration
^^^^^
db/migrate/20120724100214_create_dependencies.rb:1:1: C: Missing top-level class documentation comment.
class CreateDependencies < ActiveRecord::Migration
^^^^^
db/migrate/20120712122611_add_downloads_to_ruby_gems.rb:1:1: C: Missing top-level class documentation comment.
class AddDownloadsToRubyGems < ActiveRecord::Migration
^^^^^
db/migrate/20130312132803_add_is_open_to_bugs.rb:1:1: C: Missing top-level class documentation comment.
class AddIsOpenToBugs < ActiveRecord::Migration
^^^^^
db/migrate/20120618141450_modify_fedora_rpm.rb:1:1: C: Missing top-level class documentation comment.
class ModifyFedoraRpm < ActiveRecord::Migration
^^^^^
db/migrate/20121212173207_create_historical_gems.rb:1:1: C: Missing top-level class documentation comment.
class CreateHistoricalGems < ActiveRecord::Migration
^^^^^
db/migrate/20120713162923_add_commits_to_fedora_rpms.rb:1:1: C: Missing top-level class documentation comment.
class AddCommitsToFedoraRpms < ActiveRecord::Migration
^^^^^
db/migrate/20120619162832_add_reference_to_ruby_gem.rb:1:1: C: Missing top-level class documentation comment.
class AddReferenceToRubyGem < ActiveRecord::Migration
^^^^^
db/migrate/20120614134039_remove_last_patch_column_from_fedora_rpm.rb:1:1: C: Missing top-level class documentation comment.
class RemoveLastPatchColumnFromFedoraRpm < ActiveRecord::Migration
^^^^^
db/migrate/20140519095419_change_fedora_rpm_description_from_string_to_text.rb:1:1: C: Missing top-level class documentation comment.
class ChangeFedoraRpmDescriptionFromStringToText < ActiveRecord::Migration
^^^^^
db/migrate/20120724121813_set_dependent_not_null.rb:1:1: C: Missing top-level class documentation comment.
class SetDependentNotNull < ActiveRecord::Migration
^^^^^
db/migrate/20120724121813_set_dependent_not_null.rb:3:55: C: Use the new Ruby 1.9 hash syntax.
change_column :dependencies, :dependent, :string, :null => false
^^^^^^^^
db/migrate/20120904112311_add_bugs.rb:1:1: C: Missing top-level class documentation comment.
class AddBugs < ActiveRecord::Migration
^^^^^
db/migrate/20120606144830_create_fedora_rpms.rb:1:1: C: Missing top-level class documentation comment.
class CreateFedoraRpms < ActiveRecord::Migration
^^^^^
db/migrate/20120606144830_create_fedora_rpms.rb:4:23: C: Use the new Ruby 1.9 hash syntax.
t.string :name, :null => false
^^^^^^^^
db/migrate/20120606144830_create_fedora_rpms.rb:4:37: C: Trailing whitespace detected.
t.string :name, :null => false
^
db/migrate/20120606144830_create_fedora_rpms.rb:10:20: C: Use the new Ruby 1.9 hash syntax.
t.references :ruby_gem => {:default => nil}
^^^^^^^^^^^^
db/migrate/20120606144830_create_fedora_rpms.rb:10:33: C: Space inside { missing.
t.references :ruby_gem => {:default => nil}
^
db/migrate/20120606144830_create_fedora_rpms.rb:10:34: C: Use the new Ruby 1.9 hash syntax.
t.references :ruby_gem => {:default => nil}
^^^^^^^^^^^
db/migrate/20120606144830_create_fedora_rpms.rb:10:49: C: Space inside } missing.
t.references :ruby_gem => {:default => nil}
^
db/migrate/20120606144830_create_fedora_rpms.rb:14:1: C: Trailing whitespace detected.
db/migrate/20120724121403_remove_name_column_from_dependencies.rb:1:1: C: Missing top-level class documentation comment.
class RemoveNameColumnFromDependencies < ActiveRecord::Migration
^^^^^
db/migrate/20130103111220_add_more_to_fedora_rpms.rb:1:1: C: Missing top-level class documentation comment.
class AddMoreToFedoraRpms < ActiveRecord::Migration
^^^^^
db/migrate/20120620123237_remove_redundant_ref_in_ruby_gem.rb:1:1: C: Missing top-level class documentation comment.
class RemoveRedundantRefInRubyGem < ActiveRecord::Migration
^^^^^
db/migrate/20120606144817_create_ruby_gems.rb:1:1: C: Missing top-level class documentation comment.
class CreateRubyGems < ActiveRecord::Migration
^^^^^
db/migrate/20120606144817_create_ruby_gems.rb:4:23: C: Use the new Ruby 1.9 hash syntax.
t.string :name, :null => false
^^^^^^^^
db/migrate/20120606144817_create_ruby_gems.rb:9:20: C: Use the new Ruby 1.9 hash syntax.
t.references :fedora_rpm => {:default => nil}
^^^^^^^^^^^^^^
db/migrate/20120606144817_create_ruby_gems.rb:9:35: C: Space inside { missing.
t.references :fedora_rpm => {:default => nil}
^
db/migrate/20120606144817_create_ruby_gems.rb:9:36: C: Use the new Ruby 1.9 hash syntax.
t.references :fedora_rpm => {:default => nil}
^^^^^^^^^^^
db/migrate/20120606144817_create_ruby_gems.rb:9:51: C: Space inside } missing.
t.references :fedora_rpm => {:default => nil}
^
db/migrate/20120606144817_create_ruby_gems.rb:13:1: C: Extra empty line detected at body end.
db/migrate/20140115094251_add_ruby_gem_versions.rb:1:1: C: Missing top-level class documentation comment.
class AddRubyGemVersions < ActiveRecord::Migration
^^^^^
db/migrate/20121015133744_mark_patched_rpms.rb:1:1: C: Missing top-level class documentation comment.
class MarkPatchedRpms < ActiveRecord::Migration
^^^^^
db/migrate/20121208152321_add_last_updated_to_bugs.rb:1:1: C: Missing top-level class documentation comment.
class AddLastUpdatedToBugs < ActiveRecord::Migration
^^^^^
db/migrate/20121208152321_add_last_updated_to_bugs.rb:1:1: C: Carriage return character detected.
class AddLastUpdatedToBugs < ActiveRecord::Migration
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
db/migrate/20121203163133_add_fedora_user_column_to_fedora_rpms.rb:1:1: C: Missing top-level class documentation comment.
class AddFedoraUserColumnToFedoraRpms < ActiveRecord::Migration
^^^^^
db/migrate/20121015122648_add_builds.rb:1:1: C: Missing top-level class documentation comment.
class AddBuilds < ActiveRecord::Migration
^^^^^
db/migrate/20120613142106_alter_fedora_rpm_table_schema.rb:1:1: C: Missing top-level class documentation comment.
class AlterFedoraRpmTableSchema < ActiveRecord::Migration
^^^^^
db/migrate/20120724124409_add_dependency_column.rb:1:1: C: Missing top-level class documentation comment.
class AddDependencyColumn < ActiveRecord::Migration
^^^^^
db/migrate/20120724124409_add_dependency_column.rb:4:30: C: Use the new Ruby 1.9 hash syntax.
t.references :package, :polymorphic => true
^^^^^^^^^^^^^^^
config/application.rb:9:1: C: Extra blank line detected.
config/application.rb:11:3: C: Missing top-level class documentation comment.
class Application < Rails::Application
^^^^^
config/application.rb:12:81: C: Line is too long. [82/80]
# Settings in config/environments/* take precedence over those specified here.
^^
config/application.rb:19:81: C: Line is too long. [85/80]
# Only load the plugins named here, in the order given (default is alphabetical).
^^^^^
config/application.rb:24:81: C: Line is too long. [83/80]
# config.active_record.observers = :cacher, :garbage_collector, :forum_observer
^^^
config/application.rb:26:81: C: Line is too long. [99/80]
# Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
^^^^^^^^^^^^^^^^^^^
config/application.rb:27:81: C: Line is too long. [89/80]
# Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
^^^^^^^^^
config/application.rb:30:81: C: Line is too long. [98/80]
# The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
^^^^^^^^^^^^^^^^^^
config/application.rb:31:81: C: Line is too long. [87/80]
# config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
^^^^^^^
config/application.rb:40:81: C: Line is too long. [82/80]
# Use SQL instead of Active Record's schema dumper when creating the database.
^^
config/application.rb:41:81: C: Line is too long. [87/80]
# This is necessary if your schema can't be completely dumped by the schema dumper,
^^^^^^^
config/application.rb:46:81: C: Line is too long. [100/80]
# This will create an empty whitelist of attributes available for mass-assignment for all models
^^^^^^^^^^^^^^^^^^^^
config/application.rb:47:81: C: Line is too long. [97/80]
# in your app. As such, your models will need to explicitly whitelist or blacklist accessible
^^^^^^^^^^^^^^^^^
config/application.rb:59:49: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
g.fixture_replacement :factory_girl, dir: "spec/factories"
^^^^^^^^^^^^^^^^
config/application.rb:61:11: C: Align the parameters of a method call if they span more than one line.
fixtures: true,
^^^^^^^^^^^^^^^
config/application.rb:68:1: C: Extra empty line detected at body end.
config/environments/development.rb:2:81: C: Line is too long. [84/80]
# Settings specified here will take precedence over those in config/application.rb
^^^^
config/environments/test.rb:2:81: C: Line is too long. [84/80]
# Settings specified here will take precedence over those in config/application.rb
^^^^
config/environments/test.rb:17:33: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
config.static_cache_control = "public, max-age=3600"
^^^^^^^^^^^^^^^^^^^^^^
config/environments/production.rb:2:81: C: Line is too long. [84/80]
# Settings specified here will take precedence over those in config/application.rb
^^^^
config/environments/production.rb:33:81: C: Line is too long. [96/80]
# Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
^^^^^^^^^^^^^^^^
config/environments/production.rb:51:81: C: Line is too long. [104/80]
# Precompile additional assets (application.js, application.css, and all non-JS/CSS are already added)
^^^^^^^^^^^^^^^^^^^^^^^^
config/initializers/backtrace_silencers.rb:3:81: C: Line is too long. [107/80]
# You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.
^^^^^^^^^^^^^^^^^^^^^^^^^^^
config/initializers/backtrace_silencers.rb:6:81: C: Line is too long. [112/80]
# You can also remove all the silencers if you're trying to debug a problem that might stem from framework code.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
config/initializers/encoding_fix.rb:2:44: C: Final newline missing.
Encoding.default_external = Encoding::UTF_8
config/initializers/fast_gettext.rb:2:36: C: Use the new Ruby 1.9 hash syntax.
FastGettext.add_text_domain 'app', :path => 'locale', :type => :po
^^^^^^^^
config/initializers/fast_gettext.rb:2:55: C: Use the new Ruby 1.9 hash syntax.
FastGettext.add_text_domain 'app', :path => 'locale', :type => :po
^^^^^^^^
config/initializers/fast_gettext.rb:3:1: C: Trailing whitespace detected.
config/initializers/fast_gettext.rb:6:81: C: Line is too long. [85/80]
# (note: the first one is used as a fallback if you try to set an unavailable locale)
^^^^^
config/initializers/fast_gettext.rb:7:41: C: Use %w or %W for array of words.
FastGettext.default_available_locales = ["en", "es", "uk", "sk", "fr", "ja"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
config/initializers/fast_gettext.rb:7:42: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
FastGettext.default_available_locales = ["en", "es", "uk", "sk", "fr", "ja"]
^^^^
config/initializers/fast_gettext.rb:7:48: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
FastGettext.default_available_locales = ["en", "es", "uk", "sk", "fr", "ja"]
^^^^
config/initializers/fast_gettext.rb:7:54: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
FastGettext.default_available_locales = ["en", "es", "uk", "sk", "fr", "ja"]
^^^^
config/initializers/fast_gettext.rb:7:60: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
FastGettext.default_available_locales = ["en", "es", "uk", "sk", "fr", "ja"]
^^^^
config/initializers/fast_gettext.rb:7:66: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
FastGettext.default_available_locales = ["en", "es", "uk", "sk", "fr", "ja"]
^^^^
config/initializers/fast_gettext.rb:7:72: C: Prefer single-quoted strings when you don't need string interpolation or special symbols.
FastGettext.default_available_locales = ["en", "es", "uk", "sk", "fr", "ja"]
^^^^
config/initializers/fast_gettext.rb:8:1: C: Trailing whitespace detected.
config/initializers/session_store.rb:3:81: C: Line is too long. [94/80]
Isitfedoraruby::Application.config.session_store :cookie_store, key: '_isitfedoraruby_session'
^^^^^^^^^^^^^^
config/initializers/jazz_hands.rb:1:1: C: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
if defined?(JazzHands)
^^
config/initializers/secret_token.rb:7:81: C: Line is too long. [180/80]
Isitfedoraruby::Application.config.secret_token = '7046169d91ecd398186388e14189e1b85945c0428382e612f2fec1092fe9dfd7d758f901804d86fb6e3c31fc3ec515061a189bd56e133ce93729ebc69cc881f9'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
config/initializers/wrap_parameters.rb:6:81: C: Line is too long. [96/80]
# Enable parameter wrapping for JSON. You can disable this by setting :format to an empty array.
^^^^^^^^^^^^^^^^
config/initializers/wrap_parameters.rb:8:19: C: Use the new Ruby 1.9 hash syntax.
wrap_parameters :format => [:json] if respond_to?(:wrap_parameters)
^^^^^^^^^^
config/routes.rb:13:26: C: Use the new Ruby 1.9 hash syntax.
resources :fedorarpms, :constraints => { :id => /.*/ } do
^^^^^^^^^^^^^^^
config/routes.rb:13:44: C: Use the new Ruby 1.9 hash syntax.
resources :fedorarpms, :constraints => { :id => /.*/ } do
^^^^^^
config/routes.rb:14:21: C: Use the new Ruby 1.9 hash syntax.
get :full_deps, :on => :member
^^^^^^
config/routes.rb:15:29: C: Use the new Ruby 1.9 hash syntax.
get :full_dependencies, :on => :member
^^^^^^
config/routes.rb:16:29: C: Use the new Ruby 1.9 hash syntax.
get :full_dependents, :on => :member
^^^^^^
config/routes.rb:17:20: C: Use the new Ruby 1.9 hash syntax.
get :by_owner, :on => :member
^^^^^^
config/routes.rb:18:17: C: Use the new Ruby 1.9 hash syntax.
get :badge, :on => :member
^^^^^^
config/routes.rb:19:21: C: Use the new Ruby 1.9 hash syntax.
get :not_found, :on => :member
^^^^^^
config/routes.rb:21:24: C: Use the new Ruby 1.9 hash syntax.
resources :rubygems, :constraints => { :id => /.*/ }
^^^^^^^^^^^^^^^
config/routes.rb:21:42: C: Use the new Ruby 1.9 hash syntax.
resources :rubygems, :constraints => { :id => /.*/ }
^^^^^^
config/routes.rb:24:18: C: Use the new Ruby 1.9 hash syntax.
get :import, :on => :collection
^^^^^^
config/routes.rb:25:19: C: Use the new Ruby 1.9 hash syntax.
post :import, :on => :collection
^^^^^^
config/routes.rb:28:21: C: Use the new Ruby 1.9 hash syntax.
resources :stats, :constraints => { :id => /.*/ } do
^^^^^^^^^^^^^^^
config/routes.rb:28:39: C: Use the new Ruby 1.9 hash syntax.
resources :stats, :constraints => { :id => /.*/ } do
^^^^^^
config/routes.rb:29:24: C: Use the new Ruby 1.9 hash syntax.
get :gemfile_tool, :on => :collection
^^^^^^
config/routes.rb:34:25: C: Use the new Ruby 1.9 hash syntax.
post :gemfile_tool, :on => :collection
^^^^^^
config/routes.rb:37:1: C: Incorrect indentation detected (column 0 instead of 4).
# unless Rails.application.config.consider_all_requests_local
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
config/routes.rb:38:5: C: Inconsistent indentation detected.
get '*not_found', to: 'errors#error_404'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
config/routes.rb:39:1: C: Incorrect indentation detected (column 0 instead of 2).
# end
^^^^^^
105 files inspected, 666 offenses detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment