Skip to content

Instantly share code, notes, and snippets.

View b-rad-NDi's full-sized avatar

Brad Love b-rad-NDi

View GitHub Profile
@b-rad-NDi
b-rad-NDi / em28xx-i2c-debug.patch
Last active June 24, 2020 18:05
extra em28xx i2c debug where there's failure
diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
index 592b98b3643a..555b7f55bb2c 100644
--- a/drivers/media/usb/em28xx/em28xx-i2c.c
+++ b/drivers/media/usb/em28xx/em28xx-i2c.c
@@ -294,6 +294,10 @@ static int em28xx_i2c_recv_bytes(struct em28xx *dev, u16 addr, u8 *buf, u16 len)
"reading from i2c device at 0x%x failed (error=%i)\n",
addr, ret);
return ret;
+ } else if (ret != len) {
+ dev_dbg(&dev->intf->dev,
diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c
index 5abab1eb..87b5486 100644
--- a/drivers/media/usb/au0828/au0828-core.c
+++ b/drivers/media/usb/au0828/au0828-core.c
@@ -626,8 +626,8 @@ static int au0828_usb_probe(struct usb_interface *interface,
/* Analog TV */
retval = au0828_analog_register(dev, interface);
if (retval) {
- pr_err("%s() au0282_dev_register failed to register on V4L2\n",
- __func__);
From ee3b5f37446df3cef8b8c1791724426c6a74fcdc Mon Sep 17 00:00:00 2001
From: Brad Love <brad@nextdimension.cc>
Date: Thu, 6 Sep 2018 13:19:44 -0500
Subject: [PATCH] au0828: cannot kfree dev before usb disconnect
au0828_usb_disconnect uses dev. If dev is NULL then there is immediate oops.
Signed-off-by: Brad Love <brad@nextdimension.cc>
---
drivers/media/usb/au0828/au0828-core.c | 1 -