Skip to content

Instantly share code, notes, and snippets.

@beatmadsen
Last active October 26, 2018 23:56
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save beatmadsen/ae9e7b366fa4e9b4129f8d40990c8473 to your computer and use it in GitHub Desktop.
Save beatmadsen/ae9e7b366fa4e9b4129f8d40990c8473 to your computer and use it in GitHub Desktop.
Bad reuse with boolean parameter
# calling code:
age = find_age(name: user.name, divert: !user.belongs_to_system_a?)
# methods
def find_age(name:, divert:)
payload = { name: name, size: 42 }
response = divert ? call_system_b(payload) : call_system_a(payload)
if response.use_dog_years?
response.age * 7
else
response.age
end
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment