Created
April 29, 2014 22:10
-
-
Save benbjohnson/ce54185a0a44bb29cc9f to your computer and use it in GitHub Desktop.
hashicorp/raft: golint
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $ golint . | |
| commands.go:3:6: exported type AppendEntriesRequest should have comment or be unexported | |
| commands.go:19:6: exported type AppendEntriesResponse should have comment or be unexported | |
| commands.go:30:6: exported type RequestVoteRequest should have comment or be unexported | |
| commands.go:40:6: exported type RequestVoteResponse should have comment or be unexported | |
| commands.go:51:6: exported type InstallSnapshotRequest should have comment or be unexported | |
| commands.go:66:6: exported type InstallSnapshotResponse should have comment or be unexported | |
| config.go:64:1: exported function DefaultConfig should have comment or be unexported | |
| file_snapshot.go:38:1: comment on exported type FileSnapshotSink should be of the form "FileSnapshotSink ..." (with optional leading article) | |
| file_snapshot.go:191:1: exported method FileSnapshotStore.List should have comment or be unexported | |
| file_snapshot.go:272:1: exported method FileSnapshotStore.Open should have comment or be unexported | |
| file_snapshot.go:324:1: comment on exported method FileSnapshotStore.ReapSnapshots should be of the form "ReapSnapshots ..." | |
| inmem_store.go:30:1: exported method InmemStore.FirstIndex should have comment or be unexported | |
| inmem_store.go:34:1: exported method InmemStore.LastIndex should have comment or be unexported | |
| inmem_store.go:38:1: exported method InmemStore.GetLog should have comment or be unexported | |
| inmem_store.go:49:1: exported method InmemStore.StoreLog should have comment or be unexported | |
| inmem_store.go:53:1: exported method InmemStore.StoreLogs should have comment or be unexported | |
| inmem_store.go:68:1: exported method InmemStore.DeleteRange should have comment or be unexported | |
| inmem_store.go:79:1: exported method InmemStore.Set should have comment or be unexported | |
| inmem_store.go:86:1: exported method InmemStore.Get should have comment or be unexported | |
| inmem_store.go:92:1: exported method InmemStore.SetUint64 should have comment or be unexported | |
| inmem_store.go:99:1: exported method InmemStore.GetUint64 should have comment or be unexported | |
| inmem_transport.go:11:1: comment on exported type InmemAddr should be of the form "InmemAddr ..." (with optional leading article) | |
| inmem_transport.go:22:1: exported method InmemAddr.Network should have comment or be unexported | |
| inmem_transport.go:30:1: comment on exported type InmemTransport should be of the form "InmemTransport ..." (with optional leading article) | |
| inmem_transport.go:53:1: exported method InmemTransport.Consumer should have comment or be unexported | |
| inmem_transport.go:57:1: exported method InmemTransport.LocalAddr should have comment or be unexported | |
| inmem_transport.go:61:1: exported method InmemTransport.AppendEntries should have comment or be unexported | |
| inmem_transport.go:73:1: exported method InmemTransport.RequestVote should have comment or be unexported | |
| inmem_transport.go:85:1: exported method InmemTransport.InstallSnapshot should have comment or be unexported | |
| inmem_transport.go:127:1: comment on exported method InmemTransport.EncodePeer should be of the form "EncodePeer ..." | |
| inmem_transport.go:132:1: comment on exported method InmemTransport.DecodePeer should be of the form "DecodePeer ..." | |
| inmem_transport.go:13:2: struct field Id should be ID | |
| inmem_transport.go:103:20: error strings should not be capitalized | |
| log.go:8:6: exported type LogType should have comment or be unexported | |
| log.go:11:2: comment on exported const LogCommand should be of the form "LogCommand ..." | |
| log.go:14:2: comment on exported const LogNoop should be of the form "LogNoop ..." | |
| log.go:17:2: comment on exported const LogAddPeer should be of the form "LogAddPeer ..." | |
| log.go:20:2: comment on exported const LogRemovePeer should be of the form "LogRemovePeer ..." | |
| log.go:23:2: comment on exported const LogBarrier should be of the form "LogBarrier ..." | |
| log.go:33:2: exported var LogNotFound should have comment or be unexported | |
| log.go:33:2: error var LogNotFound should have name of the form ErrFoo | |
| net_transport.go:19:2: exported const DefaultTimeoutScale should have comment (or a comment on this block) or be unexported | |
| net_transport.go:23:2: exported var TransportShutdown should have comment or be unexported | |
| net_transport.go:87:1: comment on exported function NewNetworkTransport should be of the form "NewNetworkTransport ..." | |
| net_transport.go:123:1: exported method NetworkTransport.Consumer should have comment or be unexported | |
| net_transport.go:127:1: exported method NetworkTransport.LocalAddr should have comment or be unexported | |
| net_transport.go:193:1: exported method NetworkTransport.AppendEntries should have comment or be unexported | |
| net_transport.go:197:1: exported method NetworkTransport.RequestVote should have comment or be unexported | |
| net_transport.go:223:1: exported method NetworkTransport.InstallSnapshot should have comment or be unexported | |
| net_transport.go:259:1: exported method NetworkTransport.EncodePeer should have comment or be unexported | |
| net_transport.go:263:1: exported method NetworkTransport.DecodePeer should have comment or be unexported | |
| net_transport.go:23:2: error var TransportShutdown should have name of the form ErrFoo | |
| net_transport.go:266:20: error strings should not be capitalized | |
| peer.go:31:1: comment on exported type StaticPeers should be of the form "StaticPeers ..." (with optional leading article) | |
| peer.go:36:1: exported method StaticPeers.Peers should have comment or be unexported | |
| peer.go:40:1: exported method StaticPeers.SetPeers should have comment or be unexported | |
| peer.go:64:1: exported method JSONPeers.Peers should have comment or be unexported | |
| peer.go:94:1: exported method JSONPeers.SetPeers should have comment or be unexported | |
| raft.go:24:2: exported var NotLeader should have comment or be unexported | |
| raft.go:47:6: exported type Raft should have comment or be unexported | |
| raft.go:1258:9: if block ends with a return statement, so drop this else and outdent its block | |
| raft.go:24:2: error var NotLeader should have name of the form ErrFoo | |
| raft.go:25:2: error var LeadershipLost should have name of the form ErrFoo | |
| raft.go:26:2: error var RaftShutdown should have name of the form ErrFoo | |
| raft.go:27:2: error var EnqueueTimeout should have name of the form ErrFoo | |
| raft.go:28:2: error var KnownPeer should have name of the form ErrFoo | |
| raft.go:29:2: error var UnknownPeer should have name of the form ErrFoo | |
| raft.go:134:26: error strings should not be capitalized | |
| raft.go:140:26: error strings should not be capitalized | |
| raft.go:146:26: error strings should not be capitalized | |
| raft.go:153:27: error strings should not be capitalized | |
| raft.go:161:26: error strings should not be capitalized | |
| raft.go:420:28: error strings should not be capitalized | |
| raft.go:428:28: error strings should not be capitalized | |
| raft.go:1031:31: error strings should not be capitalized | |
| raft.go:1232:23: error strings should not be capitalized | |
| raft.go:1382:20: error strings should not be capitalized | |
| raft.go:1452:21: error strings should not be capitalized | |
| raft.go:1466:21: error strings should not be capitalized | |
| raft.go:1474:21: error strings should not be capitalized | |
| raft.go:1480:21: error strings should not be capitalized | |
| raft.go:1504:21: error strings should not be capitalized | |
| raft.go:1518:21: error strings should not be capitalized | |
| raft.go:1563:21: error strings should not be capitalized and should not end with punctuation | |
| replication.go:224:2: var snapId should be snapID | |
| state.go:7:6: exported type RaftState should have comment or be unexported | |
| state.go:10:2: exported const Follower should have comment (or a comment on this block) or be unexported | |
| state.go:158:9: if block ends with a return statement, so drop this else and outdent its block | |
| tcp_transport.go:48:1: exported method TCPStreamLayer.Dial should have comment or be unexported | |
| tcp_transport.go:52:1: exported method TCPStreamLayer.Accept should have comment or be unexported | |
| tcp_transport.go:56:1: exported method TCPStreamLayer.Close should have comment or be unexported | |
| tcp_transport.go:60:1: exported method TCPStreamLayer.Addr should have comment or be unexported | |
| tcp_transport.go:36:26: error strings should not be capitalized and should not end with punctuation | |
| tcp_transport.go:40:26: error strings should not be capitalized and should not end with punctuation | |
| util.go:106:9: if block ends with a return statement, so drop this else and outdent its block | |
| util.go:43:20: error strings should not be capitalized | |
| util.go:122:20: error strings should not be capitalized | |
| util.go:133:20: error strings should not be capitalized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment