Skip to content

Instantly share code, notes, and snippets.

Nikhil Benesch benesch

Block or report user

Report or block benesch

Hide content and notifications from this user.

Learn more about blocking users

Contact Support about this user’s behavior.

Learn more about reporting abuse

Report abuse
View GitHub Profile
View 37705.patch
diff --git a/src/github.com/cockroachdb/cockroach/pkg/server/config_unix.go b/src/github.com/cockroachdb/cockroach/pkg/server/config_unix.go
index a88e4f6068..e0702f3336 100644
--- a/src/github.com/cockroachdb/cockroach/pkg/server/config_unix.go
+++ b/src/github.com/cockroachdb/cockroach/pkg/server/config_unix.go
@@ -22,6 +22,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/storage/engine"
"github.com/cockroachdb/cockroach/pkg/util/log"
+ "github.com/pkg/errors"
)
View gist:e86bc2ec021c3c7cda356677da9e7fef
source root is source
unpacking source archive /nix/store/03fgfsvjcchgyg0jjy6i420ffvdql89d-rustup-1.16.0-vendor
patching sources
configuring
building
Running cargo build --release --features no-self-update
Compiling semver-parser v0.7.0
Compiling version_check v0.1.5
Compiling rand_core v0.3.0
Compiling void v1.0.2
View index.html
<p>To use, drag a link below to your bookmarks bar. Then navigate to WooCommerce and click the bookmark to activate.</p>
<ul>
<li><a href='javascript:setTimeout(() => navigator.clipboard.writeText(Array.from(document.querySelectorAll(".meta.email")).map(e => e.innerText).join("\n")), 10)'>Copy emails</a></li>
</ul>
View lto-warnings.txt
../../../libgo/go/runtime/extern.go:186:1: warning: type of ‘runtime.Callers’ does not match original declaration [-Wlto-type-mismatch]
../../../libgo/runtime/go-callers.c:243:1: note: return value type mismatch
../../../libgo/runtime/go-callers.c:243:1: note: type ‘int’ should match type ‘int’
../../../libgo/go/runtime/pprof/pprof.go:80:9: warning: type of ‘runtime.Callers’ does not match original declaration [-Wlto-type-mismatch]
../../../libgo/runtime/go-callers.c:243:1: note: return value type mismatch
../../../libgo/runtime/go-callers.c:243:1: note: type ‘int’ should match type ‘long int’
../../../libgo/go/testing/allocs.go:8:9: warning: type of ‘runtime.Callers’ does not match original declaration [-Wlto-type-mismatch]
../../../libgo/runtime/go-callers.c:243:1: note: return value type mismatch
../../../libgo/runtime/go-callers.c:243:1: note: type ‘int’ should match type ‘long int’
../../../libgo/runtime/go-callers.c:243:1: note: ‘Callers’ was previously declared here
View README
These timings were recorded on a machine with the following
specifications:
* 2.2GHz, 12-core processor (Intel Xeon E5-2650 v4 processor)
* 16GB DDR4 SDRAM (Samsung M393A2G40DB0-CPB)
* Linux distribution: Ubuntu 18.04.1 LTS
* Kernel version: 4.15.0-43-generic
I built the following versions of the compilers:
View TestInternalExecutorTxnAbortNotSwallowed.go
// TestInternalExecutorTxnAbortNotSwallowed reproduces a rare bug where the
// internal executor could swallow transaction aborted errors. Specifically, an
// optimizer code path was not propagating errors, violating the contract of our
// transaction API, and causing partial split transactions that resulted in
// replica corruption errors (#32784).
//
// Note that a fix to our transaction API to eliminate this class of errors is
// proposed in #22615.
func TestInternalExecutorTxnAbortNotSwallowed(t *testing.T) {
defer leaktest.AfterTest(t)()
View log.log
=== RUN TestStoreRangeMergeRaftSnapshot
I181211 06:35:27.048012 37049 gossip/gossip.go:391 [n1] NodeDescriptor set to node_id:1 address:<network_field:"tcp" address_field:"127.0.0.1:42779" > attrs:<> locality:<> ServerVersion:<major_val:0 minor_val:0 patch:0 unstable:0 > build_tag:"" started_at:0
W181211 06:35:27.054099 37049 gossip/gossip.go:1499 [n2] no incoming or outgoing connections
I181211 06:35:27.054193 37049 gossip/gossip.go:391 [n2] NodeDescriptor set to node_id:2 address:<network_field:"tcp" address_field:"127.0.0.1:38785" > attrs:<> locality:<> ServerVersion:<major_val:0 minor_val:0 patch:0 unstable:0 > build_tag:"" started_at:0
I181211 06:35:27.054397 37020 gossip/client.go:128 [n2] started gossip client to 127.0.0.1:42779
W181211 06:35:27.060978 37049 gossip/gossip.go:1499 [n3] no incoming or outgoing connections
I181211 06:35:27.061057 37049 gossip/gossip.go:391 [n3] NodeDescriptor set to node_id:3 address:<network_field:"tcp" address_field:"127.0.0.1:34059" > attrs:<> locality:<> Ser
View keybase.md

Keybase proof

I hereby claim:

  • I am benesch on github.
  • I am benesch (https://keybase.io/benesch) on keybase.
  • I have a public key ASC8FdNf6i6T6xfSFICLKmAVKLg7d3oYu1YQ-wqch9ZJTAo

To claim this, I am signing this object:

View term-no-space.patch
diff --git a/src/terminal.c b/src/terminal.c
index 9c74fcd..cc0169e 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -509,36 +509,14 @@ terminal_move_to_line(EditLine *el, int where)
return;
}
if ((del = where - el->el_cursor.v) > 0) {
- while (del > 0) {
- if (EL_HAS_AUTO_MARGINS &&
View tsan.diff
diff --git a/lib/tsan/go/tsan_go.cc b/lib/tsan/go/tsan_go.cc
index 71a660683..ba0dd4a08 100644
--- a/lib/tsan/go/tsan_go.cc
+++ b/lib/tsan/go/tsan_go.cc
@@ -231,48 +231,84 @@ void __tsan_proc_destroy(Processor *proc) {
}
void __tsan_acquire(ThreadState *thr, void *addr) {
+ CHECK(!thr->proc()->inuse);
+ thr->proc()->inuse = true;
You can’t perform that action at this time.