Created
August 18, 2010 18:34
-
-
Save bernEsp/535735 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Que es code smell? | |
son todos los síntomas que podemos encontrar en el código fuente de un sistema que indican que muy probablemente existan problemas más profundos de calidad de código, de diseño o de ambos | |
Metodos largos, clases largas o duplicar codigo son algunos code smell | |
Long Method? | |
def parse(arg, argv, &error) | |
if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0])) | |
return nil, block, nil # +1 | |
end | |
opt = (val = parse_arg(val, &error))[1] # +2 | |
val = conv_arg(*val) # +3 | |
if opt and !arg | |
argv.shift # +4 | |
else | |
val[0] = nil # +5 | |
end | |
val # +6 | |
end | |
Es long method por que tiene mas de 5 statements y se puede refactorisar con los simples if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment